From: David Vrabel Subject: Re: [Xen-devel] [PATCH v3 10/11] x86/rtc: replace paravirt rtc check with x86 specific solution Date: Tue, 23 Feb 2016 11:57:16 +0000 Message-ID: <56CC491C.8080505@citrix.com> References: <1456212255-23959-1-git-send-email-mcgrof@kernel.org> <1456212255-23959-11-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456212255-23959-11-git-send-email-mcgrof@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: "Luis R. Rodriguez" , bp@alien8.de, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, rusty@rustcorp.com.au Cc: xen-devel@lists.xensource.com, x86@kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, lguest@lists.ozlabs.org, david.vrabel@citrix.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On 23/02/16 07:24, Luis R. Rodriguez wrote: > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c [...] > @@ -1526,8 +1525,6 @@ asmlinkage __visible void __init xen_start_kernel(void) > > /* Install Xen paravirt ops */ > pv_info = xen_info; > - if (xen_initial_domain()) > - pv_info.features |= PV_SUPPORTED_RTC; > pv_init_ops = xen_init_ops; > if (!xen_pvh_domain()) { > pv_cpu_ops = xen_cpu_ops; > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c > index a0a4e554c6f1..fbfcb01015f0 100644 > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -446,8 +446,10 @@ void __init xen_init_time_ops(void) > x86_platform.calibrate_tsc = xen_tsc_khz; > x86_platform.get_wallclock = xen_get_wallclock; > /* Dom0 uses the native method to set the hardware RTC. */ > - if (!xen_initial_domain()) > + if (!xen_initial_domain()) { > + x86_init.platform_flags |= X86_PLATFORM_NO_RTC; > x86_platform.set_wallclock = xen_set_wallclock; > + } > } Is this an early enough point to set this flag? David