Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=dkodihal@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B5dw36scfzDqLK for ; Tue, 14 Jul 2020 21:44:19 +1000 (AEST) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06EBXfYZ034678; Tue, 14 Jul 2020 07:44:16 -0400 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 327u1hgxs2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Jul 2020 07:44:15 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06EBfVfb023245; Tue, 14 Jul 2020 11:44:13 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma02fra.de.ibm.com with ESMTP id 327527ub80-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Jul 2020 11:44:13 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06EBiBtS60817498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jul 2020 11:44:11 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0562A11C050; Tue, 14 Jul 2020 11:44:11 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0117611C04A; Tue, 14 Jul 2020 11:44:09 +0000 (GMT) Received: from Deepaks-MacBook-Pro.local (unknown [9.79.242.137]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 14 Jul 2020 11:44:08 +0000 (GMT) To: James Feist , Gunnar Mills , vishwa@linux.vnet.ibm.com Cc: "openbmc@lists.ozlabs.org" From: Deepak Kodihalli Subject: Redfish HealthRollup/LED question Message-ID: <56aeaf07-beb1-22ca-ab54-aa984ea82bf1@linux.vnet.ibm.com> Date: Tue, 14 Jul 2020 17:14:07 +0530 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-14_03:2020-07-14, 2020-07-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1011 mlxlogscore=426 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007140088 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 11:44:20 -0000 Hi James/Gunnar, On IBM platforms, a fault indicator LED associated with a FRU can indicate the "Health Rollup" status of the FRU. For eg a CPU can be healthy, but something contained within (eg a core) may be broken, so the LED will be turned on. I think the Redfish HealthRollup property is conceptually similar. Question is - do you see a problem if we add code in bmcweb that sets the HealthRollup property for a FRU if an associated LED is turned on? I believe this is aligned with https://github.com/openbmc/docs/blob/master/designs/redfish-health-rolllup.md (no new D-Bus objects/interfaces being added, etc). On IBM platforms, a D-Bus association might exist between the FRU and the LED, and setting the HealthRollup property will be based on this. If the said association is missing on other platforms, the code will not do anything. Thanks, Deepak