From: "cron2 (Code Review)" Date: Sun, 27 Jul 2025 11:02:31 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., antonio@...2726... Message-ID: <56f809cded1d20dfbd5d08a7fa83816df9b9e18d-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="9yG6wN7Ci5w="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dco: drop client prefix after DCO PEER_FLOAT notification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --9yG6wN7Ci5w= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1116?usp=3Demail ) Change subject: dco: drop client prefix after DCO PEER_FLOAT notification ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Here's another one... counter timer triggering while an outgoing TLS renego= tiation is in progress ``` Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: udp6:[2001:608:0:814::fb00= :14]:33827 Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384,= peer certificate: 2048 bits RSA, signature: RSA-SHA256, peer temporary key= : 253 bits X25519, peer signing digest/type: SHA256 RSASSA-PSS Jul 27 12:33:36 ubuntu2004 kernel: [443346.370968] tun1: del peer 1 Jul 27 12:33:36 ubuntu2004 kernel: [443346.370974] tun1: deleting peer with= id 1, reason 1 Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: udp6:[2001:608:0:814::fb00= :14]:33827 [freebsd-14-amd64] Peer Connection Initiated with [AF_INET6]2001= :608:0:814::fb00:14:33827 Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[200= 1:608:0:814::fb00:14]:33827 peer-id=3D2 dco_get_peer: peer-id -1 Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[200= 1:608:0:814::fb00:14]:33827 peer-id=3D2 ovpn-dco: received netlink message = type=3D31 cmd=3D3 flags=3D0x0002 Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[200= 1:608:0:814::fb00:14]:33827 peer-id=3D2 ovpn_handle_peer: parsing message f= or peer 0... Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[200= 1:608:0:814::fb00:14]:33827 peer-id=3D2 dco_update_peer_stat / dco_read_byt= es(0): 440 Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[200= 1:608:0:814::fb00:14]:33827 peer-id=3D2 dco_update_peer_stat / dco_write_by= tes(0): 480 ``` in this case resetting the prefix would mess up prefix logging for the TLS = handshake, so it's not the right approach anyway. Digging through error.c I found something half-forgotten... ``` /* set up client prefix */ if (flags & M_NOIPREFIX) { prefix =3D NULL; } else { prefix =3D msg_get_prefix(); } ``` so I think the *right* approach is to use `msg(...|M_NOIPREFIX, ...)` for e= verything that is not normally related to a particular MI instance - like, = most of the DCO events. Magic -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1116?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24 Gerrit-Change-Number: 1116 Gerrit-PatchSet: 2 Gerrit-Owner: ordex Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Sun, 27 Jul 2025 11:02:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --9yG6wN7Ci5w= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, ordex, plaisthos. <= /p>

View = Change

1 comment:

    =
  • Patchset:

    • Patch Set #2:

      Here's another one... counter timer triggeri= ng while an outgoing TLS renegotiation is in progress

      ```
      Jul 27 12:33:36 ubuntu2004 = tun-udp-p2mp[298589]: udp6:[2001:608:0:814::fb00:14]:33827 Control Channel:= TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 2048 bit= s RSA, signature: RSA-SHA256, peer temporary key: 253 bits X25519, peer sig= ning digest/type: SHA256 RSASSA-PSS
      Jul 27 12:33:36 ubuntu2004 kernel: [= 443346.370968] tun1: del peer 1
      Jul 27 12:33:36 ubuntu2004 kernel: [4433= 46.370974] tun1: deleting peer with id 1, reason 1
      Jul 27 12:33:36 ubunt= u2004 tun-udp-p2mp[298589]: udp6:[2001:608:0:814::fb00:14]:33827 [freebsd-1= 4-amd64] Peer Connection Initiated with [AF_INET6]2001:608:0:814::fb00:14:3= 3827
      Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/u= dp6:[2001:608:0:814::fb00:14]:33827 peer-id=3D2 dco_get_peer: peer-id -1Jul 27 12:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[20= 01:608:0:814::fb00:14]:33827 peer-id=3D2 ovpn-dco: received netlink message= type=3D31 cmd=3D3 flags=3D0x0002
      Jul 27 12:33:36 ubuntu2004 tun-udp-p2m= p[298589]: freebsd-14-amd64/udp6:[2001:608:0:814::fb00:14]:33827 peer-id=3D= 2 ovpn_handle_peer: parsing message for peer 0...
      Jul 27 12:33:36 ubuntu= 2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[2001:608:0:814::fb00:14]:= 33827 peer-id=3D2 dco_update_peer_stat / dco_read_bytes(0): 440
      Jul 27 1= 2:33:36 ubuntu2004 tun-udp-p2mp[298589]: freebsd-14-amd64/udp6:[2001:608:0:= 814::fb00:14]:33827 peer-id=3D2 dco_update_peer_stat / dco_write_bytes(0): = 480
      ```

      in= this case resetting the prefix would mess up prefix logging for the TLS ha= ndshake, so it's not the right approach anyway.

      Digging through error.c I found some= thing half-forgotten...

      ```
      /* set up client prefix */
      if (fl= ags & M_NOIPREFIX)
      {
      prefix =3D NULL;
      }
      = else
      {
      prefix =3D msg_get_prefix();
      }
      ```

      so I think the = *right* approach is to use `msg(...|M_NOIPREFIX, ...)` for everything that = is not normally related to a particular MI instance - like, most of the DCO= events.

      Magi= c

To view, visit change 1116. To unsubscribe, or for = help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1ad5df0f6785ffe9becd9f83329= a9335d1a36f24
Gerrit-Change-Number: 1116
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <antonio@...2726...= >
Gerrit-Comment-Date: Sun, 27 Jul 2025 11:02:31= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--9yG6wN7Ci5w=--