Return-Path: Received: from smtp5.clear.net.nz ([203.97.33.68]:34304 "EHLO smtp5.clear.net.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbbKYW66 (ORCPT ); Wed, 25 Nov 2015 17:58:58 -0500 Received: from mxin1-orange.clear.net.nz (lb1-srcnat.clear.net.nz [203.97.32.236]) by smtp5.clear.net.nz (CLEAR Net Mail) with ESMTP id <0NYE00BVE6MKYS00@smtp5.clear.net.nz> for linux-fsdevel@vger.kernel.org; Thu, 26 Nov 2015 11:43:56 +1300 (NZDT) Date: Thu, 26 Nov 2015 11:43:35 +1300 From: Volker Kuhlmann Subject: Re: [PATCH] fat: Allow time_offset to be upto 13 hours In-reply-to: <87poyx21cq.fsf@mail.parknet.co.jp> To: OGAWA Hirofumi Cc: Jan Kara , linux-fsdevel@vger.kernel.org Message-id: <5703679.3kKCzGj1xC@tui.site> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7Bit References: <1448466133-2838-1-git-send-email-jack@suse.cz> <13558026.NkMQpNgYP2@tui.site> <87poyx21cq.fsf@mail.parknet.co.jp> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 26 Nov 2015 06:52:37 OGAWA Hirofumi wrote: > > Or do you wish to track the legal time zone AND DST offsets in every > > place in the world, make a list, stick that into the kernel, and > > maintain it? I hope not. > > Actually, it is correct timezone support (for example, daylight). I don't get what you're trying to say here, sorry. > I'm not against to change. But don't want to change this multiple > times, and step by step. It is why I'm asking. :-) Agreed. > Well so, how does it overs 24 hours (i.e. a day) for sane tz offset > (implementation is just a dumb adjustment of timestamp, but this > option should means tz offset)? (And +-24 hours is used for TZ spec > too.) +-24h offset for time zone (incl DST) should be sufficient. However, asking the other way round, can someone please explain why there needs to be a limit check? Will there be a kernel panic if someone sticks in MAXINT? It's not the kernel's responsibility to enforce any setting of user time! Perhaps the limit check should simply be removed? I can see e.g. using this to correct for a past error in setting the time for the device the vfat filesystem was created on. That would be cool... Why enforce limits when you don't have to? Just because it fits the programmer's limited view of use cases (see 12 + 1 = OOPS)? Or is this a security problem? How about +-2years? Also see https://bugzilla.suse.com/show_bug.cgi?id=912583#c33 and ff Volker -- Volker Kuhlmann http://volker.top.geek.nz/ Please do not CC list postings to me.