From: "Koenig, Christian" Subject: Re: [PATCH 14/14] drm/amdgpu: set TMZ bits in PTEs for secure bo (v2) Date: Wed, 11 Sep 2019 12:13:19 +0000 Message-ID: <5704cdc8-754e-538e-9547-738ef81efa7c@amd.com> References: <1568202584-14471-1-git-send-email-ray.huang@amd.com> <1568202584-14471-15-git-send-email-ray.huang@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1568202584-14471-15-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US Content-ID: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Huang, Ray" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Deucher, Alexander" Cc: "Tuikov, Luben" , "Liu, Aaron" QW0gMTEuMDkuMTkgdW0gMTM6NTAgc2NocmllYiBIdWFuZywgUmF5Og0KPiBGcm9tOiBBbGV4IERl dWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+DQo+DQo+IElmIG9uZSBibyBpcyBzZWN1 cmUgKGNyZWF0ZWQgd2l0aCBBTURHUFVfR0VNX0NSRUFURV9FTkNSWVBURUQpLCB0aGUgVE1aIGJp dHMgb2YNCj4gUFRFcyB0aGF0IGJlbG9uZ3MgdGhhdCBibyBzaG91bGQgYmUgc2V0LiBUaGVuIHBz cCBpcyBhYmxlIHRvIHByb3RlY3QgdGhlIHBhZ2VzDQo+IG9mIHRoaXMgYm8gdG8gYXZvaWQgdGhl IGFjY2VzcyBmcm9tIGFuICJ1bnRydXN0IiBkb21haW4gc3VjaCBhcyBDUFUuDQo+DQo+IHYxOiBk ZXNpZ24gYW5kIGRyYWZ0IHRoZSBza2VsZXRpb24gb2YgdG16IGJpdHMgc2V0dGluZyBvbiBQVEVz IChBbGV4KQ0KPiB2MjogcmV0dXJuIGZhaWx1cmUgb25jZSBjcmVhdGUgc2VjdXJlIGJvIG9uIG5v LXRteiBwbGF0Zm9ybSAgKFJheSkNCj4NCj4gU2lnbmVkLW9mZi1ieTogQWxleCBEZXVjaGVyIDxh bGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPg0KPiBSZXZpZXdlZC1ieTogSHVhbmcgUnVpIDxyYXku aHVhbmdAYW1kLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogSHVhbmcgUnVpIDxyYXkuaHVhbmdAYW1k LmNvbT4NCj4gLS0tDQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5j ICAgIHwgMTIgKysrKysrKysrKystDQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X29iamVjdC5oIHwgMTAgKysrKysrKysrKw0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV90dG0uYyAgICB8ICA1ICsrKysrDQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyNiBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfZ2VtLmMNCj4gaW5kZXggMjJlYWI3NC4uNTMzMjEwNCAxMDA2NDQNCj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jDQo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nZW0uYw0KPiBAQCAtMjIyLDcgKzIyMiw4IEBAIGlu dCBhbWRncHVfZ2VtX2NyZWF0ZV9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpk YXRhLA0KPiAgIAkJICAgICAgQU1ER1BVX0dFTV9DUkVBVEVfQ1BVX0dUVF9VU1dDIHwNCj4gICAJ CSAgICAgIEFNREdQVV9HRU1fQ1JFQVRFX1ZSQU1fQ0xFQVJFRCB8DQo+ICAgCQkgICAgICBBTURH UFVfR0VNX0NSRUFURV9WTV9BTFdBWVNfVkFMSUQgfA0KPiAtCQkgICAgICBBTURHUFVfR0VNX0NS RUFURV9FWFBMSUNJVF9TWU5DKSkNCj4gKwkJICAgICAgQU1ER1BVX0dFTV9DUkVBVEVfRVhQTElD SVRfU1lOQyB8DQo+ICsJCSAgICAgIEFNREdQVV9HRU1fQ1JFQVRFX0VOQ1JZUFRFRCkpDQo+ICAg DQo+ICAgCQlyZXR1cm4gLUVJTlZBTDsNCj4gICANCj4gQEAgLTIzMCw2ICsyMzEsMTEgQEAgaW50 IGFtZGdwdV9nZW1fY3JlYXRlX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRh dGEsDQo+ICAgCWlmIChhcmdzLT5pbi5kb21haW5zICYgfkFNREdQVV9HRU1fRE9NQUlOX01BU0sp DQo+ICAgCQlyZXR1cm4gLUVJTlZBTDsNCj4gICANCj4gKwlpZiAoIWFkZXYtPnRtei5lbmFibGVk ICYmIChmbGFncyAmIEFNREdQVV9HRU1fQ1JFQVRFX0VOQ1JZUFRFRCkpIHsNCj4gKwkJRFJNX0VS Uk9SKCJDYW5ub3QgYWxsb2NhdGUgc2VjdXJlIGJ1ZmZlciB3aGlsZSB0bXogaXMgZGlzYWJsZWRc biIpOw0KPiArCQlyZXR1cm4gLUVJTlZBTDsNCj4gKwl9DQo+ICsNCj4gICAJLyogY3JlYXRlIGEg Z2VtIG9iamVjdCB0byBjb250YWluIHRoaXMgb2JqZWN0IGluICovDQo+ICAgCWlmIChhcmdzLT5p bi5kb21haW5zICYgKEFNREdQVV9HRU1fRE9NQUlOX0dEUyB8DQo+ICAgCSAgICBBTURHUFVfR0VN X0RPTUFJTl9HV1MgfCBBTURHUFVfR0VNX0RPTUFJTl9PQSkpIHsNCj4gQEAgLTI1MSw2ICsyNTcs MTAgQEAgaW50IGFtZGdwdV9nZW1fY3JlYXRlX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsDQo+ICAgCQlyZXN2ID0gdm0tPnJvb3QuYmFzZS5iby0+dGJvLnJlc3Y7DQo+ ICAgCX0NCj4gICANCj4gKwlpZiAoZmxhZ3MgJiBBTURHUFVfR0VNX0NSRUFURV9FTkNSWVBURUQp IHsNCj4gKwkJLyogWFhYOiBwYWQgb3V0IGFsaWdubWVudCB0byBtZWV0IFRNWiByZXF1aXJlbWVu dHMgKi8NCj4gKwl9DQo+ICsNCj4gICAJciA9IGFtZGdwdV9nZW1fb2JqZWN0X2NyZWF0ZShhZGV2 LCBzaXplLCBhcmdzLT5pbi5hbGlnbm1lbnQsDQo+ICAgCQkJCSAgICAgKHUzMikoMHhmZmZmZmZm ZiAmIGFyZ3MtPmluLmRvbWFpbnMpLA0KPiAgIAkJCQkgICAgIGZsYWdzLCB0dG1fYm9fdHlwZV9k ZXZpY2UsIHJlc3YsICZnb2JqKTsNCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9vYmplY3QuaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV9vYmplY3QuaA0KPiBpbmRleCA1YTNjMTc3Li4yODZlMmUyIDEwMDY0NA0KPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmgNCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5oDQo+IEBAIC0yMjQsNiArMjI0LDE2IEBA IHN0YXRpYyBpbmxpbmUgYm9vbCBhbWRncHVfYm9fZXhwbGljaXRfc3luYyhzdHJ1Y3QgYW1kZ3B1 X2JvICpibykNCj4gICAJcmV0dXJuIGJvLT5mbGFncyAmIEFNREdQVV9HRU1fQ1JFQVRFX0VYUExJ Q0lUX1NZTkM7DQo+ICAgfQ0KPiAgIA0KPiArLyoqDQo+ICsgKiBhbWRncHVfYm9fZW5jcnlwdGVk IC0gcmV0dXJuIHdoZXRoZXIgdGhlIGJvIGlzIGVuY3J5cHRlZA0KPiArICovDQo+ICtzdGF0aWMg aW5saW5lIGJvb2wgYW1kZ3B1X2JvX2VuY3J5cHRlZChzdHJ1Y3QgYW1kZ3B1X2JvICpibykNCj4g K3sNCj4gKwlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiA9IGFtZGdwdV90dG1fYWRldihiby0+ dGJvLmJkZXYpOw0KPiArDQo+ICsJcmV0dXJuIGFkZXYtPnRtei5lbmFibGVkICYmIChiby0+Zmxh Z3MgJiBBTURHUFVfR0VNX0NSRUFURV9FTkNSWVBURUQpOw0KDQpDaGVja2luZyB0aGUgYWRldi0+ dG16LmVuYWJsZWQgZmxhZ3Mgc2hvdWxkIGJlIGRyb3BwZWQgaGVyZS4NCg0KPiArfQ0KPiArDQo+ ICAgYm9vbCBhbWRncHVfYm9faXNfYW1kZ3B1X2JvKHN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAq Ym8pOw0KPiAgIHZvaWQgYW1kZ3B1X2JvX3BsYWNlbWVudF9mcm9tX2RvbWFpbihzdHJ1Y3QgYW1k Z3B1X2JvICphYm8sIHUzMiBkb21haW4pOw0KPiAgIA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X3R0bS5jDQo+IGluZGV4IDM2NjM2NTUuLjhmMDBiYjIgMTAwNjQ0DQo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYw0KPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMNCj4gQEAgLTE0MzQsNiArMTQzNCw4IEBA IGJvb2wgYW1kZ3B1X3R0bV90dF9pc19yZWFkb25seShzdHJ1Y3QgdHRtX3R0ICp0dG0pDQo+ICAg dWludDY0X3QgYW1kZ3B1X3R0bV90dF9wZGVfZmxhZ3Moc3RydWN0IHR0bV90dCAqdHRtLCBzdHJ1 Y3QgdHRtX21lbV9yZWcgKm1lbSkNCj4gICB7DQo+ICAgCXVpbnQ2NF90IGZsYWdzID0gMDsNCj4g KwlzdHJ1Y3QgdHRtX2J1ZmZlcl9vYmplY3QgKnRibyA9IHR0bV9tZW1fcmVnX3RvX2JvKG1lbSk7 DQo+ICsJc3RydWN0IGFtZGdwdV9ibyAqYWJvID0gdHRtX3RvX2FtZGdwdV9ibyh0Ym8pOw0KDQpU aGF0J3MgYSBjbGVhciBOQUsuIFRoZSBmdW5jdGlvbiBpcyBub3QgbmVjZXNzYXJpbHkgY2FsbGVk IHdpdGggDQomYm8tPm1lbSwgd2hpY2ggaXMgYWxzbyB0aGUgcmVhc29uIHdoeSB0aGlzIGZ1bmN0 aW9uIGRvZXNuJ3QgZ2V0cyB0aGUgQk8gDQphcyBwYXJhbWV0ZXIuDQoNCkNocmlzdGlhbi4NCg0K PiAgIA0KPiAgIAlpZiAobWVtICYmIG1lbS0+bWVtX3R5cGUgIT0gVFRNX1BMX1NZU1RFTSkNCj4g ICAJCWZsYWdzIHw9IEFNREdQVV9QVEVfVkFMSUQ7DQo+IEBAIC0xNDQ0LDYgKzE0NDYsOSBAQCB1 aW50NjRfdCBhbWRncHVfdHRtX3R0X3BkZV9mbGFncyhzdHJ1Y3QgdHRtX3R0ICp0dG0sIHN0cnVj dCB0dG1fbWVtX3JlZyAqbWVtKQ0KPiAgIAkJaWYgKHR0bS0+Y2FjaGluZ19zdGF0ZSA9PSB0dF9j YWNoZWQpDQo+ICAgCQkJZmxhZ3MgfD0gQU1ER1BVX1BURV9TTk9PUEVEOw0KPiAgIAl9DQo+ICsJ aWYgKGFtZGdwdV9ib19lbmNyeXB0ZWQoYWJvKSkgew0KPiArCQlmbGFncyB8PSBBTURHUFVfUFRF X1RNWjsNCj4gKwl9DQo+ICAgDQo+ICAgCXJldHVybiBmbGFnczsNCj4gICB9DQoNCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBs aXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==