From: Maarten Lankhorst Subject: Re: [PATCH] drm/i915: Fix plane allocation/free functions Date: Thu, 15 Nov 2018 12:23:13 +0100 Message-ID: <571f25b5-5489-589b-e273-9fdbc520785a@linux.intel.com> References: <20181113092804.13304-1-maarten.lankhorst@linux.intel.com> <20181113140252.GX9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 601E86E013 for ; Thu, 15 Nov 2018 11:23:15 +0000 (UTC) In-Reply-To: <20181113140252.GX9144@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTMtMTEtMTggb20gMTU6MDIgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVHVlLCBO b3YgMTMsIDIwMTggYXQgMTA6Mjg6MDRBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IFVzZSBpbnRlbF9wbGFuZV9kZXN0cm95X3N0YXRlIGluIGludGVsX3BsYW5lX2ZyZWUgdG8g ZnJlZSB0aGUgc3RhdGUuCj4gTm90IGVudGlyZWx5IG5lY2Vzc2FyeSBzaW5jZSB3ZSBoYXZlIG5v dGhpbmcgaW4gdGhlIHN0YXRlIGF0IHRoYXQgbW9tZW50Cj4gdGhhdCB3b3VsZCByZXF1aXJlZCB0 byBiZSBmcmVlZCBzZXBhcmF0ZWx5LiBCdXQgc2VlbXMgbW9yZSBmdXR1cmUgcHJvb2YKPiBhbnl3 YXkuCj4KPj4gQWxzbyBmaXggaW50ZWxfcGxhbmVfYWxsb2MoKSB0byB1c2UgX19kcm1fYXRvbWlj X2hlbHBlcl9wbGFuZV9yZXNldCgpLAo+PiB0byBnZXQgc2FuZSBkZWZhdWx0cyBmcm9tIHRoZSBh dG9taWMgY29yZS4KPiBDb3VsZCBtZW50aW9uIHRoZSBjb25zdGFudCBhbHBoYSBzcGVjaWZpY2Fs bHkgaGVyZSBzaW5jZSBJIHRoaW5rIGl0Cj4gd2FzIHRoZSBvbmx5IHRoaW5nIHdlIGRpZG4ndCBz ZXQgb3Vyc2VsdmVzLgo+Cj4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4KPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4gUmVwb3J0ZWQtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+PiBGaXhlczogYjIw ODE1MjU1NjkzICgiZHJtL2k5MTU6IEFkZCBwbGFuZSBhbHBoYSBibGVuZGluZyBzdXBwb3J0LCB2 Mi4iKQo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5j IHwgNDAgKysrKysrKysrKysrLS0tLS0tLS0tLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rydi5oICAgICAgICAgIHwgIDUgKystCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9zcHJpdGUuYyAgICAgICB8IDI5IC0tLS0tLS0tLS0tLS0tLS0KPj4gIDMgZmlsZXMgY2hhbmdl ZCwgMjMgaW5zZXJ0aW9ucygrKSwgNTEgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4+IGluZGV4IDdkMzY4NTA3NTIwMS4uOTA1Zjhl ZjNiYTRmIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNf cGxhbmUuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUu Ywo+PiBAQCAtMzYsMjkgKzM2LDMxIEBACj4+ICAjaW5jbHVkZSA8ZHJtL2RybV9wbGFuZV9oZWxw ZXIuaD4KPj4gICNpbmNsdWRlICJpbnRlbF9kcnYuaCIKPj4gIAo+PiAtLyoqCj4+IC0gKiBpbnRl bF9jcmVhdGVfcGxhbmVfc3RhdGUgLSBjcmVhdGUgcGxhbmUgc3RhdGUgb2JqZWN0Cj4+IC0gKiBA cGxhbmU6IGRybSBwbGFuZQo+PiAtICoKPj4gLSAqIEFsbG9jYXRlcyBhIGZyZXNoIHBsYW5lIHN0 YXRlIGZvciB0aGUgZ2l2ZW4gcGxhbmUgYW5kIHNldHMgc29tZSBvZgo+PiAtICogdGhlIHN0YXRl IHZhbHVlcyB0byBzZW5zaWJsZSBpbml0aWFsIHZhbHVlcy4KPj4gLSAqCj4+IC0gKiBSZXR1cm5z OiBBIG5ld2x5IGFsbG9jYXRlZCBwbGFuZSBzdGF0ZSwgb3IgTlVMTCBvbiBmYWlsdXJlCj4+IC0g Ki8KPj4gLXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqCj4+IC1pbnRlbF9jcmVhdGVfcGxhbmVf c3RhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4+ICtzdHJ1Y3QgaW50ZWxfcGxhbmUgKmlu dGVsX3BsYW5lX2FsbG9jKHZvaWQpCj4+ICB7Cj4+IC0Jc3RydWN0IGludGVsX3BsYW5lX3N0YXRl ICpzdGF0ZTsKPj4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlOwo+PiAr CXN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmU7Cj4+ICAKPj4gLQlzdGF0ZSA9IGt6YWxsb2Moc2l6 ZW9mKCpzdGF0ZSksIEdGUF9LRVJORUwpOwo+PiAtCWlmICghc3RhdGUpCj4+IC0JCXJldHVybiBO VUxMOwo+PiArCXBsYW5lID0ga3phbGxvYyhzaXplb2YoKnBsYW5lKSwgR0ZQX0tFUk5FTCk7Cj4+ ICsJaWYgKCFwbGFuZSkKPj4gKwkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4+ICAKPj4gLQlz dGF0ZS0+YmFzZS5wbGFuZSA9IHBsYW5lOwo+PiAtCXN0YXRlLT5iYXNlLnJvdGF0aW9uID0gRFJN X01PREVfUk9UQVRFXzA7Cj4+IC0Jc3RhdGUtPnNjYWxlcl9pZCA9IC0xOwo+PiArCXBsYW5lX3N0 YXRlID0ga3phbGxvYyhzaXplb2YoKnBsYW5lX3N0YXRlKSwgR0ZQX0tFUk5FTCk7Cj4+ICsJaWYg KCFwbGFuZV9zdGF0ZSkgewo+PiArCQlrZnJlZShwbGFuZSk7Cj4+ICsJCXJldHVybiBFUlJfUFRS KC1FTk9NRU0pOwo+PiArCX0KPj4gIAo+PiAtCXJldHVybiBzdGF0ZTsKPj4gKwlfX2RybV9hdG9t aWNfaGVscGVyX3BsYW5lX3Jlc2V0KCZwbGFuZS0+YmFzZSwgJnBsYW5lX3N0YXRlLT5iYXNlKTsK Pj4gKwlwbGFuZV9zdGF0ZS0+c2NhbGVyX2lkID0gLTE7Cj4+ICsKPj4gKwlyZXR1cm4gcGxhbmU7 Cj4+ICt9Cj4+ICsKPj4gK3ZvaWQgaW50ZWxfcGxhbmVfZnJlZShzdHJ1Y3QgaW50ZWxfcGxhbmUg KnBsYW5lKQo+PiArewo+PiArCWludGVsX3BsYW5lX2Rlc3Ryb3lfc3RhdGUoJnBsYW5lLT5iYXNl LCBwbGFuZS0+YmFzZS5zdGF0ZSk7Cj4+ICsJa2ZyZWUocGxhbmUpOwo+PiAgfQo+PiAgCj4+ICAv KioKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPj4gaW5kZXggMTBhNWRmNjZlNGViLi4yYTg5 N2UxNzRlZDUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4+IEBAIC0yMjE5LDgg KzIyMTksNiBAQCB2b2lkIGludGVsX3BpcGVfdXBkYXRlX2VuZChzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqbmV3X2NydGNfc3RhdGUpOwo+PiAgaW50IGludGVsX3BsYW5lX2NoZWNrX3N0cmlkZShj b25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKTsKPj4gIGludCBpbnRl bF9wbGFuZV9jaGVja19zcmNfY29vcmRpbmF0ZXMoc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpw bGFuZV9zdGF0ZSk7Cj4+ICBpbnQgY2h2X3BsYW5lX2NoZWNrX3JvdGF0aW9uKGNvbnN0IHN0cnVj dCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpOwo+PiAtc3RydWN0IGludGVsX3BsYW5l ICppbnRlbF9wbGFuZV9hbGxvYyh2b2lkKTsKPj4gLXZvaWQgaW50ZWxfcGxhbmVfZnJlZShzdHJ1 Y3QgaW50ZWxfcGxhbmUgKnBsYW5lKTsKPj4gIHN0cnVjdCBpbnRlbF9wbGFuZSAqCj4+ICBza2xf dW5pdmVyc2FsX3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4+ICAJCQkgICBlbnVtIHBpcGUgcGlwZSwgZW51bSBwbGFuZV9pZCBwbGFuZV9pZCk7Cj4+IEBA IC0yMjgyLDcgKzIyODAsOCBAQCBpbnQgaW50ZWxfYXRvbWljX3NldHVwX3NjYWxlcnMoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCQkJICAgICAgIHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPj4gIAo+PiAgLyogaW50ZWxfYXRvbWljX3BsYW5lLmMg Ki8KPj4gLXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqaW50ZWxfY3JlYXRlX3BsYW5lX3N0YXRl KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lKTsKPj4gK3N0cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxf cGxhbmVfYWxsb2Modm9pZCk7Cj4+ICt2b2lkIGludGVsX3BsYW5lX2ZyZWUoc3RydWN0IGludGVs X3BsYW5lICpwbGFuZSk7Cj4+ICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICppbnRlbF9wbGFuZV9k dXBsaWNhdGVfc3RhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpOwo+PiAgdm9pZCBpbnRlbF9w bGFuZV9kZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+PiAgCQkJICAgICAg IHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c3ByaXRlLmMKPj4gaW5kZXggZmFjZjdjYThmMTRmLi43ZGI2ZDA2MGVmZTcgMTAwNjQ0Cj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4+IEBAIC0xOTgyLDM1ICsxOTgyLDYgQEAgc3Rh dGljIGJvb2wgc2tsX3BsYW5lX2hhc19jY3Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+PiAgCQkgcGxhbmVfaWQgPT0gUExBTkVfU1BSSVRFMCk7Cj4+ICB9Cj4+ICAKPj4gLXN0 cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmVfYWxsb2Modm9pZCkKPj4gLXsKPj4gLQlzdHJ1 Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlOwo+PiAtCXN0cnVjdCBpbnRlbF9wbGFu ZSAqcGxhbmU7Cj4+IC0KPj4gLQlwbGFuZSA9IGt6YWxsb2Moc2l6ZW9mKCpwbGFuZSksIEdGUF9L RVJORUwpOwo+PiAtCWlmICghcGxhbmUpCj4+IC0JCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOwo+ PiAtCj4+IC0JcGxhbmVfc3RhdGUgPSBpbnRlbF9jcmVhdGVfcGxhbmVfc3RhdGUoJnBsYW5lLT5i YXNlKTsKPj4gLQlpZiAoIXBsYW5lX3N0YXRlKSB7Cj4+IC0JCWtmcmVlKHBsYW5lKTsKPj4gLQkJ cmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4+IC0JfQo+PiAtCj4+IC0JcGxhbmUtPmJhc2Uuc3Rh dGUgPSAmcGxhbmVfc3RhdGUtPmJhc2U7Cj4+IC0KPj4gLQlyZXR1cm4gcGxhbmU7Cj4+IC19Cj4+ IC0KPj4gLXZvaWQgaW50ZWxfcGxhbmVfZnJlZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lKQo+ PiAtewo+PiAtCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPQo+PiAtCQl0 b19pbnRlbF9wbGFuZV9zdGF0ZShwbGFuZS0+YmFzZS5zdGF0ZSk7Cj4+IC0KPj4gLQlrZnJlZShw bGFuZV9zdGF0ZSk7Cj4+IC0Ja2ZyZWUocGxhbmUpOwo+PiAtfQo+PiAtCj4+ICBzdHJ1Y3QgaW50 ZWxfcGxhbmUgKgo+PiAgc2tsX3VuaXZlcnNhbF9wbGFuZV9jcmVhdGUoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCQkJICAgZW51bSBwaXBlIHBpcGUsIGVudW0gcGxhbmVf aWQgcGxhbmVfaWQpCj4+IC0tIAo+PiAyLjE5LjEKClRoYW5rcywgcHVzaGVkCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK