References: <1464694920-3624-1-git-send-email-pinkel@...277...> From: Steffan Karger Message-ID: <574D81DE.1040204@...1435...> Date: Tue, 31 May 2016 14:21:50 +0200 MIME-Version: 1.0 In-Reply-To: <1464694920-3624-1-git-send-email-pinkel@...277...> Subject: Re: [Openvpn-devel] [PATCH master] Plug memory leak in mbedTLS backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net On 31-05-16 13:42, Ivo Manca wrote: > Signed-off-by: Ivo Manca > --- > src/openvpn/ssl_verify_mbedtls.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/openvpn/ssl_verify_mbedtls.c b/src/openvpn/ssl_verify_mbedtls.c > index 9c4b51a..522ff68 100644 > --- a/src/openvpn/ssl_verify_mbedtls.c > +++ b/src/openvpn/ssl_verify_mbedtls.c > @@ -162,7 +162,7 @@ backend_x509_get_serial (mbedtls_x509_crt *cert, struct gc_arena *gc) > cert->serial.len))) > { > msg(M_WARN, "Failed to retrieve serial from certificate."); > - return NULL; > + goto end; > } > > /* Determine decimal representation length, allocate buffer */ > @@ -173,9 +173,12 @@ backend_x509_get_serial (mbedtls_x509_crt *cert, struct gc_arena *gc) > if (!mbed_ok(mbedtls_mpi_write_string(&serial_mpi, 10, buf, buflen, &buflen))) > { > msg(M_WARN, "Failed to write serial to string."); > - return NULL; > + buf = NULL; > + goto end; > } > > +end: > + mbedtls_mpi_free(&serial_mpi); > return buf; > } ACK - *but* Ivo did this work for us (Fox-IT), so some external eyes before applying are welcome. -Steffan