References: <1464668569-6480-1-git-send-email-selva.nair@...277...> <61d8d41f-4c77-5235-a202-642983d494a3@...1227...> From: David Sommerseth Message-ID: <574DAECE.8000202@...2080...> Date: Tue, 31 May 2016 17:33:34 +0200 MIME-Version: 1.0 In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] Add an option to filter options received from server Reply-To: openvpn-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Selva Nair , Arne Schwabe Cc: "openvpn-devel@lists.sourceforge.net" On 31/05/16 17:24, Selva Nair wrote: > Hi, > > On Tue, May 31, 2016 at 4:37 AM, Arne Schwabe > wrote: > > Am 31.05.16 um 06:22 schrieb Selva Nair: > > +#define PULL_FILTER_LIST_SIZE 64 > We already have dymanic lists, used for ignore-unknown-options and > --route, any reason not to use them here? > > > I just thought 64 is good enough and kept it simple like the > connection_list. > > Will consider making it dynamic if we go for a v2. I think a fixed list of 64 slots is more than good enough in this case. I even considered suggesting 32 slots, but 64 is reasonable as a maximum currently. An average openvpn config is probably roughly 10-15 lines all in all (not considering inline files). If someone pushes more than 50-60 options, then something more funky is probably going on as well. *If* this limit gets too annoying, then I we can reconsider using a dynamic list. -- kind regards, David Sommerseth