Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D24FC3DA64 for ; Mon, 29 Jul 2024 02:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=itv3XoLvso316kRTMjrdoqzjhbg2RxuKaFlzy0K52Ng=; b=o29yOy/3jfL40wXNeT1OC5BluP NJD819VLZ/eUhd3y3/Yj7j5t4QF+QDuZtVtm0hJuqaUMxG2wxkZtB3R7q6vWxzBiGllvXckT+eOTI xLF+COyfSC0WWR806ggq3GyH25cspWubOv+ith4MUN4wmVaP2DzMyl5q60+NAlz5WQmsKsoICKJJ3 iUpJ3beuJxWkE+4n9whmc5M/Y6fGkOcAtybEp8OgznQF91oVcY4vTgnxyeIXTZauUzi4zr94DtGZc gFwz2rkGDcEwSbI100hYy6lCL0qetOCJ3iQZQDXwAPVrEBhzMyq64e6pyzb888PMlHAU0LtoZst7/ Dl8/ODBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYGHR-00000009lf1-3w8I; Mon, 29 Jul 2024 02:38:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYGH1-00000009lZh-2DLD for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2024 02:38:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D498FEC; Sun, 28 Jul 2024 19:38:26 -0700 (PDT) Received: from [10.162.41.10] (a077893.blr.arm.com [10.162.41.10]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BECAF3F64C; Sun, 28 Jul 2024 19:37:58 -0700 (PDT) Message-ID: <575911ec-aa33-4c5b-877b-8a2bdac08844@arm.com> Date: Mon, 29 Jul 2024 08:07:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v4] arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for compressed kernel image To: Will Deacon , Sedat Dilek Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Torvalds References: <20240726201014.18484-1-sedat.dilek@gmail.com> <20240727195752.GA30914@willie-the-truck> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240727195752.GA30914@willie-the-truck> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240728_193807_652504_E97C3CB4 X-CRM114-Status: GOOD ( 13.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/28/24 01:27, Will Deacon wrote: > On Fri, Jul 26, 2024 at 10:09:30PM +0200, Sedat Dilek wrote: >> The COMPRESSED_INSTALL kconfig does not sound very meaningful. >> >> Rename from COMPRESSED_INSTALL kconfig to KERNEL_IMAGE_COMPRESSED_INSTALL. >> >> Fixes: commit 4c7be57f2 ("arm64: allow installing compressed image by default") "Fixes:" tag should only be used for patches that fix real functional problems in the code. >> Signed-off-by: Sedat Dilek >> --- >> arch/arm64/Kconfig | 6 +++--- >> arch/arm64/Makefile | 6 +++--- >> 2 files changed, 6 insertions(+), 6 deletions(-) > > Hmm, I'm not sure I see the point of this tbh. I think the code is fine > as it is. Agreed, only thing this patch does is to add "kernel image" prefix in the config as well in related descriptions which in itself does not make this any better. As Will mentioned, it is better to leave this unchanged.