From: "cron2 (Code Review)" Date: Sun, 5 Apr 2026 10:19:00 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <576115c749be1b36f1fbaf376a8cf36bdd8783db-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="FY4hOcz9VSg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: openvpnmsica: Fix setting of iTicks in schedule_adapter_delete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --FY4hOcz9VSg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/16= 08?usp=3Demail ) Change subject: openvpnmsica: Fix setting of iTicks in schedule_adapter_del= ete ...................................................................... openvpnmsica: Fix setting of iTicks in schedule_adapter_delete Increase the integer, not the pointer. Found by cppcheck. Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1608 Message-Id: <20260404203525.30790-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 476.html Signed-off-by: Gert Doering --- M src/openvpnmsica/openvpnmsica.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsic= a.c index a145b64..fdb610c 100644 --- a/src/openvpnmsica/openvpnmsica.c +++ b/src/openvpnmsica/openvpnmsica.c @@ -613,7 +613,7 @@ msica_arg_seq_add_tail(seq, szArgument); } - iTicks +=3D MSICA_ADAPTER_TICK_SIZE; + *iTicks +=3D MSICA_ADAPTER_TICK_SIZE; break; /* Adapter names are unique. There should be no other a= dapter with this name. */ } } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1608?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb Gerrit-Change-Number: 1608 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --FY4hOcz9VSg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

openvpnmsica: Fix setting of iTicks in schedule_=
adapter_delete

Increase the integer, not the pointer.

Found b= y cppcheck.

Change-Id: I4d6501ddfb321f57a76841f29ff92c5a412908bb
= Signed-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert= Doering <gert@...1296...>
Gerrit URL: https://gerrit.openvpn.net/= c/openvpn/+/1608
Message-Id: <20260404203525.30790-1-gert@...1296...&= gt;
URL: https://www.mail-archive.com/openvpn-devel@...475...= t/msg36476.html
Signed-off-by: Gert Doering <gert@...1296...>
-= --
M src/openvpnmsica/openvpnmsica.c
1 file changed, 1 insertion(+), = 1 deletion(-)

diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnm=
sica.c
index a145b64..fdb610c 100644
--- a/= src/openvpnmsica/openvpnmsica.c
+++ b/src/openvpnmsica/open= vpnmsica.c
@@ -613,7 +613,7 @@
= msica_arg_seq_add_tail(seq, szArgument);
= }

- = iTicks +=3D MSICA_ADAPTER_TICK_SIZE;
+ *iTicks +=3D MSICA_ADAPTER_TICK_SIZE= ;
break; /* Adapter names are unique. There sh= ould be no other adapter with this name. */
}
}

To view, visit change 1608. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d6501ddfb321f57a76841f29ff= 92c5a412908bb
Gerrit-Change-Number: 1608
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --FY4hOcz9VSg=--