References: <1524623120-23498-1-git-send-email-selva.nair@...277...> <712cbadd-34a2-b5b2-345e-9c19d237285d@...515...> From: =?UTF-8?Q?Samuli_Sepp=c3=a4nen?= Message-ID: <5762a312-2a09-4411-3951-bf82dc1033af@...515...> Date: Wed, 25 Apr 2018 18:38:09 +0300 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH tap-windows6] Have the driver version display as major.minor.revision.build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: openvpn-devel Il 25/04/2018 15:42, Selva Nair ha scritto: > Hi, > > On Wed, Apr 25, 2018 at 3:04 AM, Samuli Seppänen wrote: >> Feature-ACK, but I have not tested this yet. I think we should increment >> version to 9.22.2 (a.k.a. 9,22,2,601) though. The current release is 9.22.1. > > Treating this like any other patch, I think version bump should not be > a part of it, but done only at the point of release as usual. So let's keep > the purpose here to just change how version is displayed. > > But I did change the date by mistake (left behind from testing) -- will send > a v2 which keeps the version number and date as is (and update the PR as > well). > > That said, when a signed test version is made, please bump the version > and date for testing that it does get recognized as the latest by Windows. > I could not properly test that due to lack of signature > > Selva > Sounds reasonable. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock