From: "stipa (Code Review)" Date: Wed, 22 Jan 2025 09:17:28 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <5772b46f2e15d9f27a15d3399d8682aaef548b80-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="XI2HkPT7e4o="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added update_option() function. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: plaisthos , flichtenheld , openvpn-devel --XI2HkPT7e4o= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, mrbff, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/810?usp=3Demail ) Change subject: PUSH_UPDATE: Added update_option() function. ...................................................................... Patch Set 12: Code-Review+2 (1 comment) Patchset: PS12: I tested those 3 patches together - looks good. I was able to replace route= s, remove routes, change IP address and revert it back. It would me nice to make it work also for dco-win (which is a default drive= r) - at the moment we don't support reopening dco device - but this could b= e done later. --=20 To view, visit http://gerrit.openvpn.net/c/openvpn/+/810?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia45c99e6df7b3ad24020c10b8a9b3577984ecdc2 Gerrit-Change-Number: 810 Gerrit-PatchSet: 12 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: mrbff Gerrit-Comment-Date: Wed, 22 Jan 2025 09:17:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --XI2HkPT7e4o= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, mrbff, plaisthos. <= /p>

Patch set 12:Code-Review +2

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #12:

      I tested those 3 patches together - looks go= od. I was able to replace routes, remove routes, change IP address and reve= rt it back.

      = It would me nice to make it work also for dco-win (which is a default drive= r) - at the moment we don't support reopening dco device - but this cou= ld be done later.

To view, visit change 810. To unsubs= cribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia45c99e6df7b3ad24020c10b8a9= b3577984ecdc2
Gerrit-Change-Number: 810
Gerrit-PatchSet: 12
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: mrbff <marco@...2726...&g= t;
Gerrit-Comment-Date: Wed, 22 Jan 2025 09:17:28= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--XI2HkPT7e4o=--