From: David Daney Subject: Re: [PATCH V8 2/2] mmc: OCTEON: Add host driver for OCTEON MMC controller. Date: Tue, 23 Aug 2016 12:59:35 -0700 Message-ID: <57BCAB27.8060502@caviumnetworks.com> References: <57853474.9050108@cavium.com> <57BC8ACA.1040506@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Ulf Hansson Cc: "Steven J. Hill" , linux-mmc , "devicetree@vger.kernel.org" , linux-mips@linux-mips.org, Rob Herring , Mark Rutland , Ralf Baechle List-Id: devicetree@vger.kernel.org On 08/23/2016 12:46 PM, Ulf Hansson wrote: > On 23 August 2016 at 19:41, David Daney wrote: >> On 08/23/2016 07:53 AM, Ulf Hansson wrote: >>> >>> On 12 July 2016 at 20:18, Steven J. Hill wrote: >> >> [...] >> >>>> +#include >>>> +#include >>> >>> >> >> OK, we will duplicate any needed definitions from octeon.h into the driver >> source file. > > Why can't you share it via a platfrom data header at > include/linux/platform_data/* ? > It isn't "platform_data", it is register layout definitions (thousands of lines of them), so I don't think it it appropriate to place in include/linux. I think the cleanest approach is to put the register definitions in the driver file, which is the only user, and delete the definition header files in arch/mips/include/... David.