From: "plaisthos (Code Review)" Date: Tue, 14 Jan 2025 09:43:55 +0000 References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <57a9ad9e2c345ece460491326b4df9285578df19-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="DbkcM37WuPU="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Improve peer fingerpint documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --DbkcM37WuPU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/859?usp=3Demail to review the following change. Change subject: Improve peer fingerpint documentation ...................................................................... Improve peer fingerpint documentation - fix typo in peer-fingerprint - use ec_paramgen_curve instead of requiring a subshell Note: we still use -nodes instead of -noenc as it is more compatible. closes: issue #666 Change-Id: I9a12a0c127908af9f09d88fb3a493df3763d0cc5 Signed-off-by: Arne Schwabe --- M doc/man-sections/example-fingerprint.rst 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/59/859/1 diff --git a/doc/man-sections/example-fingerprint.rst b/doc/man-sections/ex= ample-fingerprint.rst index 7cdda19..31ca0c1 100644 --- a/doc/man-sections/example-fingerprint.rst +++ b/doc/man-sections/example-fingerprint.rst @@ -18,7 +18,7 @@ 2. Generate a self-signed certificate for the server: :: - openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -keyou= t server.key -out server.crt -nodes -sha256 -days 3650 -subj '/CN=3Dserver' + openssl req -x509 -newkey ec -pkeyopt ec_paramgen_curve:secp384r1 -key= out server.key -out server.crt -nodes -sha256 -days 3650 -subj '/CN=3Dserve= r' 3. Generate SHA256 fingerprint of the server certificate @@ -28,7 +28,7 @@ openssl x509 -fingerprint -sha256 -in server.crt -noout - This output something similar to: + This outputs something similar to: :: SHA256 Fingerprint=3D00:11:22:33:44:55:66:77:88:99:aa:bb:cc:dd:ee:ff:= 00:11:22:33:44:55:66:77:88:99:aa:bb:cc:dd:ee:ff @@ -64,6 +64,12 @@ # Ping every 60s, restart if no data received for 5 minutes keepalive 60 300 + # Uncomment the line below if you want to have persistent IP addresses + # ifconfig-pool-persist /etc/openvpn/server/ipp.txt + + # Uncomment the line below to push a DNS server to clients + # push "dhcp-option DNS 1.1.1.1" + 5. Add at least one client as described in the client section. 6. Start the server. @@ -85,7 +91,7 @@ different name for each client. :: - openssl req -x509 -newkey ec:<(openssl ecparam -name secp384r1) -nod= es -sha256 -days 3650 -subj '/CN=3Dalice' + openssl req -x509 -newkey ec -pkeyopt ec_paramgen_curve:secp384r1 -k= eyout - -nodes -sha256 -days 3650 -subj '/CN=3Dalice' This generate a certificate and a key for the client. The output of the= command will look something like this: @@ -162,7 +168,7 @@ ff:ee:dd:cc:bb:aa:99:88:77:66:55:44:33:22:11:00:ff:ee:dd:cc:bb:aa:99= :88:77:66:55:44:33:22:11:00 99:88:77:66:55:44:33:22:11:00:ff:ee:dd:cc:bb:aa:99:88:77:66:55:44:33= :22:11:00:88:77:66:55:44:33 - + 6. (optional) if the client is an older client that does not support the :code:`peer-fingerprint` (e.g. OpenVPN 2.5 and older, OpenVPN Connect 3= .3 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/859?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9a12a0c127908af9f09d88fb3a493df3763d0cc5 Gerrit-Change-Number: 859 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --DbkcM37WuPU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

plaisthos would like flichtenheld to review this change.

Vi= ew Change

Improve peer fingerpint documentation

- fix typo in pe= er-fingerprint
- use ec_paramgen_curve instead of requiring a subshell
Note: we still use -nodes instead of -noenc as it is more compatible.=

closes: issue #666

Change-Id: I9a12a0c127908af9f09d88fb3a493= df3763d0cc5
Signed-off-by: Arne Schwabe <arne@...1227...>
---M doc/man-sections/example-fingerprint.rst
1 file changed, 10 insertio= ns(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/ope=
nvpn refs/changes/59/859/1
diff --git a/doc/man-sections/example-fi=
ngerprint.rst b/doc/man-sections/example-fingerprint.rst
in= dex 7cdda19..31ca0c1 100644
--- a/doc/man-sections/example-= fingerprint.rst
+++ b/doc/man-sections/example-fingerprint.= rst
@@ -18,7 +18,7 @@
2. Generate a self-s= igned certificate for the server:
::
<= /span>
- openssl req -x509 = -newkey ec:<(openssl ecparam -name secp384r1) -keyout server.key -out se= rver.crt -nodes -sha256 -days 3650 -subj '/CN=3Dserver'
<= span style=3D"color: hsl(120, 100%, 40%);">+ openssl req -x509 -newkey e= c -pkeyopt ec_paramgen_curve:secp384r1 -keyout server.key -out server.crt -= nodes -sha256 -days 3650 -subj '/CN=3Dserver'


3. Generate SHA256 fingerprint of the server certificate

@@ -28,7 +28,7 @@
openssl x509 -fingerprint -sha256 -in server.crt -noout<= br>
- This out= put something similar to:
+ This outputs something similar to:
::
SHA256 Fingerprint=3D00:11:22:33:44:55:66:7= 7:88:99:aa:bb:cc:dd:ee:ff:00:11:22:33:44:55:66:77:88:99:aa:bb:cc:dd:ee:ff
@@ -64,6 +64,12 @@
# Ping every 60s, re= start if no data received for 5 minutes
keepalive 60 3= 00

= + # Uncomment the line below if you want to have persistent IP addresses=
+ # ifconfig-pool= -persist /etc/openvpn/server/ipp.txt
+
+ = # Uncomment the line below to push a DNS server to clients
+ # push "dhcp-option DNS = 1.1.1.1"

+
5. Add at least one client as described in the client section.<= /span>

6. Start the server.
@@ = -85,7 +91,7 @@
different name for each client. ::

- openssl req -x509 -newkey ec:<(openssl ecparam -name se= cp384r1) -nodes -sha256 -days 3650 -subj '/CN=3Dalice'
+ openssl req -x509 -newkey = ec -pkeyopt ec_paramgen_curve:secp384r1 -keyout - -nodes -sha256 -days 3650= -subj '/CN=3Dalice'


This gen= erate a certificate and a key for the client. The output of the command wil= l look
something like this:
@@ -162,7 += 168,7 @@
<peer-fingerprint>
= ff:ee:dd:cc:bb:aa:99:88:77:66:55:44:33:22:11:00:ff:ee:dd:cc:bb:aa:99:8= 8:77:66:55:44:33:22:11:00
99:88:77:66:55:44:33:22:11= :00:ff:ee:dd:cc:bb:aa:99:88:77:66:55:44:33:22:11:00:88:77:66:55:44:33
- </peer-fingperint&= gt;
+ </peer-= fingerprint>

6. (optional) if the cli= ent is an older client that does not support the
:code:= `peer-fingerprint` (e.g. OpenVPN 2.5 and older, OpenVPN Connect 3.3<= br>

To view, visit change 859. To unsubscribe, or for h= elp writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9a12a0c127908af9f09d88fb3a4= 93df3763d0cc5
Gerrit-Change-Number: 859
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--DbkcM37WuPU=--