From: "Sharma, Shashank" Subject: Re: [PATCH v5 04/11] drm/i915/dsb: Indexed register write function for DSB. Date: Mon, 9 Sep 2019 18:38:17 +0530 Message-ID: <57aa16dd-68e9-9913-3dee-c9ce6e9ae49e@intel.com> References: <20190907110735.10302-1-animesh.manna@intel.com> <20190907110735.10302-5-animesh.manna@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 91CBE89B48 for ; Mon, 9 Sep 2019 13:08:21 +0000 (UTC) In-Reply-To: <20190907110735.10302-5-animesh.manna@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org Ck9uIDkvNy8yMDE5IDQ6MzcgUE0sIEFuaW1lc2ggTWFubmEgd3JvdGU6Cj4gRFNCIGNhbiBwcm9n cmFtIGxhcmdlIHNldCBvZiBkYXRhIHRocm91Z2ggaW5kZXhlZCByZWdpc3RlciB3cml0ZQo+IChv cGNvZGUgMHg5KSBpbiBvbmUgc2hvdC4gRFNCIGZlYXR1cmUgY2FuIGJlIHVzZWQgZm9yIGJ1bGsg cmVnaXN0ZXIKPiBwcm9ncmFtbWluZyBlLmcuIGdhbW1hIGx1dCBwcm9ncmFtbWluZywgSERSIG1l dGEgZGF0YSBwcm9ncmFtbWluZy4KPgo+IHYxOiBpbml0aWFsIHZlcnNpb24uCj4gdjI6IHNpbXBs aWZpZWQgY29kZSBieSB1c2luZyBBTElHTigpLiAoQ2hyaXMpCj4gdjM6IGFzY2lpIHRhYmxlIGFk ZGVkIGFzIGNvZGUgY29tbWVudC4gKFNoYXNoYW5rKQo+Cj4gQ2M6IFNoYXNoYW5rIFNoYXJtYSA8 c2hhc2hhbmsuc2hhcm1hQGludGVsLmNvbT4KPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50 ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IENjOiBS b2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQW5p bWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5jIHwgNjQgKysrKysrKysrKysrKysrKysrKysr KysrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5oIHwgIDggKysr Cj4gICAyIGZpbGVzIGNoYW5nZWQsIDcyIGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuYwo+IGluZGV4IDE1MGJlODFmZGZiMy4uMGY1NWVkNjgz ZDQxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNi LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5jCj4gQEAg LTE1LDYgKzE1LDcgQEAKPiAgICNkZWZpbmUgRFNCX09QQ09ERV9JTkRFWEVEX1dSSVRFCTB4OQo+ ICAgI2RlZmluZSBEU0JfQllURV9FTgkJCTB4Rgo+ICAgI2RlZmluZSBEU0JfQllURV9FTl9TSElG VAkJMjAKPiArI2RlZmluZSBEU0JfUkVHX1ZBTFVFX01BU0sJCTB4ZmZmZmYKPiAgIAo+ICAgc3Ry dWN0IGludGVsX2RzYiAqCj4gICBpbnRlbF9kc2JfZ2V0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj KQo+IEBAIC03Nyw2ICs3OCw2OSBAQCB2b2lkIGludGVsX2RzYl9wdXQoc3RydWN0IGludGVsX2Rz YiAqZHNiKQo+ICAgCX0KPiAgIH0KPiAgIAo+ICt2b2lkIGludGVsX2RzYl9pbmRleGVkX3JlZ193 cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLAo+ICsJCQkJIHUzMiB2 YWwpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gY29udGFpbmVyX29mKGRzYiwg dHlwZW9mKCpjcnRjKSwgZHNiKTsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ICsJdTMyICpidWYgPSBkc2ItPmNtZF9idWY7 Cj4gKwl1MzIgcmVnX3ZhbDsKPiArCj4gKwlpZiAoIWJ1Zikgewo+ICsJCUk5MTVfV1JJVEUocmVn LCB2YWwpOwo+ICsJCXJldHVybjsKPiArCX0KPiArCj4gKwlpZiAoV0FSTl9PTihkc2ItPmZyZWVf cG9zID49IERTQl9CVUZfU0laRSkpIHsKPiArCQlEUk1fREVCVUdfS01TKCJEU0IgYnVmZmVyIG92 ZXJmbG93LlxuIik7CkFnYWluLCAnLicgaW4gdGhlIGVuZCBjYW4gYmUgcmVtb3ZlZAo+ICsJCXJl dHVybjsKPiArCX0KPiArCj4gKwkvKgo+ICsJICogRm9yIGV4YW1wbGUgdGhlIGJ1ZmZlciB3aWxs IGxvb2sgbGlrZSBiZWxvdyBmb3IgMyBkd29yZHMgZm9yIGF1dG8KPiArCSAqIGluY3JlbWVudCBy ZWdpc3RlcjoKPiArCSAqICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLSsKPiArCSAqIHwgc2l6ZSA9IDMgfCBvZmZzZXQgJnwgdmFsdWUxIHwg dmFsdWUyIHwgdmFsdWUzIHwgemVybyAgIHwKPiArCSAqIHwgICAgICAgICAgfCBvcGNvZGUgIHwg ICAgICAgIHwgICAgICAgIHwgICAgICAgIHwgICAgICAgIHwKPiArCSAqICstLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArCSAqICsgICAg ICAgICAgKyAgICAgICAgICsgICAgICAgICsgICAgICAgICsgICAgICAgICsgICAgICAgICsKPiAr CSAqIDAgICAgICAgICAgNCAgICAgICAgIDggICAgICAgIDEyICAgICAgIDE2ICAgICAgIDIwICAg ICAgIDI0Cj4gKwkgKiBCeXRlCj4gKwkgKgo+ICsJICogQXMgZXZlcnkgaW5zdHJ1Y3Rpb24gaXMg OCBieXRlIGFsaWduZWQgdGhlIGluZGV4IG9mIGRzYiBpbnN0cnVjdGlvbgo+ICsJICogd2lsbCBz dGFydCBhbHdheXMgZnJvbSBldmVuIG51bWJlciB3aGlsZSBkZWFsaW5nIHdpdGggdTMyIGFycmF5 IGFuZAo+ICsJICogemVybyB0byBiZSBhZGRlZCBmb3Igb2RkIG51bWJlciBvZiBkd29yZHMgYXQg dGhlIGxhc3QuCgpMZXQncyBzcGxpdCB0aGlzIGNvbW1lbnQgaW4gdHdvIHBhcnRzLCB0byBtYWtl IGV2ZW4gbW9yZSB1c2VmdWwsIGxpa2U6CgoiQXMgZXZlcnkgaW5zdHJ1Y3Rpb24gLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi4uLiBhcnJheSIuICJJZiB3ZSBhcmUgCndyaXRpbmcgb2RkIG5vIG9mIGR3 b3JkcywgWmVyb3Mgd2lsbCBiZSBhZGRlZCBpbiB0aGUgZW5kIGZvciBwYWRkaW5nLiIKCi0gU2hh c2hhbmsKCj4gKwkgKi8KPiArCXJlZ192YWwgPSBidWZbZHNiLT5pbnNfc3RhcnRfb2Zmc2V0ICsg MV0gJiBEU0JfUkVHX1ZBTFVFX01BU0s7Cj4gKwlpZiAocmVnX3ZhbCAhPSBpOTE1X21taW9fcmVn X29mZnNldChyZWcpKSB7Cj4gKwkJLyogRXZlcnkgaW5zdHJ1Y3Rpb24gc2hvdWxkIGJlIDggYnl0 ZSBhbGlnbmVkLiAqLwo+ICsJCWRzYi0+ZnJlZV9wb3MgPSBBTElHTihkc2ItPmZyZWVfcG9zLCAy KTsKPiArCj4gKwkJZHNiLT5pbnNfc3RhcnRfb2Zmc2V0ID0gZHNiLT5mcmVlX3BvczsKPiArCj4g KwkJLyogVXBkYXRlIHRoZSBzaXplLiAqLwo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0gMTsK PiArCj4gKwkJLyogVXBkYXRlIHRoZSBvcGNvZGUgYW5kIHJlZy4gKi8KPiArCQlidWZbZHNiLT5m cmVlX3BvcysrXSA9IChEU0JfT1BDT0RFX0lOREVYRURfV1JJVEUgIDw8Cj4gKwkJCQkJRFNCX09Q Q09ERV9TSElGVCkgfAo+ICsJCQkJCWk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZyk7Cj4gKwo+ICsJ CS8qIFVwZGF0ZSB0aGUgdmFsdWUuICovCj4gKwkJYnVmW2RzYi0+ZnJlZV9wb3MrK10gPSB2YWw7 Cj4gKwl9IGVsc2Ugewo+ICsJCS8qIFVwZGF0ZSB0aGUgbmV3IHZhbHVlLiAqLwo+ICsJCWJ1Zltk c2ItPmZyZWVfcG9zKytdID0gdmFsOwo+ICsKPiArCQkvKiBVcGRhdGUgdGhlIHNpemUuICovCj4g KwkJYnVmW2RzYi0+aW5zX3N0YXJ0X29mZnNldF0rKzsKPiArCX0KPiArCj4gKwkvKiBpZiBudW1i ZXIgb2YgZGF0YSB3b3JkcyBpcyBvZGQsIHRoZW4gdGhlIGxhc3QgZHdvcmQgc2hvdWxkIGJlIDAu Ki8KPiArCWlmIChkc2ItPmZyZWVfcG9zICYgMHgxKQo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zXSA9 IDA7Cj4gK30KPiArCj4gICB2b2lkIGludGVsX2RzYl9yZWdfd3JpdGUoc3RydWN0IGludGVsX2Rz YiAqZHNiLCBpOTE1X3JlZ190IHJlZywgdTMyIHZhbCkKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxf Y3J0YyAqY3J0YyA9IGNvbnRhaW5lcl9vZihkc2IsIHR5cGVvZigqY3J0YyksIGRzYik7Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5oCj4gaW5kZXggMzFiODdkY2ZlMTYw Li45YjI1MjJmMjBiZmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxh eS9pbnRlbF9kc2IuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZHNiLmgKPiBAQCAtMjksMTEgKzI5LDE5IEBAIHN0cnVjdCBpbnRlbF9kc2Igewo+ICAgCSAqIGFu ZCBoZWxwIGluIGNhbGN1bGF0aW5nIHRhaWwgb2YgY29tbWFuZCBidWZmZXIuCj4gICAJICovCj4g ICAJaW50IGZyZWVfcG9zOwo+ICsKPiArCS8qCj4gKwkgKiBpbnNfc3RhcnRfb2Zmc2V0IHdpbGwg aGVscCB0byBzdG9yZSBzdGFydCBhZGRyZXNzCj4gKwkgKiBvZiB0aGUgZHNiIGluc3R1Y3Rpb24g b2YgYXV0by1pbmNyZW1lbnQgcmVnaXN0ZXIuCj4gKwkgKi8KPiArCXUzMiBpbnNfc3RhcnRfb2Zm c2V0Owo+ICAgfTsKPiAgIAo+ICAgc3RydWN0IGludGVsX2RzYiAqCj4gICBpbnRlbF9kc2JfZ2V0 KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKTsKPiAgIHZvaWQgaW50ZWxfZHNiX3B1dChzdHJ1Y3Qg aW50ZWxfZHNiICpkc2IpOwo+ICAgdm9pZCBpbnRlbF9kc2JfcmVnX3dyaXRlKHN0cnVjdCBpbnRl bF9kc2IgKmRzYiwgaTkxNV9yZWdfdCByZWcsIHUzMiB2YWwpOwo+ICt2b2lkIGludGVsX2RzYl9p bmRleGVkX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLAo+ ICsJCQkJIHUzMiB2YWwpOwo+ICAgCj4gICAjZW5kaWYKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4