From: "flichtenheld (Code Review)" Date: Thu, 26 Jun 2025 09:03:20 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net Message-ID: <57c3470a73129f89aa42986289027956cd430aa5-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="B4HlBqWmf7U="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: run forced --dns-updown without --script-security List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: plaisthos , openvpn-devel --B4HlBqWmf7U= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/1065?usp=3Demail ) Change subject: run forced --dns-updown without --script-security ...................................................................... Patch Set 1: Code-Review-2 (1 comment) File src/openvpn/dns.c: http://gerrit.openvpn.net/c/openvpn/+/1065/comment/5051e657_d2d6667f : PS1, Line 583: if (dns_updown_user_set(o)) ``` dns.c: In function =E2=80=98do_run_up_down_command=E2=80=99: dns.c:583:29: error: passing argument 1 of =E2=80=98dns_updown_user_set=E2= =80=99 discards =E2=80=98const=E2=80=99 qualifier from pointer target type = [-Werror=3Ddiscarded-qualifiers] 583 | if (dns_updown_user_set(o)) | ^ In file included from dns.c:30: dns.h:209:41: note: expected =E2=80=98struct dns_options *=E2=80=99 but arg= ument is of type =E2=80=98const struct dns_options *=E2=80=99 209 | dns_updown_user_set(struct dns_options *o) | ~~~~~~~~~~~~~~~~~~~~^ ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1065?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I55940b78e35f0e3d74aa6cba14378afed97a444e Gerrit-Change-Number: 1065 Gerrit-PatchSet: 1 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: d12fk Gerrit-Comment-Date: Thu, 26 Jun 2025 09:03:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --B4HlBqWmf7U= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, plaisthos.

Patch set 1:Code-Review -2=

V= iew Change

1 comment:

To v= iew, visit change 1065. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I55940b78e35f0e3d74aa6cba143= 78afed97a444e
Gerrit-Change-Number: 1065
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Thu, 26 Jun 2025 09:03:20= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--B4HlBqWmf7U=--