From: "ordex (Code Review)" Date: Fri, 31 Jan 2025 08:30:23 +0000 In-Reply-To: References: Reply-To: a@...2181..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <57cebbe903bdd3551a379544f6e8c09aa8850a94-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ER/CO8l4ZxI="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/IPROUTE2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: cron2 Cc: plaisthos , flichtenheld , openvpn-devel --ER/CO8l4ZxI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/884?usp=3Demail ) Change subject: get_default_gateway(): implement platform support for Linux= /IPROUTE2 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Basically we're now sharing the implementation of net_route_v4_best_gw() fr= om SITNL to iproute2, as we were already doing for net_route_v6_best_gw(). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/884?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6f17140109106b37e6b0e690df1d87720ccf6f91 Gerrit-Change-Number: 884 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Fri, 31 Jan 2025 08:30:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --ER/CO8l4ZxI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

Patch set 1:Code-Review +2=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      Basically we're now sharing the implementa= tion of net_route_v4_best_gw() from SITNL to iproute2, as we were already d= oing for net_route_v6_best_gw().

To view, visit <= a href=3D"http://gerrit.openvpn.net/c/openvpn/+/884?usp=3Demail">change 884= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6f17140109106b37e6b0e690df1= d87720ccf6f91
Gerrit-Change-Number: 884
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <a@...2181...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Fri, 31 Jan 2025 08:30:23= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--ER/CO8l4ZxI=--