From: Tvrtko Ursulin Subject: Re: [RFC 4/4] drm/i915/pmu: Support multiple GPUs Date: Thu, 1 Aug 2019 13:03:03 +0100 Message-ID: <57db5ec7-abcd-5f54-9d3d-dd775a29977e@linux.intel.com> References: <20190801101825.2784-1-tvrtko.ursulin@linux.intel.com> <20190801101825.2784-5-tvrtko.ursulin@linux.intel.com> <156465630114.2512.5121906080629069813@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 022D76E56B for ; Thu, 1 Aug 2019 12:03:05 +0000 (UTC) In-Reply-To: <156465630114.2512.5121906080629069813@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzA4LzIwMTkgMTE6NDUsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA4LTAxIDExOjE4OjI1KQo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBXaXRoIGRpc2NyZXRlIGdyYXBoaWNzIHN5 c3RlbSBjYW4gaGF2ZSBib3RoIGludGVncmF0ZWQgYW5kIGRpc2NyZXRlIEdQVQo+PiBoYW5kbGVk IGJ5IGk5MTUuCj4+Cj4+IEN1cnJlbnRseSB3ZSB1c2UgYSBmaXhlZCBuYW1lICgiaTkxNSIpIHdo ZW4gcmVnaXN0ZXJpbmcgYXMgdGhlIHVuY29yZSBQTVUKPj4gcHJvdmlkZXIgd2hpY2ggc3RvcHMg d29ya2luZyBpbiB0aGlzIGNhc2UuCj4+Cj4+IEFkZCBhbiB1bmlxdWUgaW5zdGFuY2UgbnVtYmVy IGluIGZvcm0gb2YgImk5MTUtPGluc3RhbmNlPiIgdG8gZWFjaAo+PiByZWdpc3RlcmVkIFBNVSB0 byBzdXBwb3J0IHRoaXMuIEZpcnN0IGluc3RhbmNlIGtlZXBzIHRoZSBvbGQgbmFtZSB0bwo+PiBw cmVzZXJ2ZSBjb21wYXRpYmlsaXR5IHdpdGggZXhpc3RpbmcgdXNlcnNwYWNlLgo+Pgo+PiBTaWdu ZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+PiBD YzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+IENjOiBNaWNoYWwg V2FqZGVjemtvIDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4KPj4gLS0tCj4+IE9uZSBwcm9i bGVtIGlzIGhvdyB0byB0aWUgY2FycyBhbmQgUE1Vcy4KPj4KPj4gU2hvdWxkIHdlIGFwcGVuZCBz b21ldGhpbmcgYmV0dGVyIHRoYW4gdGhlIG9wYXF1ZSBpbnN0YW5jZSAod2hpY2gKPj4gZGVwZW5k cyBvbiBwcm9iaW5nIG9yZGVyKT8gTGlrZSBzb21lIGJ1cyBzbG90IGlkPyBCdXQgdGhlbiB3ZSBo YXZlIHRvCj4+IHNheSBnb29kYnllIHRvIHByZXNlcnZpbmcgdGhlICJsZWdhY3kiIG5hbWUgImk5 MTUiLgo+Pgo+PiBJIGNvdWxkbid0IGZpbmQgdGhhdCBwZXJmIHN1cHBvcnRzIGFueXRoaW5nIGZv ciB0aGVzZSBzY2VuYXJpb3MuCj4+Cj4+IE9yIG1heWJlIHdlIGNhbiBhZGQgYSBuZXcgZmlsZSAo c3lzZnM/KSwgd2hpY2ggd291bGQgYmUgY29ycmVjdGx5IHVuZGVyCj4+IHRoZSBidXMgaGllcmFy Y2h5LCBhbmQgd291bGQgZXhwb3J0IHRoZSBuYW1lIG9mIHRoZSBQTVUgaW5zdGFuY2UgdG8KPj4g dXNlPwo+IAo+IFdlIGRlZmluaXRlbHkgbmVlZCB0byBhZGQgc29tZSBtZWFucyBvZiB1bmlxdWVs eSBpZGVudGlmeWluZyBpOTE1IGludG8KPiBzeXNmcywgYW5kIGZvciB1cyB0byBsaW5rIGZyb20g YnVzL3BjaS9kZXZpY2VzLyBJdCBzZWVtcyBvZGQgdGhhdCB0aGlzCj4gaXMgbm90IGEgc29sdmVk IHByb2JsZW0gOnwgKFdoaWNoIG1lYW5zIEkndmUgcHJvYmFibHkgbWlzc2VkIGhvdyBpdCBpcwo+ IG1lYW50IHRvIGJlIGRvbmUuKQoKSSBkb24ndCB0aGluayB0aGVyZSBpcyB0aGUgImhvdyBpdCBp cyBtZWFudCB0byBiZSBkb25lIiBwYXJ0LiBGb3IgCmluc3RhbmNlIGV2ZW4gdW5wbHVnL3VubG9h ZCBpcyBub3QgaGFuZGxlZCBieSB0aGUgY29yZS4gV2hpY2ggcmVtaW5kcyBtZSAKdGhhdCBJIHdh bnRlZCB0byBhZGQgYSBtb2R1bGVfZ2V0L3B1dCBzb21ld2hlcmUgaW4gaTkxNV9wbXUuYyB0byBh dCAKbGVhc3Qgc2FtZSBteXNlbGYgZnJvbSBkb2luZyBpOTE1X3JlbG9hZCB3aXRoIGludGVsX2dw dV90b3AgaW4gYW5vdGhlciAKd2luZG93Li4gOikKCj4gU3RvcmluZyBhIHBtdS1uYW1lIGluc2lk ZSBzeXNmcyBzZWVtcyByZWFzb25hYmxlLCBhbmQgcG9zdHBvbmVzIHRoZQo+IHByb2JsZW0gb2Yg cGVyc2lzdGVudCBkZXZpY2UgbmFtZXMgZm9yIGk5MTUgdW50aWwgbGF0ZXIgOikKPiAoRndpdywg aG93IGFib3V0IHVzaW5nIGk5MTUtJHtwY2lfYWRkcn0sIG9yIGV2ZW4ganVzdCAke3BjaV9hZGRy fT8gSQo+IGV4cGVjdCB0aGF0IHBlcmYgd2lsbCBncm93IG11bHRpcGxlIGxvb2t1cCBwYXRocyBp ZiBtb3JlIGhvdHBsdWdnYWJsZQo+IGRldmljZXMgc3RhcnQgc3VwcG9ydGluZyBwZXJmIGV2ZW50 c3MpCgpZZXMgcGNpIGFkZHJlc3MgbG9va3MgbGlrZSBhIGdvb2QgY2FuZGlkYXRlLCBidXQgaG93 IGltcG9ydGFudCBpcyBsZWdhY3kgCmNvbXBhdGliaWxpdHk/IEJlY3Vhc2UgSSBkb24ndCB0aGlu ayB3ZSBoYXZlIGFiaWxpdHkgdG8gYWRkIGEgc3ltbGluayBhdCAKL3N5cy9kZXZpY2VzL2k5MTUg LT4gL3N5cy9kZXZpY2VzL2k5MTUtJHtwY2l9LiBDYW4gd2UgYnJlYWsgCmludGVsX2dwdV90b3Ag b3Igb3RoZXIgdG9vbHMgd2hpY2ggYXJlIG9ubHkgbG9va2luZyBhdCAKL3N5cy9kZXZpY2VzL2k5 MTUvZXZlbnRzPwoKPiAKPj4gLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUu YyB8IDIyICsrKysrKysrKysrKysrKysrKysrLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3BtdS5oIHwgIDggKysrKysrKysKPj4gICAyIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3BtdS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+PiBpbmRl eCA3YzQ4ZmNmMGNjY2IuLjEwNTI0NmFlNTE2MCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9wbXUuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Bt dS5jCj4+IEBAIC0xMDUzLDYgKzEwNTMsOCBAQCBzdGF0aWMgdm9pZCBpOTE1X3BtdV91bnJlZ2lz dGVyX2NwdWhwX3N0YXRlKHN0cnVjdCBpOTE1X3BtdSAqcG11KQo+PiAgICAgICAgICBjcHVocF9y ZW1vdmVfbXVsdGlfc3RhdGUoY3B1aHBfc2xvdCk7Cj4+ICAgfQo+PiAgIAo+PiArc3RhdGljIGF0 b21pY190IGk5MTVfcG11X2luc3RhbmNlID0gQVRPTUlDX0lOSVQoMCk7Cj4+ICsKPj4gICB2b2lk IGk5MTVfcG11X3JlZ2lzdGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+PiAgIHsK Pj4gICAgICAgICAgc3RydWN0IGk5MTVfcG11ICpwbXUgPSAmaTkxNS0+cG11Owo+PiBAQCAtMTA4 Myw5ICsxMDg1LDE3IEBAIHZvaWQgaTkxNV9wbXVfcmVnaXN0ZXIoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmk5MTUpCj4+ICAgICAgICAgIGhydGltZXJfaW5pdCgmcG11LT50aW1lciwgQ0xPQ0tf TU9OT1RPTklDLCBIUlRJTUVSX01PREVfUkVMKTsKPj4gICAgICAgICAgcG11LT50aW1lci5mdW5j dGlvbiA9IGk5MTVfc2FtcGxlOwo+PiAgIAo+PiAtICAgICAgIHJldCA9IHBlcmZfcG11X3JlZ2lz dGVyKCZwbXUtPmJhc2UsICJpOTE1IiwgLTEpOwo+PiArICAgICAgIHBtdS0+aW5zdGFuY2UgPSBh dG9taWNfaW5jX3JldHVybigmaTkxNV9wbXVfaW5zdGFuY2UpIC0gMTsKPj4gKyAgICAgICBpZiAo cG11LT5pbnN0YW5jZSkKPj4gKyAgICAgICAgICAgICAgIHBtdS0+bmFtZSA9IGthc3ByaW50ZihH RlBfS0VSTkVMLCAiaTkxNS0ldSIsIHBtdS0+aW5zdGFuY2UpOwo+PiArICAgICAgIGVsc2UKPj4g KyAgICAgICAgICAgICAgIHBtdS0+bmFtZSA9ICJpOTE1IjsKPj4gKyAgICAgICBpZiAoIXBtdS0+ bmFtZSkKPj4gKyAgICAgICAgICAgICAgIGdvdG8gZXJyX2luc3RhbmNlOwo+PiArCj4+ICsgICAg ICAgcmV0ID0gcGVyZl9wbXVfcmVnaXN0ZXIoJnBtdS0+YmFzZSwgcG11LT5uYW1lLCAtMSk7Cj4g Cj4gSWlyYywgdGhlIG5hbWUgaXMgYmFzaWNhbGx5IG9ubHkgdXNlZCB0byBjb25zdHJ1Y3QgdGhl IHBlcmYgc3lzZnMsIGFuZAo+IHRoZSB0b29scyBleHRyYWN0IHRoZSBldmVudCBuYW1lcyBhbmQg dGFncyBmcm9tIHRoZSBzeXNmcy4gU28gSSB3b25kZXIKPiBpZiB3ZSBjb3VsZCBhZGQgYSBzeW1s aW5rLi4uCgpPaCBvayBzeW1saW5rcyBhcmUgaGVyZS4uIHllYWgsIEkgdGhvdWdodCB3ZSBjYW4n dC4gQ2FuIHdlPwoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZng=