Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 914E3C433F5 for ; Tue, 29 Mar 2022 09:02:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 015A783C84; Tue, 29 Mar 2022 11:02:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1648544520; bh=inj0JOUnLIRVBb3atg09kclkzhrHJYlqi9mkn3Y1UgQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TR0o+fO3GEZWSrUG2VTwrFpYYyg4We9iyPqMlZ9gp92mFJ1ontIs2jhCvZy8PhuBv gAGlgM5ZCOu0OSYuRdojPGYiocF8l9iV/yWAMZaLNXEJnBF5p36O4hGdvOSCXmexW8 xKauNfjhOzD6KY2+DsuZOxTyoh4Dez+m8lR1v/gFCswj/kx0gscIpjnbNrKL/7aMll H+b6s7o4IivUbHmm0X2AZbMEDo6ZBcBy8xSYbN3PiSRoc1kUxUvPGJ959F7KSlLPRQ 2Eaf/6ZNpqpY1cQFZjmQjnwv5uhopQQF7NzGvz5FArQoCO6K1DJr27pMy+Nu4VcEsm PouUrJ3Na8hYA== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 75F43839C7; Tue, 29 Mar 2022 11:01:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1648544518; bh=inj0JOUnLIRVBb3atg09kclkzhrHJYlqi9mkn3Y1UgQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IKtYDj19DlNUYFrNK48WeA+IxGSMoZeV0fuPswF6ZeHv9Uqu1+KcThtEDlQS6xMrW eQTeTXQAN4mwXnHVU8zRtbF/bAXGS4w+86qYowddOPzac3hXVQAi0Jcrxee7SzQphj CsbSN4aUstlnyGhPScgwji+dZWl9P0NyquhCYvPxZWPBCCvvNNd/427zaiK6nZ6FDr iyaV96cSoJl708ABA/rUlrSflqvRGNp9fso+BA4SNnphPPTasacdkaWBEEyWMxd1P8 AayMTvTdXL3uG08VBPmuyFrhjIeX4jFuQvwlT8ry+C+SARu5Gq8KH/F4NKwGxRdEvj DGTKSiNeUuLTQ== Message-ID: <57e91c30-aaac-60cc-b2e6-15bf4b3ca9ae@denx.de> Date: Tue, 29 Mar 2022 11:01:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset Content-Language: en-US To: Ye Li , "u-boot@lists.denx.de" Cc: Peng Fan , "festevam@denx.de" , "sbabic@denx.de" References: <20220309160945.214591-1-marex@denx.de> <1647832589.20403.9.camel@nxp.com> <1eb56ad6-0158-5600-0ef9-6970316e96e7@denx.de> <1648002489.7912.21.camel@nxp.com> <1648450458.123397.21.camel@nxp.com> <65ea21e4-fc25-e33b-6196-ed133ff3211c@denx.de> <1648521609.123397.54.camel@nxp.com> From: Marek Vasut In-Reply-To: <1648521609.123397.54.camel@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/29/22 04:49, Ye Li wrote: Hi, >>> If you change the ROM API driver, that will break our design. You >>> can >>> try to overwrite spl_romapi_get_uboot_base for your board only. >> Since there are no users which boot from flexspi upstream, this >> design >> can still be fixed such that it does not require different flash.bin >> for >> different boot media, but rather one flash.bin works on all boot >> media. >> I think that is much better. > > Your flash.bin can work on flexspi because you manually program the > flexspi configurations header. Sure, the header content is described in the MX8MP RM Rev. 1 06/2021 "6.1.5.3.1 FlexSPI Configuration Block", this has nothing to do with this patch. > But once you want to upgrade the > flash.bin, flexspi configurations will also be erased due to the block > size. Then you have to reprogram the configurations with flash.bin. > So most of our customers add the flexspi configurations to flash.bin > head. They don't use so called one image for both SD and flexspi. There are no upstream users of flexspi right now, see above. > As the spl_romapi_get_uboot_base is defined to weak. It is better to > overwrite this function for your particular usage. I would much rather prefer to have one flash.bin which works on both SD card and FlexSPI, on all iMX8M, that is far less confusing. And since there are no upstream users of flexspi boot so far, this is how it can still be implemented, consistently. If downstream wants to have multiple flash.bin, one for each boot media, that's up to downstream. [...]