Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED9C98468 for ; Fri, 11 Aug 2023 18:47:12 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3fe2fb9b4d7so20104945e9.1 for ; Fri, 11 Aug 2023 11:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691779631; x=1692384431; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Lxiy661bwby5aRoESXiqAzZ+scVqqbirnP6RZhCnFMM=; b=A7ILmlQA5bAiH10V7GlC8sTxKLx9opJQGSJL4IhDwDxykOuY/Xwk67uZzoN8yINKvL 8b0JyhV9U1ExuK970841hQyGd9FsSkEI5XiTF+THXpZwJpzs+oOG+lTgXpwZtJMInL25 dE+Y1qIrKLCG2/VGZNMXUWxWnEqEuXaOqpdwPGrdG/hlT09iWJ25oyo/FbIKBf3zVV0e Mve9jAMHREhI8RexUeM5LQrBUaj2nyuUoisi5YXP0HxSo6YfeN/zG3ef1HVRShRhOyAq owhy8i1hRoeWRQTXKk+25PDQS0RTihMyO0pZeVEe4qFALQjqvAMvIveboGH1BGWVk4Kl znSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691779631; x=1692384431; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Lxiy661bwby5aRoESXiqAzZ+scVqqbirnP6RZhCnFMM=; b=WZ6cSIMZ19GDrS01EJymyTxsDVbax7EE1tlq6SZknxNgHWVUza5yBCVmnHaQEqSKxB GHcQVElv7PTclUkyRLlKx0NDhCMH3MIvNXpmabMtgOOu7bpcGi+dCUCicN7h2pteqIkA R+kAyOuH1LmAepuVdPxxFD7wlh393ZB1YnhnJAzvzmpiwH0v2EK8vcsuUAFO4j8z3hqH 1C2sM3Gos/sHKLXHd6Y/v33DmxE8nRnUBFXMSuCMATcxP/k5VQzdzVQ6ynZgQtSldF9L bUF02E0TgeEOhsCH0WYLIAy9pXB3/JhJ3CDtDBDjn531PqkRaZqeJi7XSJ2eoxzuCXhW samg== X-Gm-Message-State: AOJu0YzRBQrsiuSMOk6JL1i/56WPfmPYA11qLzsvk2/6QrwJdJ4g7RoD h82rCGI3EE5c5nhH/PbJxpoyxzPHGmAPmg== X-Google-Smtp-Source: AGHT+IH6iK08CJx3BF9fpDiBYtjrGSt7m8PU976946+kY85EA3t09QFl/CIA8khqPgbgmBL9w1BNUw== X-Received: by 2002:a05:600c:2946:b0:3fe:1f2c:df2b with SMTP id n6-20020a05600c294600b003fe1f2cdf2bmr2410275wmd.11.1691779630782; Fri, 11 Aug 2023 11:47:10 -0700 (PDT) Received: from [192.168.1.23] ([176.232.63.90]) by smtp.gmail.com with ESMTPSA id a9-20020a5d5089000000b0031434c08bb7sm6236129wrt.105.2023.08.11.11.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 11:47:09 -0700 (PDT) Message-ID: <5806ebf113d52c660e1c70e8a57cc047ab039aff.camel@gmail.com> Subject: Re: [PATCH v2 1/2] tpm/tpm_tis: Disable interrupts for Framework Laptop Intel 12th gen From: Grundik To: Jarkko Sakkinen , Thorsten Leemhuis , Lino Sanfilippo Cc: Linux kernel regressions list , Peter Huewe , Christian Hesse , stable@vger.kernel.org, roubro1991@gmail.com, Linus Torvalds , Christian Hesse , linux-integrity@vger.kernel.org Date: Fri, 11 Aug 2023 21:47:07 +0300 In-Reply-To: References: <20230710133836.4367-1-mail@eworm.de> <20230710142916.18162-1-mail@eworm.de> <20230710231315.4ef54679@leda.eworm.net> <0f272843a33a1706dbcbb2d84b02e3951ee60cbb.camel@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (by Flathub.org) Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2023-08-11 at 20:40 +0300, Jarkko Sakkinen wrote: > On Fri Aug 11, 2023 at 8:22 PM EEST, Jarkko Sakkinen wrote: > > On Fri Aug 11, 2023 at 11:18 AM EEST, Thorsten Leemhuis wrote: > >=20 > >=20 > > I see two long-standing options: > >=20 > > A. Move from deny list to allow list when considering using IRQs. > > This > > =C2=A0=C2=A0 can be supplemented with a kernel command-line parameter t= o > > enforce > > =C2=A0=C2=A0 IRQs and ignore the allow list (and IRQ storm detection pr= ovides > > =C2=A0=C2=A0 additional measure in case you try to enforce) > > B. Change deny list to match only vendors for the time being. This > > can > > =C2=A0=C2=A0 be supplemented with a allow list that is processed after = the > > deny > > =C2=A0=C2=A0 list for models where IRQs are known to work. [...] >=20 > This is also super time consuming and takes the focus away from more > important matters (like most likely the AMD rng fix would have gone > smoother without these getting in the way all the time). Main problem of any list is maintaining of them. So, I think there should not be any black or white lists at all. Module should work with reasonable default (polling is the one, which lived without problems for years and years due to bug, as I understand), and probably a boot option to force IRQ. Maybe module should warn user to try that option. I don't know: is it even worth it to use IRQ, if it so problematic? Are there any significant advantages of that? I understand, polling is a resource consumer, but its just TPM, which is used mainly at the boot time, is it worth it?