Received: from eggs.gnu.org ([2001:4830:134:3::10]:40077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3zQK-0007PM-MQ for qemu-devel@nongnu.org; Tue, 08 Nov 2016 00:58:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3zQH-0002mv-Hc for qemu-devel@nongnu.org; Tue, 08 Nov 2016 00:58:20 -0500 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]:35265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3zQH-0002mj-DB for qemu-devel@nongnu.org; Tue, 08 Nov 2016 00:58:17 -0500 Received: by mail-it0-x243.google.com with SMTP id b123so8907160itb.2 for ; Mon, 07 Nov 2016 21:58:15 -0800 (PST) Message-ID: <58216976.d0236b0a.77b99.bcd6@mx.google.com> From: Li Qiang Date: Mon, 7 Nov 2016 21:57:46 -0800 Subject: [Qemu-devel] [PATCH] usbredir: free vm_change_state_handler in usbredir destroy dispatch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kraxel@redhat.com, qemu-devel@nongnu.org Cc: Li Qiang From: Li Qiang In usbredir destroy dispatch function, it doesn't free the vm change state handler once registered in usbredir_realize function. This will lead a memory leak issue. This patch avoid this. Signed-off-by: Li Qiang --- hw/usb/redirect.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 528081e..a657237 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -132,6 +132,7 @@ struct USBRedirDevice { struct usbredirfilter_rule *filter_rules; int filter_rules_count; int compatible_speedmask; + VMChangeStateEntry *vmstate; }; #define TYPE_USB_REDIR "usb-redir" @@ -1411,7 +1412,8 @@ static void usbredir_realize(USBDevice *udev, Error **errp) usbredir_chardev_read, usbredir_chardev_event, dev, NULL, true); - qemu_add_vm_change_state_handler(usbredir_vm_state_change, dev); + dev->vmstate = + qemu_add_vm_change_state_handler(usbredir_vm_state_change, dev); } static void usbredir_cleanup_device_queues(USBRedirDevice *dev) @@ -1450,6 +1452,7 @@ static void usbredir_handle_destroy(USBDevice *udev) } free(dev->filter_rules); + qemu_del_vm_change_state_handler(dev->vmstate); } static int usbredir_check_filter(USBRedirDevice *dev) -- 1.8.3.1