From: =?UTF-8?Q?Nicolai_H=c3=a4hnle?= Subject: Re: [PATCH] drm/amdgpu: fix VM clearing in amdgpu_gem_object_close Date: Fri, 21 Apr 2017 10:20:17 +0200 Message-ID: <58478599-425b-91ad-abff-63e3d627ee71@gmail.com> References: <1492762023-2133-1-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1492762023-2133-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMjEuMDQuMjAxNyAxMDowNywgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBGcm9tOiBDaHJp c3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4KPiBXZSBuZWVkIHRvIGNo ZWNrIGlmIHRoZSBWTSBpcyBzd2FwcGVkIG91dCBiZWZvcmUgdHJ5aW5nIHRvIHVwZGF0ZSBpdC4K Pgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1k LmNvbT4KCk9vcHMuIFRoYXQgbWFrZXMgYSBsb3Qgb2Ygc2Vuc2UuLi4KCkZpeGVzOiAyM2UwNTYz ZTQ4ZjcgKCJkcm0vYW1kZ3B1OiBjbGVhciBmcmVlZCBtYXBwaW5ncyBpbW1lZGlhdGVseSB3aGVu IApCTyBtYXkgYmUgZnJlZWQiKQpSZXZpZXdlZC1ieTogTmljb2xhaSBIw6RobmxlIDxuaWNvbGFp LmhhZWhubGVAYW1kLmNvbT4KCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfZ2VtLmMgfCA2OCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nZW0uYyBiL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9nZW0uYwo+IGluZGV4IDAzODYwMTUuLjY3YmU3OTUg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dlbS5jCj4gQEAgLTEzOSw2 ICsxMzksMzUgQEAgaW50IGFtZGdwdV9nZW1fb2JqZWN0X29wZW4oc3RydWN0IGRybV9nZW1fb2Jq ZWN0ICpvYmosCj4gIAlyZXR1cm4gMDsKPiAgfQo+Cj4gK3N0YXRpYyBpbnQgYW1kZ3B1X2dlbV92 bV9jaGVjayh2b2lkICpwYXJhbSwgc3RydWN0IGFtZGdwdV9ibyAqYm8pCj4gK3sKPiArCS8qIGlm IGFueXRoaW5nIGlzIHN3YXBwZWQgb3V0IGRvbid0IHN3YXAgaXQgaW4gaGVyZSwKPiArCSAgIGp1 c3QgYWJvcnQgYW5kIHdhaXQgZm9yIHRoZSBuZXh0IENTICovCj4gKwlpZiAoIWFtZGdwdV9ib19n cHVfYWNjZXNzaWJsZShibykpCj4gKwkJcmV0dXJuIC1FUkVTVEFSVFNZUzsKPiArCj4gKwlpZiAo Ym8tPnNoYWRvdyAmJiAhYW1kZ3B1X2JvX2dwdV9hY2Nlc3NpYmxlKGJvLT5zaGFkb3cpKQo+ICsJ CXJldHVybiAtRVJFU1RBUlRTWVM7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRp YyBib29sIGFtZGdwdV9nZW1fdm1fcmVhZHkoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4g KwkJCQlzdHJ1Y3QgYW1kZ3B1X3ZtICp2bSwKPiArCQkJCXN0cnVjdCBsaXN0X2hlYWQgKmxpc3Qp Cj4gK3sKPiArCXN0cnVjdCB0dG1fdmFsaWRhdGVfYnVmZmVyICplbnRyeTsKPiArCj4gKwlsaXN0 X2Zvcl9lYWNoX2VudHJ5KGVudHJ5LCBsaXN0LCBoZWFkKSB7Cj4gKwkJc3RydWN0IGFtZGdwdV9i byAqYm8gPQo+ICsJCQljb250YWluZXJfb2YoZW50cnktPmJvLCBzdHJ1Y3QgYW1kZ3B1X2JvLCB0 Ym8pOwo+ICsJCWlmIChhbWRncHVfZ2VtX3ZtX2NoZWNrKE5VTEwsIGJvKSkKPiArCQkJcmV0dXJu IGZhbHNlOwo+ICsJfQo+ICsKPiArCXJldHVybiAhYW1kZ3B1X3ZtX3ZhbGlkYXRlX3B0X2Jvcyhh ZGV2LCB2bSwgYW1kZ3B1X2dlbV92bV9jaGVjaywgTlVMTCk7Cj4gK30KPiArCj4gIHZvaWQgYW1k Z3B1X2dlbV9vYmplY3RfY2xvc2Uoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmosCj4gIAkJCSAg ICAgc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYpCj4gIHsKPiBAQCAtMTQ4LDE1ICsxNzcsMTMg QEAgdm9pZCBhbWRncHVfZ2VtX29iamVjdF9jbG9zZShzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9i aiwKPiAgCXN0cnVjdCBhbWRncHVfdm0gKnZtID0gJmZwcml2LT52bTsKPgo+ICAJc3RydWN0IGFt ZGdwdV9ib19saXN0X2VudHJ5IHZtX3BkOwo+IC0Jc3RydWN0IGxpc3RfaGVhZCBsaXN0LCBkdXBs aWNhdGVzOwo+ICsJc3RydWN0IGxpc3RfaGVhZCBsaXN0Owo+ICAJc3RydWN0IHR0bV92YWxpZGF0 ZV9idWZmZXIgdHY7Cj4gIAlzdHJ1Y3Qgd3dfYWNxdWlyZV9jdHggdGlja2V0Owo+ICAJc3RydWN0 IGFtZGdwdV9ib192YSAqYm9fdmE7Cj4gLQlzdHJ1Y3QgZmVuY2UgKmZlbmNlID0gTlVMTDsKPiAg CWludCByOwo+Cj4gIAlJTklUX0xJU1RfSEVBRCgmbGlzdCk7Cj4gLQlJTklUX0xJU1RfSEVBRCgm ZHVwbGljYXRlcyk7Cj4KPiAgCXR2LmJvID0gJmJvLT50Ym87Cj4gIAl0di5zaGFyZWQgPSB0cnVl Owo+IEBAIC0xNjQsMTYgKzE5MSwxOCBAQCB2b2lkIGFtZGdwdV9nZW1fb2JqZWN0X2Nsb3NlKHN0 cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqLAo+Cj4gIAlhbWRncHVfdm1fZ2V0X3BkX2JvKHZtLCAm bGlzdCwgJnZtX3BkKTsKPgo+IC0JciA9IHR0bV9ldV9yZXNlcnZlX2J1ZmZlcnMoJnRpY2tldCwg Jmxpc3QsIGZhbHNlLCAmZHVwbGljYXRlcyk7Cj4gKwlyID0gdHRtX2V1X3Jlc2VydmVfYnVmZmVy cygmdGlja2V0LCAmbGlzdCwgZmFsc2UsIE5VTEwpOwo+ICAJaWYgKHIpIHsKPiAgCQlkZXZfZXJy KGFkZXYtPmRldiwgImxlYWtpbmcgYm8gdmEgYmVjYXVzZSAiCj4gIAkJCSJ3ZSBmYWlsIHRvIHJl c2VydmUgYm8gKCVkKVxuIiwgcik7Cj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAJYm9fdmEgPSBhbWRn cHVfdm1fYm9fZmluZCh2bSwgYm8pOwo+IC0JaWYgKGJvX3ZhKSB7Cj4gLQkJaWYgKC0tYm9fdmEt PnJlZl9jb3VudCA9PSAwKSB7Cj4gLQkJCWFtZGdwdV92bV9ib19ybXYoYWRldiwgYm9fdmEpOwo+ ICsJaWYgKGJvX3ZhICYmIC0tYm9fdmEtPnJlZl9jb3VudCA9PSAwKSB7Cj4gKwkJYW1kZ3B1X3Zt X2JvX3JtdihhZGV2LCBib192YSk7Cj4gKwo+ICsJCWlmIChhbWRncHVfZ2VtX3ZtX3JlYWR5KGFk ZXYsIHZtLCAmbGlzdCkpIHsKPiArCQkJc3RydWN0IGZlbmNlICpmZW5jZSA9IE5VTEw7Cj4KPiAg CQkJciA9IGFtZGdwdV92bV9jbGVhcl9mcmVlZChhZGV2LCB2bSwgJmZlbmNlKTsKPiAgCQkJaWYg KHVubGlrZWx5KHIpKSB7Cj4gQEAgLTUwNCwxOSArNTMzLDYgQEAgaW50IGFtZGdwdV9nZW1fbWV0 YWRhdGFfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXJldHVy biByOwo+ICB9Cj4KPiAtc3RhdGljIGludCBhbWRncHVfZ2VtX3ZhX2NoZWNrKHZvaWQgKnBhcmFt LCBzdHJ1Y3QgYW1kZ3B1X2JvICpibykKPiAtewo+IC0JLyogaWYgYW55dGhpbmcgaXMgc3dhcHBl ZCBvdXQgZG9uJ3Qgc3dhcCBpdCBpbiBoZXJlLAo+IC0JICAganVzdCBhYm9ydCBhbmQgd2FpdCBm b3IgdGhlIG5leHQgQ1MgKi8KPiAtCWlmICghYW1kZ3B1X2JvX2dwdV9hY2Nlc3NpYmxlKGJvKSkK PiAtCQlyZXR1cm4gLUVSRVNUQVJUU1lTOwo+IC0KPiAtCWlmIChiby0+c2hhZG93ICYmICFhbWRn cHVfYm9fZ3B1X2FjY2Vzc2libGUoYm8tPnNoYWRvdykpCj4gLQkJcmV0dXJuIC1FUkVTVEFSVFNZ UzsKPiAtCj4gLQlyZXR1cm4gMDsKPiAtfQo+IC0KPiAgLyoqCj4gICAqIGFtZGdwdV9nZW1fdmFf dXBkYXRlX3ZtIC11cGRhdGUgdGhlIGJvX3ZhIGluIGl0cyBWTQo+ICAgKgo+IEBAIC01MzUsMTkg KzU1MSw5IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV9nZW1fdmFfdXBkYXRlX3ZtKHN0cnVjdCBhbWRn cHVfZGV2aWNlICphZGV2LAo+ICAJCQkJICAgIHN0cnVjdCBsaXN0X2hlYWQgKmxpc3QsCj4gIAkJ CQkgICAgdWludDMyX3Qgb3BlcmF0aW9uKQo+ICB7Cj4gLQlzdHJ1Y3QgdHRtX3ZhbGlkYXRlX2J1 ZmZlciAqZW50cnk7Cj4gIAlpbnQgciA9IC1FUkVTVEFSVFNZUzsKPgo+IC0JbGlzdF9mb3JfZWFj aF9lbnRyeShlbnRyeSwgbGlzdCwgaGVhZCkgewo+IC0JCXN0cnVjdCBhbWRncHVfYm8gKmJvID0K PiAtCQkJY29udGFpbmVyX29mKGVudHJ5LT5ibywgc3RydWN0IGFtZGdwdV9ibywgdGJvKTsKPiAt CQlpZiAoYW1kZ3B1X2dlbV92YV9jaGVjayhOVUxMLCBibykpCj4gLQkJCWdvdG8gZXJyb3I7Cj4g LQl9Cj4gLQo+IC0JciA9IGFtZGdwdV92bV92YWxpZGF0ZV9wdF9ib3MoYWRldiwgdm0sIGFtZGdw dV9nZW1fdmFfY2hlY2ssCj4gLQkJCQkgICAgICBOVUxMKTsKPiAtCWlmIChyKQo+ICsJaWYgKCFh bWRncHVfZ2VtX3ZtX3JlYWR5KGFkZXYsIHZtLCBsaXN0KSkKPiAgCQlnb3RvIGVycm9yOwo+Cj4g IAlyID0gYW1kZ3B1X3ZtX3VwZGF0ZV9kaXJlY3RvcmllcyhhZGV2LCB2bSk7Cj4KCgotLSAKTGVy bmUsIHdpZSBkaWUgV2VsdCB3aXJrbGljaCBpc3QsCkFiZXIgdmVyZ2lzcyBuaWVtYWxzLCB3aWUg c2llIHNlaW4gc29sbHRlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK