From: Michael Trimarchi Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch Date: Tue, 16 Sep 2008 11:11:59 +0000 (GMT) Message-ID: <58603.86657.qm@web26202.mail.ukl.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Hisashi Hifumi , akpm@linux-foundation.org Return-path: Received: from web26202.mail.ukl.yahoo.com ([217.12.10.239]:40674 "HELO web26202.mail.ukl.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751079AbYIPLSl convert rfc822-to-8bit (ORCPT ); Tue, 16 Sep 2008 07:18:41 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, > + if (offset != file_pos_read(file)) > + file_pos_write(file, offset); > retval = offset; > } Is not more efficient here a compare xchg operation? Regards Michael __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da tanto spazio gratuito per i tuoi file e i messaggi http://mail.yahoo.it