Received: from eggs.gnu.org ([2001:4830:134:3::10]:42299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc1LY-0002rM-4B for qemu-devel@nongnu.org; Thu, 09 Feb 2017 21:54:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc1LX-0002o5-Aj for qemu-devel@nongnu.org; Thu, 09 Feb 2017 21:54:04 -0500 Message-ID: <589D2A50.5030500@huawei.com> Date: Fri, 10 Feb 2017 10:49:52 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1486644810-33181-1-git-send-email-agraf@suse.de> <1486644810-33181-4-git-send-email-agraf@suse.de> In-Reply-To: <1486644810-33181-4-git-send-email-agraf@suse.de> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/4] hw/arm/virt: Declare fwcfg as dma cache coherent in ACPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: Ard Biesheuvel , qemu-arm@nongnu.org, Laszlo Ersek , Shannon Zhao , mst@redhat.com On 2017/2/9 20:53, Alexander Graf wrote: > Fw-cfg recently learned how to directly access guest memory and does so in > cache coherent fashion. Tell the guest about that fact when it's using ACPI. > > Signed-off-by: Alexander Graf > --- > hw/arm/virt-acpi-build.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Shannon Zhao > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index 8955a9d..0835e59 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -90,6 +90,7 @@ static void acpi_dsdt_add_fw_cfg(Aml *scope, const MemMapEntry *fw_cfg_memmap) > aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002"))); > /* device present, functioning, decoding, not shown in UI */ > aml_append(dev, aml_name_decl("_STA", aml_int(0xB))); > + aml_append(dev, aml_name_decl("_CCA", aml_int(1))); > > Aml *crs = aml_resource_template(); > aml_append(crs, aml_memory32_fixed(fw_cfg_memmap->base, > -- Shannon