From: "flichtenheld (Code Review)" Date: Tue, 21 Jan 2025 13:28:25 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <58f7f6d9875f82e09cc09445e89c14982f30b72d-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="p11lWF2MqFU="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Print warnings/errors when numerical parameters cannot be parsed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --p11lWF2MqFU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/873?usp=3Demail ) Change subject: Print warnings/errors when numerical parameters cannot be p= arsed ...................................................................... Patch Set 1: Code-Review-2 (1 comment) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/873/comment/a064c05a_92fbd9c8 : PS1, Line 4939: if (i < 0 || endptr || i > INT_MAX) Should probably be *endptr? Basically we want to check that it is \0, right? t_server fails with: "Options error: Cannot parse argument '2' as non-negative integer" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/873?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8edd77ee2be4de Gerrit-Change-Number: 873 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 21 Jan 2025 13:28:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --p11lWF2MqFU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 1:Code-Review -2=

Vi= ew Change

1 comment:

  • File src/openvpn/options.c:

    <= ul style=3D"list-style: none; padding: 0;">
  • Patch Set #1, Line 4939= : if (i < 0 || e= ndptr || i > INT_MAX)

    Should probably be *endptr? Basically we want to check t= hat it is \0, right?

    t_server fails with:
    "Options error: Cannot parse argument = '2' as non-negative integer"

To view= , visit c= hange 873. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie1e2eb54d516b3ae87c5ca56fe8= edd77ee2be4de
Gerrit-Change-Number: 873
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Tue, 21 Jan 2025 13:28:25= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--p11lWF2MqFU=--