Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22392C433E0 for ; Tue, 26 Jan 2021 14:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2F9F206CA for ; Tue, 26 Jan 2021 14:15:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405547AbhAZOPO (ORCPT ); Tue, 26 Jan 2021 09:15:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22985 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404469AbhAZOO5 (ORCPT ); Tue, 26 Jan 2021 09:14:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611670411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0XmClLgpdiAZK6ABwbP7OwH9PhDGGYb9dqqasaMbUXU=; b=YeSf+i818qMN53wZ7drhI33di3GhqGaJkaML4XcIIb7nqKKDvP09PDvTHBXj8c0ySVdvA3 KYiTIC1cjYOeHeTe1OHlJ5S5KPlBTp6qWCUaX2PAfD3fJRCs6BwZdyb6IwA36K5XB2rNJ5 f9awN7SosR+xAFs0DB9AmillDvP0r9I= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-R6Ul2_GRPiuxw0eRYEROlQ-1; Tue, 26 Jan 2021 09:13:29 -0500 X-MC-Unique: R6Ul2_GRPiuxw0eRYEROlQ-1 Received: by mail-ej1-f72.google.com with SMTP id m4so4948773ejc.14 for ; Tue, 26 Jan 2021 06:13:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0XmClLgpdiAZK6ABwbP7OwH9PhDGGYb9dqqasaMbUXU=; b=GvypSf1enqPEf5wz7AnancWXqv83Fyf4Vkt1BIhxvjwjuCrF/h560tP7AIdUyJe2nK fOvKcbfnEkVWqhRkOhB3JUt8kQXJzTyihKoHaHjRqnsaWcBruQYJ1937QM/3gSxPZ0LF YA8DZvHURdU7kWyIdQE8p2jt2qJiKUuLQzG0fc4MtmOEIgFjyf/SfSuQOPoiq+1vyzFd wTjBQHg3Io4bpFzFMDn6y7bGjLxmrh39aQVAL311CWXJQ2l/Jbl9fTD26JkU9hlj8qYq Q+HvCRcRXeThyirc2blVttJkeX5zEb3W0UrpSX/MMuxR3ewV1PadPv2m94UBroqTKUUx B4SA== X-Gm-Message-State: AOAM530x8xDxJtCSEON+tu5Z3ZItTGJOCC7liQ7IGeHLFw+zYBa2hBXf qRyZUHbzp/SQmhSD6jFfxDlIo/dQwLI9DSc89JWbYzJa1/xbrTPyHZdIknwcLNK9Ozyu2zt75Ty mfQdwSTca9jUC X-Received: by 2002:a17:906:1689:: with SMTP id s9mr3502061ejd.500.1611670408301; Tue, 26 Jan 2021 06:13:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxi1QfIxQADqBnFEJxOPrj4y68FFhT3rMTNL2K3ql/AAo8qnrn8CLNhzsYz8mHMWZ8PTcrtw== X-Received: by 2002:a17:906:1689:: with SMTP id s9mr3502048ejd.500.1611670408146; Tue, 26 Jan 2021 06:13:28 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id d5sm4951358edu.12.2021.01.26.06.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jan 2021 06:13:27 -0800 (PST) Subject: Re: [PATCH 07/24] kvm: x86/mmu: Add comment on __tdp_mmu_set_spte To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20210112181041.356734-1-bgardon@google.com> <20210112181041.356734-8-bgardon@google.com> From: Paolo Bonzini Message-ID: <59044c30-3ffb-e0ca-9bb0-7b409e6bec08@redhat.com> Date: Tue, 26 Jan 2021 15:13:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210112181041.356734-8-bgardon@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/01/21 19:10, Ben Gardon wrote: > __tdp_mmu_set_spte is a very important function in the TDP MMU which > already accepts several arguments and will take more in future commits. > To offset this complexity, add a comment to the function describing each > of the arguemnts. > > No functional change intended. > > Reviewed-by: Peter Feiner > > Signed-off-by: Ben Gardon > --- > arch/x86/kvm/mmu/tdp_mmu.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c > index 2650fa9fe066..b033da8243fc 100644 > --- a/arch/x86/kvm/mmu/tdp_mmu.c > +++ b/arch/x86/kvm/mmu/tdp_mmu.c > @@ -357,6 +357,22 @@ static void handle_changed_spte(struct kvm *kvm, int as_id, gfn_t gfn, > new_spte, level); > } > > +/* > + * __tdp_mmu_set_spte - Set a TDP MMU SPTE and handle the associated bookkeeping > + * @kvm: kvm instance > + * @iter: a tdp_iter instance currently on the SPTE that should be set > + * @new_spte: The value the SPTE should be set to > + * @record_acc_track: Notify the MM subsystem of changes to the accessed state > + * of the page. Should be set unless handling an MMU > + * notifier for access tracking. Leaving record_acc_track > + * unset in that case prevents page accesses from being > + * double counted. > + * @record_dirty_log: Record the page as dirty in the dirty bitmap if > + * appropriate for the change being made. Should be set > + * unless performing certain dirty logging operations. > + * Leaving record_dirty_log unset in that case prevents page > + * writes from being double counted. > + */ > static inline void __tdp_mmu_set_spte(struct kvm *kvm, struct tdp_iter *iter, > u64 new_spte, bool record_acc_track, > bool record_dirty_log) > Queued, thanks. Paolo