Received: by 2002:a17:504:5f68:b0:1be9:327d:8ee3 with SMTP id gl8csp74170njc; Thu, 26 Sep 2024 19:20:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWiTbsAwPW9rAsxpR6fOaCWr+SKLwUmOxXtMYcxMszmxemibG5XGvoUNg3fcsRt3FkLz8sChikNI9BWaQ==@linaro.org X-Google-Smtp-Source: AGHT+IFRqz0WBeBerbYeH3Nr+ZO8WsW0yCZdZuEFFM6FfwFUwyAqddbsAd1PUa7PnRviB0spqJ6n X-Received: by 2002:a05:620a:45a3:b0:7a9:9fd0:3e00 with SMTP id af79cd13be357-7ae378d480dmr252627785a.62.1727403612340; Thu, 26 Sep 2024 19:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727403612; cv=none; d=google.com; s=arc-20240605; b=lfnNTt9M66MRc0o+RTkbENHXDhjfUltq/jq/PXvLnFaNO8VecdZ3Czl+/7/US05Aoi rscO6x/BtUsYE8c1B701gbZgT/TCidnb6m9Ko7c6z9demhePexXE4oCq0lrZHVcbHtqT 0N3FLHPCbTZ9coanrDi/63vK+7AJ+xFhBWRWiCTbfOzlrDGNImfEDEQ9qr3Ul+2d+p6r DYRMd2MbVDp2aAU8aHpT1i/KIBqiY/cMJRf9aSRmbkOu0AVLWCCXRcwpczgXVFSTJJQI okpwS48ho5r7S5vdX6lCo8zg0ScB4aSN1ZSq5GRMqNYctrw+swfBHgU1LQ8qVDOlIUeD i8jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=cm1nC1Y8MQ1E3bPX8fk0KXIdZ8AlPJE+1PF/2ZLOrRI=; fh=ZOisryR2Mb28fNxWQse9qjy5qBOClWtToxOZdGTojXg=; b=jMovfcfUfDeqJvs8+1PDN+6n9gGnAzKSc5YEtzRc0LfR6SfNN/yadV9m/EY2YDaSq9 dsDu95W/NtxCCCmfkW44ZS0m4wsCREX0j9dLU64DpVTsNiGBFrLRj2yGUubCBhgM1CMf XncDnTzLmkJ3Yzk054bT8Nx74vftkWMzjBIV4wa7YUC+PZ6SrGqxfCC1+N2V1efeqElH nOvUrI7rngZzkzOKWoQkVV5L6OcmhhavfGAaNFEnwWvsCGj4Gajo3RbNJZZ87eahCGSZ amFUKQnX6z2AwdhVQdZvnWxub0O2t6JmBe97rwNbtGmVZEwKC6h1URj1+djQlikdyFno 9e7A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b="Jbnj/Nea"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7ae378a4becsi117717185a.752.2024.09.26.19.20.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Sep 2024 19:20:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b="Jbnj/Nea"; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1su0aS-0006mY-3E; Thu, 26 Sep 2024 22:20:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su0aQ-0006k5-3D; Thu, 26 Sep 2024 22:20:02 -0400 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su0aO-0007rb-5y; Thu, 26 Sep 2024 22:20:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1727403593; bh=cm1nC1Y8MQ1E3bPX8fk0KXIdZ8AlPJE+1PF/2ZLOrRI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Jbnj/NeaRdBFdV+9TuheonzdWVuHHiW0cJDEvh19KliyHSdeNp6DoViGjWuoiu5JQ zmo8jvcIvEl2dsgKV0CWu7oabl/NMjWR8HawTRFmStHELOZwYb81cOaarZ6fT+FmvN 5wQpy6wY2AgnrKRfuDPlZcd4g1PaKXpva0M3rD3JJBGPhOoFsxhgy0etlRiSpHEs9q pzyw7ImzgiMpoRiWxGBJDZEknaVLiGPn5J0VK5cwSmkJnCpMMvYvCxFxAxUMCo4xC8 P+joYOC2rQVacZGnKfLLcJqUoILewQNLwY9M5X84JLbvVH44QhfNoyk2KvybwdC/UA Ny1RcuoYTQvcA== Received: from [192.168.68.112] (ppp118-210-187-73.adl-adc-lon-bras34.tpg.internode.on.net [118.210.187.73]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 34F9A6502D; Fri, 27 Sep 2024 10:19:53 +0800 (AWST) Message-ID: <599cdb2fa47a4c1da5775be175ec67d66cf7cf43.camel@codeconstruct.com.au> Subject: Re: [PATCH v3 5/6] hw/gpio/aspeed: Add AST2700 support From: Andrew Jeffery To: Jamin Lin , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Peter Maydell , Steven Lee , Troy Lee , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" Cc: troy_lee@aspeedtech.com, yunlin.tang@aspeedtech.com Date: Fri, 27 Sep 2024 11:49:52 +0930 In-Reply-To: <20240926074535.1286209-6-jamin_lin@aspeedtech.com> References: <20240926074535.1286209-1-jamin_lin@aspeedtech.com> <20240926074535.1286209-6-jamin_lin@aspeedtech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Received-SPF: pass client-ip=203.29.241.158; envelope-from=andrew@codeconstruct.com.au; helo=codeconstruct.com.au X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: 6vRjiWMaWRpj On Thu, 2024-09-26 at 15:45 +0800, Jamin Lin wrote: > AST2700 integrates two set of Parallel GPIO Controller > with maximum 212 control pins, which are 27 groups. > (H, exclude pin: H7 H6 H5 H4) >=20 > In the previous design of ASPEED SOCs, > one register is used for setting one function for one set which are 32 pi= ns > and 4 groups. > ex: GPIO000 is used for setting data value for GPIO A, B, C and D in AST2= 600. > ex: GPIO004 is used for setting direction for GPIO A, B, C and D in AST26= 00. >=20 > However, the register set have a significant change since AST2700. > Each GPIO pin has their own individual control register. In other words, = users are able to > set one GPIO pin=E2=80=99s direction, interrupt enable, input mask and so= on > in the same one register. >=20 > Currently, aspeed_gpio_read/aspeed_gpio_write callback functions > are not compatible AST2700. > Introduce new aspeed_gpio_2700_read/aspeed_gpio_2700_write callback funct= ions > and aspeed_gpio_2700_ops memory region operation for AST2700. > Introduce a new ast2700 class to support AST2700. >=20 > Signed-off-by: Jamin Lin Some of the wrapping in the commit message could be improved, but otherwise: Reviewed-by: Andrew Jeffery