From: Masaki Kanno Subject: [PATCH] Add memory size checking for xm create/mem-set command Date: Tue, 19 Sep 2006 13:16:15 +0900 Message-ID: <5AC6DBA2594B6Akanno.masaki@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-rR3OoxtJ9gug1Z0VQv48t" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-rR3OoxtJ9gug1Z0VQv48t Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Description: Mail message body Hi, The "xm create" command does not check the value of memory size now. The "xm mem-set" command does not check, too. When I tested the "xm create" and the "xm mem-set" command by setting an obviously wrong value to the memory size, the results were as follows. # xm create /xen/vm1.conf memory=0 Using config file "/xen/vm1.conf". Error: (22, 'Invalid argument') # xm create /xen/vm1.conf memory=-1 Using config file "/xen/vm1.conf". Error: (22, 'Invalid argument') # xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 506 2 r----- 108.4 vm1 5 128 1 -b---- 31.3 # xm mem-set vm1 0 # xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 506 2 r----- 109.2 vm1 5 27 1 -b---- 31.8 *The following message was output to the console of domU. Out of Memory: Kill process 2 (migration/0) score 0 and children. # xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 506 2 r----- 159.2 vm1 7 128 1 -b---- 31.6 # xm mem-set vm1 -1 # xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 506 2 r----- 159.9 vm1 7 -1 1 -b---- 31.6 I think that the xm/xend should check the obviously wrong memory size, and should show an error message. This patch adds the checking of obviously wrong memory size about the "xm create" and "xm mem-set" command. # xm create /xen/vm1.conf memory=0 Using config file "/xen/vm1.conf". Error: invalid memory size # xm create /xen/vm1.conf memory=-1 Using config file "/xen/vm1.conf". Error: invalid memory size # xm mem-set vm1 0 Error: Invalid memory size # xm mem-set vm1 -1 Error: Invalid memory size Signed-off-by: Masaki Kanno Best regards, Kan --Boundary-rR3OoxtJ9gug1Z0VQv48t Content-Type: application/octet-stream; name="memory_size.patch" Content-Disposition: attachment; filename="memory_size.patch" Content-Transfer-Encoding: base64 ZGlmZiAtciBkNTlkNmE0NDBhNDEgdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmREb21haW5J bmZvLnB5Ci0tLSBhL3Rvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5kRG9tYWluSW5mby5weQlG cmkgU2VwIDE1IDIzOjU0OjA0IDIwMDYgKzAxMDAKKysrIGIvdG9vbHMvcHl0aG9uL3hlbi94 ZW5kL1hlbmREb21haW5JbmZvLnB5CU1vbiBTZXAgMTggMTA6NTQ6NDggMjAwNiArMDkwMApA QCAtNTk2LDYgKzU5Niw4IEBAIGNsYXNzIFhlbmREb21haW5JbmZvOgogICAgICAgICAgICAg aWYgc2VsZi5pbmZvWydtZW1vcnknXSA9PSAwOgogICAgICAgICAgICAgICAgIGlmIHNlbGYu aW5mb0lzU2V0KCdtZW1fa2InKToKICAgICAgICAgICAgICAgICAgICAgc2VsZi5pbmZvWydt ZW1vcnknXSA9IChzZWxmLmluZm9bJ21lbV9rYiddICsgMTAyMykgLyAxMDI0CisgICAgICAg ICAgICBpZiBzZWxmLmluZm9bJ21lbW9yeSddIDw9IDA6CisgICAgICAgICAgICAgICAgcmFp c2UgVm1FcnJvcignaW52YWxpZCBtZW1vcnkgc2l6ZScpCiAKICAgICAgICAgICAgIGlmIHNl bGYuaW5mb1snbWF4bWVtJ10gPCBzZWxmLmluZm9bJ21lbW9yeSddOgogICAgICAgICAgICAg ICAgIHNlbGYuaW5mb1snbWF4bWVtJ10gPSBzZWxmLmluZm9bJ21lbW9yeSddCkBAIC0xMDAx LDYgKzEwMDMsOSBAQCBjbGFzcyBYZW5kRG9tYWluSW5mbzoKICAgICAgICAgIiIiU2V0IHRo ZSBtZW1vcnkgdGFyZ2V0IG9mIHRoaXMgZG9tYWluLgogICAgICAgICBAcGFyYW0gdGFyZ2V0 IEluIE1pQi4KICAgICAgICAgIiIiCisgICAgICAgIGlmIHRhcmdldCA8PSAwOgorICAgICAg ICAgICAgcmFpc2UgWGVuZEVycm9yKCJJbnZhbGlkIG1lbW9yeSBzaXplIikKKyAgICAgICAg CiAgICAgICAgIGxvZy5kZWJ1ZygiU2V0dGluZyBtZW1vcnkgdGFyZ2V0IG9mIGRvbWFpbiAl cyAoJWQpIHRvICVkIE1pQi4iLAogICAgICAgICAgICAgICAgICAgc2VsZi5pbmZvWyduYW1l J10sIHNlbGYuZG9taWQsIHRhcmdldCkKICAgICAgICAgCg== --Boundary-rR3OoxtJ9gug1Z0VQv48t Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-rR3OoxtJ9gug1Z0VQv48t--