From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 4/5] drm/amdgpu: add amdgpu_gmc_get_pde_for_bo helper Date: Mon, 27 Aug 2018 10:05:54 +0800 Message-ID: <5B835C82.8050007@amd.com> References: <20180824142002.2315-1-christian.koenig@amd.com> <20180824142002.2315-4-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180824142002.2315-4-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMDgvMjQvMjAxOCAxMDoyMCBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBIZWxwZXIg dG8gZ2V0IHRoZSBQREUgZm9yIGEgUEQvUFQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4g S8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+ClJldmlld2VkLWJ5OiBKdW53ZWkgWmhh bmcgPEplcnJ5LlpoYW5nQGFtZC5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvYW1kZ3B1X2dtYy5jIHwgMzcgKysrKysrKysrKysrKysrKysrKysrKystLQo+ICAgZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dtYy5oIHwgIDIgKysKPiAgIGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyB8IDIxICsrKysrKysrKysrKy0tCj4gICBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmggfCAgMSArCj4gICBkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyAgfCAgNCArLS0KPiAgIDUgZmlsZXMgY2hh bmdlZCwgNTcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmMgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfZ21jLmMKPiBpbmRleCAzNjA1OGZlYWM2NGYuLjZmNzljZTEwODcy OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZ21jLmMKPiBAQCAtMjYs NiArMjYsMzggQEAKPgo+ICAgI2luY2x1ZGUgImFtZGdwdS5oIgo+Cj4gKy8qKgo+ICsgKiBhbWRn cHVfZ21jX2dldF9wZGVfZm9yX2JvIC0gZ2V0IHRoZSBQREUgZm9yIGEgQk8KPiArICoKPiArICog QGJvOiB0aGUgQk8gdG8gZ2V0IHRoZSBQREUgZm9yCj4gKyAqIEBsZXZlbDogdGhlIGxldmVsIGlu IHRoZSBQRCBoaXJhcmNoeQo+ICsgKiBAYWRkcjogcmVzdWx0aW5nIGFkZHIKPiArICogQGZsYWdz OiByZXN1bHRpbmcgZmxhZ3MKPiArICoKPiArICogR2V0IHRoZSBhZGRyZXNzIGFuZCBmbGFncyB0 byBiZSB1c2VkIGZvciBhIFBERS4KPiArICovCj4gK3ZvaWQgYW1kZ3B1X2dtY19nZXRfcGRlX2Zv cl9ibyhzdHJ1Y3QgYW1kZ3B1X2JvICpibywgaW50IGxldmVsLAo+ICsJCQkgICAgICAgdWludDY0 X3QgKmFkZHIsIHVpbnQ2NF90ICpmbGFncykKPiArewo+ICsJc3RydWN0IGFtZGdwdV9kZXZpY2Ug KmFkZXYgPSBhbWRncHVfdHRtX2FkZXYoYm8tPnRiby5iZGV2KTsKPiArCXN0cnVjdCB0dG1fZG1h X3R0ICp0dG07Cj4gKwo+ICsJc3dpdGNoIChiby0+dGJvLm1lbS5tZW1fdHlwZSkgewo+ICsJY2Fz ZSBUVE1fUExfVFQ6Cj4gKwkJdHRtID0gY29udGFpbmVyX29mKGJvLT50Ym8udHRtLCBzdHJ1Y3Qg dHRtX2RtYV90dCwgdHRtKTsKPiArCQkqYWRkciA9IHR0bS0+ZG1hX2FkZHJlc3NbMF07Cj4gKwkJ YnJlYWs7Cj4gKwljYXNlIFRUTV9QTF9WUkFNOgo+ICsJCSphZGRyID0gYW1kZ3B1X2JvX2dwdV9v ZmZzZXQoYm8pOwo+ICsJCWJyZWFrOwo+ICsJZGVmYXVsdDoKPiArCQkqYWRkciA9IDA7Cj4gKwkJ YnJlYWs7Cj4gKwl9Cj4gKwkqZmxhZ3MgPSBhbWRncHVfdHRtX3R0X3BkZV9mbGFncyhiby0+dGJv LnR0bSwgJmJvLT50Ym8ubWVtKTsKPiArCWFtZGdwdV9nbWNfZ2V0X3ZtX3BkZShhZGV2LCBsZXZl bCwgYWRkciwgZmxhZ3MpOwo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBhbWRncHVfZ21jX3BkX2Fk ZHIgLSByZXR1cm4gdGhlIGFkZHJlc3Mgb2YgdGhlIHJvb3QgZGlyZWN0b3J5Cj4gICAgKgo+IEBA IC0zNSwxMyArNjcsMTQgQEAgdWludDY0X3QgYW1kZ3B1X2dtY19wZF9hZGRyKHN0cnVjdCBhbWRn cHVfYm8gKmJvKQo+ICAgCXN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2ID0gYW1kZ3B1X3R0bV9h ZGV2KGJvLT50Ym8uYmRldik7Cj4gICAJdWludDY0X3QgcGRfYWRkcjsKPgo+IC0JcGRfYWRkciA9 IGFtZGdwdV9ib19ncHVfb2Zmc2V0KGJvKTsKPiAgIAkvKiBUT0RPOiBtb3ZlIHRoYXQgaW50byBB U0lDIHNwZWNpZmljIGNvZGUgKi8KPiAgIAlpZiAoYWRldi0+YXNpY190eXBlID49IENISVBfVkVH QTEwKSB7Cj4gICAJCXVpbnQ2NF90IGZsYWdzID0gQU1ER1BVX1BURV9WQUxJRDsKPgo+IC0JCWFt ZGdwdV9nbWNfZ2V0X3ZtX3BkZShhZGV2LCAtMSwgJnBkX2FkZHIsICZmbGFncyk7Cj4gKwkJYW1k Z3B1X2dtY19nZXRfcGRlX2Zvcl9ibyhibywgLTEsICZwZF9hZGRyLCAmZmxhZ3MpOwo+ICAgCQlw ZF9hZGRyIHw9IGZsYWdzOwo+ICsJfSBlbHNlIHsKPiArCQlwZF9hZGRyID0gYW1kZ3B1X2JvX2dw dV9vZmZzZXQoYm8pOwo+ICAgCX0KPiAgIAlyZXR1cm4gcGRfYWRkcjsKPiAgIH0KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dtYy5oIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dtYy5oCj4gaW5kZXggN2M0NjljY2UwNDk4Li4wZDJj OWY2NWNhMTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X2dtYy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2dtYy5oCj4g QEAgLTEzMSw2ICsxMzEsOCBAQCBzdGF0aWMgaW5saW5lIGJvb2wgYW1kZ3B1X2dtY192cmFtX2Z1 bGxfdmlzaWJsZShzdHJ1Y3QgYW1kZ3B1X2dtYyAqZ21jKQo+ICAgCXJldHVybiAoZ21jLT5yZWFs X3ZyYW1fc2l6ZSA9PSBnbWMtPnZpc2libGVfdnJhbV9zaXplKTsKPiAgIH0KPgo+ICt2b2lkIGFt ZGdwdV9nbWNfZ2V0X3BkZV9mb3JfYm8oc3RydWN0IGFtZGdwdV9ibyAqYm8sIGludCBsZXZlbCwK PiArCQkJICAgICAgIHVpbnQ2NF90ICphZGRyLCB1aW50NjRfdCAqZmxhZ3MpOwo+ICAgdWludDY0 X3QgYW1kZ3B1X2dtY19wZF9hZGRyKHN0cnVjdCBhbWRncHVfYm8gKmJvKTsKPgo+ICAgI2VuZGlm Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+IGluZGV4IGViMDhhMDNi ODJhMC4uNzIzNjY2NDNlM2MyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV90dG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV90dG0uYwo+IEBAIC0xNDI4LDEzICsxNDI4LDE0IEBAIGJvb2wgYW1kZ3B1X3R0bV90dF9pc19y ZWFkb25seShzdHJ1Y3QgdHRtX3R0ICp0dG0pCj4gICB9Cj4KPiAgIC8qKgo+IC0gKiBhbWRncHVf dHRtX3R0X3B0ZV9mbGFncyAtIENvbXB1dGUgUFRFIGZsYWdzIGZvciB0dG1fdHQgb2JqZWN0Cj4g KyAqIGFtZGdwdV90dG1fdHRfcGRlX2ZsYWdzIC0gQ29tcHV0ZSBQREUgZmxhZ3MgZm9yIHR0bV90 dCBvYmplY3QKPiAgICAqCj4gICAgKiBAdHRtOiBUaGUgdHRtX3R0IG9iamVjdCB0byBjb21wdXRl IHRoZSBmbGFncyBmb3IKPiAgICAqIEBtZW06IFRoZSBtZW1vcnkgcmVnaXN0cnkgYmFja2luZyB0 aGlzIHR0bV90dCBvYmplY3QKPiArICoKPiArICogRmlndXJlIG91dCB0aGUgZmxhZ3MgdG8gdXNl IGZvciBhIFZNIFBERS4KPiAgICAqLwo+IC11aW50NjRfdCBhbWRncHVfdHRtX3R0X3B0ZV9mbGFn cyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgc3RydWN0IHR0bV90dCAqdHRtLAo+IC0JCQkJ IHN0cnVjdCB0dG1fbWVtX3JlZyAqbWVtKQo+ICt1aW50NjRfdCBhbWRncHVfdHRtX3R0X3BkZV9m bGFncyhzdHJ1Y3QgdHRtX3R0ICp0dG0sIHN0cnVjdCB0dG1fbWVtX3JlZyAqbWVtKQo+ICAgewo+ ICAgCXVpbnQ2NF90IGZsYWdzID0gMDsKPgo+IEBAIC0xNDQ4LDYgKzE0NDksMjAgQEAgdWludDY0 X3QgYW1kZ3B1X3R0bV90dF9wdGVfZmxhZ3Moc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0 cnVjdCB0dG1fdHQgKnR0bSwKPiAgIAkJCWZsYWdzIHw9IEFNREdQVV9QVEVfU05PT1BFRDsKPiAg IAl9Cj4KPiArCXJldHVybiBmbGFnczsKPiArfQo+ICsKPiArLyoqCj4gKyAqIGFtZGdwdV90dG1f dHRfcHRlX2ZsYWdzIC0gQ29tcHV0ZSBQVEUgZmxhZ3MgZm9yIHR0bV90dCBvYmplY3QKPiArICoK PiArICogQHR0bTogVGhlIHR0bV90dCBvYmplY3QgdG8gY29tcHV0ZSB0aGUgZmxhZ3MgZm9yCj4g KyAqIEBtZW06IFRoZSBtZW1vcnkgcmVnaXN0cnkgYmFja2luZyB0aGlzIHR0bV90dCBvYmplY3QK PiArICovCj4gK3VpbnQ2NF90IGFtZGdwdV90dG1fdHRfcHRlX2ZsYWdzKHN0cnVjdCBhbWRncHVf ZGV2aWNlICphZGV2LCBzdHJ1Y3QgdHRtX3R0ICp0dG0sCj4gKwkJCQkgc3RydWN0IHR0bV9tZW1f cmVnICptZW0pCj4gK3sKPiArCXVpbnQ2NF90IGZsYWdzID0gYW1kZ3B1X3R0bV90dF9wZGVfZmxh Z3ModHRtLCBtZW0pOwo+ICsKPiAgIAlmbGFncyB8PSBhZGV2LT5nYXJ0LmdhcnRfcHRlX2ZsYWdz Owo+ICAgCWZsYWdzIHw9IEFNREdQVV9QVEVfUkVBREFCTEU7Cj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5oIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X3R0bS5oCj4gaW5kZXggOGIzY2M2Njg3NzY5Li5mZThmMjc2ZTk4MTEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5oCj4gQEAgLTExNiw2 ICsxMTYsNyBAQCBib29sIGFtZGdwdV90dG1fdHRfdXNlcnB0cl9pbnZhbGlkYXRlZChzdHJ1Y3Qg dHRtX3R0ICp0dG0sCj4gICAJCQkJICAgICAgIGludCAqbGFzdF9pbnZhbGlkYXRlZCk7Cj4gICBi b29sIGFtZGdwdV90dG1fdHRfdXNlcnB0cl9uZWVkc19wYWdlcyhzdHJ1Y3QgdHRtX3R0ICp0dG0p Owo+ICAgYm9vbCBhbWRncHVfdHRtX3R0X2lzX3JlYWRvbmx5KHN0cnVjdCB0dG1fdHQgKnR0bSk7 Cj4gK3VpbnQ2NF90IGFtZGdwdV90dG1fdHRfcGRlX2ZsYWdzKHN0cnVjdCB0dG1fdHQgKnR0bSwg c3RydWN0IHR0bV9tZW1fcmVnICptZW0pOwo+ICAgdWludDY0X3QgYW1kZ3B1X3R0bV90dF9wdGVf ZmxhZ3Moc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0cnVjdCB0dG1fdHQgKnR0bSwKPiAg IAkJCQkgc3RydWN0IHR0bV9tZW1fcmVnICptZW0pOwo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X3ZtLmMKPiBpbmRleCBkN2VjYmViMmY4YTQuLmM5NTFlYmVhYzVmZCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4gQEAgLTk5Miw5ICs5OTIsNyBA QCBzdGF0aWMgdm9pZCBhbWRncHVfdm1fdXBkYXRlX3BkZShzdHJ1Y3QgYW1kZ3B1X3B0ZV91cGRh dGVfcGFyYW1zICpwYXJhbXMsCj4gICAJCXBibyA9IHBiby0+cGFyZW50Owo+Cj4gICAJbGV2ZWwg Kz0gcGFyYW1zLT5hZGV2LT52bV9tYW5hZ2VyLnJvb3RfbGV2ZWw7Cj4gLQlwdCA9IGFtZGdwdV9i b19ncHVfb2Zmc2V0KGVudHJ5LT5iYXNlLmJvKTsKPiAtCWZsYWdzID0gQU1ER1BVX1BURV9WQUxJ RDsKPiAtCWFtZGdwdV9nbWNfZ2V0X3ZtX3BkZShwYXJhbXMtPmFkZXYsIGxldmVsLCAmcHQsICZm bGFncyk7Cj4gKwlhbWRncHVfZ21jX2dldF9wZGVfZm9yX2JvKGVudHJ5LT5iYXNlLmJvLCBsZXZl bCwgJnB0LCAmZmxhZ3MpOwo+ICAgCXBkZSA9IChlbnRyeSAtIHBhcmVudC0+ZW50cmllcykgKiA4 Owo+ICAgCWlmIChiby0+c2hhZG93KQo+ICAgCQlwYXJhbXMtPmZ1bmMocGFyYW1zLCBiby0+c2hh ZG93LCBwZGUsIHB0LCAxLCAwLCBmbGFncyk7Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hbWQtZ2Z4Cg==