Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kaZ9s-0004iq-S2 for mharc-qemu-trivial@gnu.org; Thu, 05 Nov 2020 01:54:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaZ9n-0004hG-S1; Thu, 05 Nov 2020 01:54:07 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaZ9l-0002lJ-A9; Thu, 05 Nov 2020 01:54:03 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CRZ4J30Cgzhffp; Thu, 5 Nov 2020 14:53:52 +0800 (CST) Received: from [10.174.187.138] (10.174.187.138) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Thu, 5 Nov 2020 14:53:48 +0800 Message-ID: <5FA3A17C.30108@huawei.com> Date: Thu, 5 Nov 2020 14:53:48 +0800 From: AlexChen User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: , , Laurent Vivier CC: , , , Subject: Re: [PATCH 1/2] plugins: Fix resource leak in connect_socket() References: <5F9975E7.6030509@huawei.com> In-Reply-To: <5F9975E7.6030509@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.187.138] X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.191; envelope-from=alex.chen@huawei.com; helo=szxga05-in.huawei.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 01:50:51 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2020 06:54:08 -0000 Kindly ping. On 2020/10/28 21:45, AlexChen wrote: > Close the fd when connect() fails. > > Reported-by: Euler Robot > Signed-off-by: AlexChen > --- > contrib/plugins/lockstep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c > index a696673dff..319bd44b83 100644 > --- a/contrib/plugins/lockstep.c > +++ b/contrib/plugins/lockstep.c > @@ -292,6 +292,7 @@ static bool connect_socket(const char *path) > > if (connect(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr)) < 0) { > perror("failed to connect"); > + close(fd); > return false; > } >