From: "cron2 (Code Review)" Date: Fri, 22 Aug 2025 20:56:15 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <5a388d6bdd39433a8e37c4040a1421170bfe4084-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="09gOtoMn698="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: options: Fix --hash-size virtual argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --09gOtoMn698= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1149?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: options: Fix --hash-size virtual argument ...................................................................... options: Fix --hash-size virtual argument Previously we ignored the second argument to --hash-size. This bug is older than the openvpn git repository, but clearly this is not an option often used (or at all). Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20250822205223.3492-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32= 658.html Signed-off-by: Gert Doering --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/49/1149/2 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 5f9971c..e9584a8 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -7951,7 +7951,7 @@ goto err; } options->real_hash_size =3D real; - options->virtual_hash_size =3D real; + options->virtual_hash_size =3D virtual; } else if (streq(p[0], "connect-freq") && p[1] && p[2] && !p[3]) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1149?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ibec7ffb9085503f72e79514776042bc310384f13 Gerrit-Change-Number: 1149 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --09gOtoMn698= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #2 to the change originally cr= eated by flichtenheld.

View Change

The following approvals got outd= ated and were removed: Code-Review+2 by cron2

options: Fix --hash-size virtual argument

Pre= viously we ignored the second argument to --hash-size.
This bug is older= than the openvpn git repository, but
clearly this is not an option ofte= n used (or at all).

Change-Id: Ibec7ffb9085503f72e79514776042bc31038= 4f13
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Acked-= by: Gert Doering <gert@...1296...>
Message-Id: <20250822205223.= 3492-1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn-dev= el@lists.sourceforge.net/msg32658.html
Signed-off-by: Gert Doering <g= ert@...1296...>
---
M src/openvpn/options.c
1 file changed, 1 i= nsertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:2941=
8/openvpn refs/changes/49/1149/2
diff --git a/src/openvpn/options.c=
 b/src/openvpn/options.c
index 5f9971c..e9584a8 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/o= ptions.c
@@ -7951,7 +7951,7 @@
= goto err;
}
options->= real_hash_size =3D real;
+ options->virtual_hash_size =3D vi= rtual;
}
else if (streq(p[0], &qu= ot;connect-freq") && p[1] && p[2] && !p[3])
{

To view, visit change 1149= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibec7ffb9085503f72e795147760= 42bc310384f13
Gerrit-Change-Number: 1149
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--09gOtoMn698=--