Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7B8AC67871 for ; Tue, 25 Oct 2022 01:29:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB88A806F6; Tue, 25 Oct 2022 03:29:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bvMiWb/8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 206E2806F6; Tue, 25 Oct 2022 03:29:52 +0200 (CEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2077.outbound.protection.outlook.com [40.107.247.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 07A5383F5C for ; Tue, 25 Oct 2022 03:29:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hhp7luAmUbQqVjXGqKCG+HuSV3so9xino+2sjX8wpSv4WxjB9dxK+t0/6DMzMT8GrAt9pe+7dJN9ah5dlBtmYblhOyN+0unPKJwFDYqgT2ck94JYX+x3PqtwtdzVAw1OYBQ3soB34WhMT1tLy40Ni9OxOsb4JOAycPJt0acue9bn6+NPIZIE3UG1bInKX9ZuCzBJ5gClwvsGTX2JWx9DKY7zxLle7kkRR58id9cxFzVJAsayro4vULsNmytDntwCNRiSWFduQ+RJ+KkmoJ1VjqYMSds1XDc9dkrwS+u0vAQ2opdWceUBQ/PbCD5mIXh1xQSX/UbfEb3ZE3dPZspmiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=78+/3Wa1OjxCg3HG8rRAyC8xmE6mqb0fxdU+ltjDvwE=; b=k/DejI1m9Rc0W3+fAveeaSH4cesY1bcejeqUcUqXIbeOBamzdMjBYBl/ZWpVMeUR4BzfTZRuVWQW4jD1UJDIoH5vNomdRhwYEK4hlo56BvTaTFKHGyPtIQLaw5WlW1sPW+1rPmquUQ43aJMihPdRk1GMh8mcFgPwehurJvAGylr49lJ0XaeB/WLWfNGdpIzYdDmMbi7/26PIMdOiFqC/sZjgguiGXPI/0ASOvepxTGOZ++tMVSThxCSpN3FnSeYffIB8uW5d1DEUhKazAkLSQUOv808oRjQCi2eq9oa1RNPXCqWVQp0mcTPX8YgQZsgn3uFnvWCqOoJBcCHZfhzQ6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=78+/3Wa1OjxCg3HG8rRAyC8xmE6mqb0fxdU+ltjDvwE=; b=bvMiWb/8eJixWrMiqOX7fw+L/ZVksoMHc9aYI73xh8TXpXdydBjNYFQZ8DpYW2604di3j3ajarF5nHl9bhcd9fn3wRpbUmJdcwfBmoBZi6mS9M+OMJshfcCruIhhZ8Zznj993V7TIfxhMJ5Z2ZVEKvIWioryFhxRfd0kSp1LffY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PAXPR04MB8703.eurprd04.prod.outlook.com (2603:10a6:102:21e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 01:29:47 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::1587:379:da06:2f18]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::1587:379:da06:2f18%5]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022 01:29:47 +0000 Message-ID: <5a92df44-5058-a265-5f60-e118548fd87a@oss.nxp.com> Date: Tue, 25 Oct 2022 09:29:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [PATCH 1/3] imx: imx8mm_beacon: Eliminate a few extras to free up SPL space Content-Language: en-US To: Tim Harvey , Adam Ford Cc: u-boot@lists.denx.de, sbabic@denx.de, Fabio Estevam , "NXP i.MX U-Boot Team" References: <20221022142825.55155-1-aford173@gmail.com> From: Peng Fan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR04CA0001.apcprd04.prod.outlook.com (2603:1096:4:197::12) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PAXPR04MB8703:EE_ X-MS-Office365-Filtering-Correlation-Id: 20fdd166-22ad-499a-f776-08dab62866ae X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gX0R/KekPEj6xQmB+cZ2Ab5yyRA4ShI2qdFmDtEPnpb7nGC6TtKkfO39Flo0EOq96lpSffxuJ/tKWIB+g5otIbJyIgLbGSiiyoOju5LfbbLwceVLTKt1fzmyT3+Id/s9SGMCQzVCawphlzqg65INlqftoCI/+3xwGNbOx/g1CWXiFqwapJlL3jec1JEMNQWt+/suJNx5ew1pKkMDQIOL5fD7BHRamtGUvzZK1yU1F5n4wOQlh4il0hLf6HRLOFlFWUWctdSwU+I816ct3B4mv8XENDzvVczMsH4nwj4iI/9E+hQmy4bpOdjJ/iTKimr09vhSm06cdmzYjUTOxhHu2JGGPfSJgicdmHGiC2GW4o5dQdsJ+lJVph1+Gs4gnHx4TmkMQ+ndlkvnV+OAVTd56iAgoPnomQxuf0u99os4AOAHXYDqkaSnYmyayOwijMfhGqzJ7FsmKV411ezpCkJ2cfYGPo3P0EbPcL4I22VNbsHjA42e+bFgUg7a3XUCa1CTMgzboiFZ0Ou/bdk+YB6cXUgWDZHhkY7CpufEhAUCFE+iyTPS6iBmVtCRReJJuOnZvPyzOMXK+FQcBLYXuBFyCd+UGbHfnRI0FQG+MCKmCOqzG3x/vA63R51ZA2qVetexSL2/3sltXXJ+ng82Kls/yaenXiaGKDKNjuadzip6tKPKVZNENOFS/la4LOEgQxY4SmmCsRyScmpFzviKYizsHN606Mj/h69IPQmtlzaDtrBYKPAZURk91CGGIOfYWgHE4lXeLv8XA0fT2RBUXZaT4wB/e4NbYyTOMezLJur9+M34Nhpjl4PPSXWAdSNSy4DIX5LqvQCQEIZpBqojETR+TQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(136003)(396003)(39860400002)(366004)(451199015)(31696002)(86362001)(31686004)(38100700002)(38350700002)(2906002)(44832011)(2616005)(6666004)(478600001)(6506007)(53546011)(52116002)(6512007)(26005)(186003)(110136005)(6486002)(54906003)(316002)(66946007)(66556008)(66476007)(8676002)(4326008)(5660300002)(41300700001)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aS92bnB0ZWZ4OHY1cEpWVmtVTVpLWjZlbTB1NmM3VFZMdVUycjZkMWlINklV?= =?utf-8?B?c3l3ZDR0bXU0UE4vUjN0SmM2Zzg5NjVEbTU2ZHJzcjdaSktEQVVFeDFIcW5U?= =?utf-8?B?cHgzU3pyWGFESmROSnFST1FOamFFTlNpdFArcnpkTWNHRmJPbG1ycTFaYko2?= =?utf-8?B?bGdRQU51OUNEeXYwQjFpQlNTc3N3NUNhRXRjRklWTFdXVW5LQzk3cDdSQ3ow?= =?utf-8?B?QURKd29xMkVwYTlrTkt1ZWdhWHZOaU5VcHJVSU1YYmU2RDh3RHB5cnNDYmc2?= =?utf-8?B?T21tZ2NOSXhrS0lMd0p6cytBeHF4WlZwM09wTi9ieFZzR0dDNmFmMSt5QmF1?= =?utf-8?B?UW1Mb0RmeUhrLzRsUmZOUEhRNk5tc3BiaGZCTTl1RUMxTzAvNmd2MXRZZUJk?= =?utf-8?B?Zmh2V3d4NFlkcHpySkdRMUZMSHFqVU85eC9WcWp4SHNib2NhWVlSQWl3Q1hO?= =?utf-8?B?c1hQSmdGZVdNOHptYTUxVkhFR1pERzR2T09UenRvcEFTZ2FhcGR5endLMitu?= =?utf-8?B?ajNOVkxIcXQ4RUVkUzQvbFMwNkl1cFJnelVINjA3R2l1SDNlODF5NVdwZVM2?= =?utf-8?B?TWg1ZTZkUVlzWWtiWGNvaEhHZUQvaThjb3BVRjNIMzJEMmlHZWpLK0ZSaktR?= =?utf-8?B?dFd0Tis2Zk42VzZaR21hU2xuWFJoRDJzL2pGWGIvZGJ2bGx4NTgzN1h3UXJT?= =?utf-8?B?VDkxUXE4VTZNWUY3b0lTUFhvVGRMSkVKNERSUlloR2Nibm02aldiRXBrcHJk?= =?utf-8?B?bGFDZ3BtNTBFQWczYWZSWVlMbU9aVm51dzVRVzNMV3ZtdUM5U21HclYyUkl6?= =?utf-8?B?dGZpZldnSHIzWkpCSDRHLzEwUUFMY3A4Z3dVN09iRmgyWm1wWWZ1RGtsaUpo?= =?utf-8?B?TEl3aTdXb1l1QWp3RzNrb2U5TVRKMjI4ejFVTTVldVdlbDY3UVdqU1I2RGQy?= =?utf-8?B?NUdPZGdNVDdHdFFNamlpdWMzZVJqbGZiVW9uT3lpWkZnRTYwUWNHSWNsYlkz?= =?utf-8?B?K0lES3VJQStWdjZmUGpuM0NuWUN0bGJMVUphcUU3OUhDekdHa0VuQ1hxcVFM?= =?utf-8?B?YW9yb3JDV0FNT2p0OUFPV3YxejIvSzFiQ3ZxVVhwaEtNWkRFS2taUDZIdnAx?= =?utf-8?B?ODkwRzJOZWk0VFBySGVBbjN6TDhCbWp0TmtYalFOU0c2blVYclI2R0RwVkVx?= =?utf-8?B?RDJjZTdhVStGdFd0YUkrWDlGZFF0S2pCVFdkN3N1TTFQNXpkeTJ0bm5SYjlH?= =?utf-8?B?MW5VZ3dxZVlONVFBRlV2Y3BqSm5jRWJiKzk5TTd1YnJka0ZHTGhQUXdkTU90?= =?utf-8?B?blNWLzM3NTR6VXlCZ3V1M2I4NlVwb2YzT2hzQzdBeDBHRit3MVVLRmhnb0M5?= =?utf-8?B?VWQ4TGNIYk5JSGxFcUExZDRMbUlZeXkzdHB0bE5LWEIvcFVJVXR5aFMvQU5C?= =?utf-8?B?a1Y2RERSZ3dLQkZYOXRxaHowRTB0QkZXbEJrdXFrcGRidklGS2Z1SEVhdmtS?= =?utf-8?B?NFk3cmN1blpGb1hvNTBVNFFaSk0vR1g5NGJleXJ2bXpMU3Q4NktqNXBxSTFT?= =?utf-8?B?SjdwbTBHb0g0ZlI2SGdhSGREMTFSdGJqMUo1UzFKR2FaWVgzZHI1R0M1aXZB?= =?utf-8?B?ZXBDYmUrVndtbTZRcXJ4dVBralF2RFN4RmZNMmIwb2M3Z2tBNWh4QzFmUitw?= =?utf-8?B?dE8xcWZHWFdNRzl6K203QmgrczJwdkozUGlVc2lIYURGNVRIT0NvWDMreGFY?= =?utf-8?B?L0I1UVU0MHkxY0VhMUZYWDBBZnI0QjUvUG5WL3Z1M1RHRHk2UGRrdEw3TERm?= =?utf-8?B?K29xSDYrcWc2Ull0TXlqM1o1bEJNN0U5a09lT3ZaR3l0eUtHM3Mzc1d3UTNp?= =?utf-8?B?ZDBDcDljblNmc3RoZ2tCK0NRbjNXUkJXK3dsOHdwWkh3cHozbzAveWFxQWx2?= =?utf-8?B?L1JSMDZYMnoyekt0b0dJd1ZnYmZsdUpKZVlGRTFEcWFVTVUyRjZXSmlIa1RR?= =?utf-8?B?MklRb1lEamIvdG52OEh6YkdHZXVVNFJXeVlqcHVDeFNUMXpPeXI1Tkg1WTM2?= =?utf-8?B?RmFJbm01TFJEYUxlZjd3bFpVTGhXZFJjZGtYa3ZUaWU2TFV0YjZjb1N0S0xE?= =?utf-8?Q?6SiucoHTY72HMSVQ+DpBnkMjT?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20fdd166-22ad-499a-f776-08dab62866ae X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 01:29:47.2473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EhGPugMrVyY/9FF8oz9gewMAbOOm49MC9C4MQp9zwsSoASoSFEfCJKKFegFt9CzNbEoKLdILYgO/G35MGUr01g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8703 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/25/2022 4:47 AM, Tim Harvey wrote: > On Mon, Oct 24, 2022 at 1:26 PM Adam Ford wrote: >> >> On Mon, Oct 24, 2022 at 2:57 PM Tim Harvey wrote: >>> >>> On Sat, Oct 22, 2022 at 7:28 AM Adam Ford wrote: >>>> >>>> There are a few functions which are not essential for use in >>>> SPL, but they take up enough space to make other preferred >>>> features not fit. Remove the extras. >>>> >>>> Signed-off-by: Adam Ford >>>> >>>> diff --git a/board/beacon/imx8mm/spl.c b/board/beacon/imx8mm/spl.c >>>> index a93cc93878..b0e9d918da 100644 >>>> --- a/board/beacon/imx8mm/spl.c >>>> +++ b/board/beacon/imx8mm/spl.c >>>> @@ -44,11 +44,6 @@ static void spl_dram_init(void) >>>> ddr_init(&dram_timing); >>>> } >>>> >>>> -void spl_board_init(void) >>>> -{ >>>> - debug("Normal Boot\n"); >>>> -} >>>> - >>>> #ifdef CONFIG_SPL_LOAD_FIT >>>> int board_fit_config_name_match(const char *name) >>>> { >>>> diff --git a/configs/imx8mm_beacon_defconfig b/configs/imx8mm_beacon_defconfig >>>> index e37ce01c19..f6a1012d8a 100644 >>>> --- a/configs/imx8mm_beacon_defconfig >>>> +++ b/configs/imx8mm_beacon_defconfig >>>> @@ -29,7 +29,6 @@ CONFIG_DEFAULT_FDT_FILE="imx8mm-beacon-kit.dtb" >>>> CONFIG_SPL_HAS_BSS_LINKER_SECTION=y >>>> CONFIG_SPL_BSS_START_ADDR=0x910000 >>>> CONFIG_SPL_BSS_MAX_SIZE=0x2000 >>>> -CONFIG_SPL_BOARD_INIT=y >>>> # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set >>>> CONFIG_SPL_STACK=0x920000 >>>> CONFIG_SYS_SPL_MALLOC=y >>>> @@ -88,12 +87,9 @@ CONFIG_DM_PCA953X=y >>>> CONFIG_DM_I2C=y >>>> CONFIG_SUPPORT_EMMC_BOOT=y >>>> CONFIG_MMC_IO_VOLTAGE=y >>>> -CONFIG_SPL_MMC_IO_VOLTAGE=y >>>> CONFIG_MMC_UHS_SUPPORT=y >>>> -CONFIG_SPL_MMC_UHS_SUPPORT=y >>>> CONFIG_MMC_HS400_ES_SUPPORT=y >>>> CONFIG_MMC_HS400_SUPPORT=y >>>> -CONFIG_SPL_MMC_HS400_SUPPORT=y >>>> CONFIG_FSL_USDHC=y >>>> CONFIG_MTD=y >>>> CONFIG_DM_MTD=y >>>> @@ -113,14 +109,12 @@ CONFIG_PINCTRL_IMX8M=y >>>> CONFIG_POWER_DOMAIN=y >>>> CONFIG_IMX8M_POWER_DOMAIN=y >>>> CONFIG_DM_PMIC=y >>>> +# CONFIG_SPL_PMIC_CHILDREN is not set >>>> CONFIG_DM_PMIC_BD71837=y >>>> CONFIG_SPL_DM_PMIC_BD71837=y >>>> CONFIG_DM_REGULATOR=y >>>> -CONFIG_SPL_DM_REGULATOR=y >>>> CONFIG_DM_REGULATOR_BD71837=y >>>> -CONFIG_SPL_DM_REGULATOR_BD71837=y >>>> CONFIG_DM_REGULATOR_FIXED=y >>>> -CONFIG_SPL_DM_REGULATOR_FIXED=y >>>> CONFIG_DM_REGULATOR_GPIO=y >>>> CONFIG_DM_SERIAL=y >>>> CONFIG_MXC_UART=y >>>> -- >>>> 2.34.1 >>>> >>> >>> Adam, >>> >>> I'm looking at your patches as I'm also trying to strip down the >>> imx8mm-venice SPL so that I can fit DM USB support. It seems that >>> all/most of the imx8m boards have a spl_board_init() which calls >>> arch_misc_init(). I'm curious why your not calling that function? >> >> As of right now, we're not using the CAAM which is initialized in >> arch_misc_init. If/When we do, we'll likely have to pull that in. >> > > ok - makes sense. > >>> >>> Another config that I've found to save a lot of space for imx8m >>> without any negative impact I can see is CONFIG_SPL_MMC_TINY=y >> >> I experimented a bit with that too, but I hadn't fully tested >> switching between booting between MMC1 and MMC2, so I wasn't quite >> ready to enable it, but I'll spend some more time with it to see how >> much more space I can shave off SPL. >> Getting rid of the PMIC children in SPL helped me quite a bit. > > I see. It appears to save about 2K and Fabio's imx8mm clk reduction > series that made it in saves another 800 bytes or so. > > Regardless I'm still oversize for imx8mm-venice by 2K bytes and > looking for things to prune. My issue is that I have 4 DRAM configs to > support which suck up 3K each I believe. Why has so many DRAM configs? Use one image to support multiple boards? Regards, Peng. > > Tim