From: "cron2 (Code Review)" Date: Mon, 22 Jan 2024 08:28:25 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <5b21c6bc1021852d6d3cb0dc5bdf067a96ae5fc9-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="e/13bG+I2Ys="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: --http-proxy-user-pass: allow to specify in either order with --http-... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --e/13bG+I2Ys= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/499?usp=3Demail ) Change subject: --http-proxy-user-pass: allow to specify in either order wi= th --http-proxy ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I think this is a reasonable change - it ensures config consistency, and th= e code looks good (not tested). The compile fails have been spurious and w= ent away on re-run. I'm not sure yet if this should go to 2.6 as well, though. Maybe, because = "fixing inconsistent behaviour =3D bugfix", and "not very intrusive"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/499?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6f402db2fb73f1206fbc1139c47d2bf4378376fa Gerrit-Change-Number: 499 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 22 Jan 2024 08:28:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --e/13bG+I2Ys= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 1:Code-Review +2=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      I think this is a reasonable change - it ensur= es config consistency, and the code looks good (not tested). The compile f= ails have been spurious and went away on re-run.

      I'm not sure yet if this should go = to 2.6 as well, though. Maybe, because "fixing inconsistent behaviour= =3D bugfix", and "not very intrusive"?

  • To view, visit change 499. To unsubscribe, or for help writing mail filter= s, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I6f402db2fb73f1206fbc1139c47= d2bf4378376fa
    Gerrit-Change-Number: 499
    Gerrit-PatchSet: 1
    Gerrit-Owner: flichtenheld <frank@...2723...= .>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Mon, 22 Jan 2024 08:28:25= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --e/13bG+I2Ys=--