From: "cron2 (Code Review)" Date: Tue, 14 Apr 2026 16:31:17 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net Message-ID: <5b528ed955946661a44b5bedc9f1748130fde21f-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="EW4imPORq0U="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Log when writing username/password to TLS buffer fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair , plaisthos Cc: openvpn-devel --EW4imPORq0U= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1600?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Log when writing username/password to TLS buffer fails ...................................................................... Log when writing username/password to TLS buffer fails Currently we get an unhelpful "Key Method #2 failed" error. Add a more specific warning message. Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1600 Message-Id: <20260414055721.16857-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 604.html Signed-off-by: Gert Doering --- M src/openvpn/ssl.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/00/1600/2 diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 576157d..5868d53 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -2125,10 +2125,12 @@ if (!write_string(buf, up->username, -1)) { + msg(M_WARN, "WARNING: Failed to write auth username to TLS buf= fer"); goto error; } else if (!write_string(buf, up->password, -1)) { + msg(M_WARN, "WARNING: Failed to write auth password to TLS buf= fer"); goto error; } /* save username for auth-token which may get pushed later */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1600?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Gerrit-Change-Number: 1600 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --EW4imPORq0U= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by selvanair.<= /p>

Vi= ew Change

The following approvals got outdated and were removed: Code-Review+2 by plaisthos

Log when writing username/passw=
ord to TLS buffer fails

Currently we get an unhelpful "Key Meth= od #2 failed" error.
Add a more specific warning message.

Ch= ange-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8
Signed-off-by: Selva = Nair <selva.nair@...277...>
Acked-by: Arne Schwabe <arne-openvp= n@...1227...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1600=
Message-Id: <20260414055721.16857-1-gert@...1296...>
URL: http= s://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36604.html<= br>Signed-off-by: Gert Doering <gert@...1296...>
---
M src/open= vpn/ssl.c
1 file changed, 2 insertions(+), 0 deletions(-)

<= pre class=3D"blocks" style=3D"font-family: monospace,monospace; white-space= : pre-wrap;">git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/0= 0/1600/2
diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c<=
br>index 576157d..5868d53 100644
--- a/src/openvpn/ss= l.c
+++ b/src/openvpn/ssl.c
@@ -2125,10 +21= 25,12 @@

if (!write_string(buf, = up->username, -1))
{
+ msg(M_WARN, "WARNING: Failed = to write auth username to TLS buffer");
g= oto error;
}
else if (!wr= ite_string(buf, up->password, -1))
{
= + msg(M_WARN, "= WARNING: Failed to write auth password to TLS buffer");
goto error;
}
= /* save username for auth-token which may get pushed later */

To view, visit change 1600. To unsubscribe, or for h= elp writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9468811fd434e17645957fc1277= 0aa2b9ed98fb8
Gerrit-Change-Number: 1600
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --EW4imPORq0U=--