From: Chris Wilson Subject: Re: [PATCH] drm/i915: support low power watermarks on Ironlake Date: Thu, 23 Dec 2010 12:07:22 +0000 Message-ID: <5b55a1$j23fak@fmsmga002.fm.intel.com> References: <20101221131023.2f94306e@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 2465E9E938 for ; Thu, 23 Dec 2010 04:07:25 -0800 (PST) In-Reply-To: <20101221131023.2f94306e@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 21 Dec 2010 13:10:23 -0800, Jesse Barnes wrote: > This patch actually makes the watermark code even uglier (if that's > possible), but has the advantage of sharing code between SNB and ILK at > least. Longer term we should refactor the watermark stuff into its own > file and clean it up now that we know how it's supposed to work. > > Supporting WM2 on my Vaio reduced power consumption by around 0.5W, so > this patch is definitely worthwhile (though it also needs lots of test > coverage). I tweaked the patch to pass the watermark structs through to the check routine. The box survives s2ram, but I have now also experienced the mysterious slow down after resuming. Pushed to -next for wider testing, -Chris -- Chris Wilson, Intel Open Source Technology Centre