From: Madhav Chauhan Subject: Re: [PATCH v7 13/23] drm/i915/icl: Program TRANS_DDI_FUNC_CTL registers Date: Mon, 22 Oct 2018 16:35:48 +0530 Message-ID: <5b57261e-a0b4-e782-d4d6-cafbc76af266@intel.com> References: <080320dc9a9e321dbe73567c6a7aa1dcff0f21c2.1539613303.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF9BA89BAE for ; Mon, 22 Oct 2018 11:05:50 +0000 (UTC) In-Reply-To: <080320dc9a9e321dbe73567c6a7aa1dcff0f21c2.1539613303.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTAvMTUvMjAxOCA3OjU4IFBNLCBKYW5pIE5pa3VsYSB3cm90ZToKPiBGcm9tOiBNYWRoYXYg Q2hhdWhhbiA8bWFkaGF2LmNoYXVoYW5AaW50ZWwuY29tPgo+Cj4gVGhpcyBwYXRjaCBzZWxlY3Qg aW5wdXQgUElQRSBmb3IgRFNJLCBkYXRhIGxhbmVzIHdpZHRoLAo+IGVuYWJsZSBwb3J0IHN5bmMg bW9kZSBhbmQgd2FpdCBmb3IgRFNJIGxpbmsgdG8gYmVjb21lIHJlYWR5Lgo+Cj4gdjIgYnkgSmFu aToKPiAgIC0gVXNlIE1JU1NJTkdfQ0FTRSB3aXRoIGZhbGx0aHJvdWdoIGluc3RlYWQgb2YgRFJN X0VSUk9SCj4gICAtIG1pbm9yIHN0eWxpc3RpYyBjaGFuZ2VzCgp2MiBjaGFuZ2VzIGFyZSBnb29k LgoKUmVnYXJkcywKTWFkaGF2Cgo+Cj4gU2lnbmVkLW9mZi1ieTogTWFkaGF2IENoYXVoYW4gPG1h ZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFu aS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaWNsX2Rz aS5jIHwgNjQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gICAx IGZpbGUgY2hhbmdlZCwgNjAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pY2xfZHNpLmMKPiBpbmRleCA3NTZjNzVkMGM4NmMuLjg3ZDVlNjQzNTc5MSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pY2xfZHNpLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pY2xfZHNpLmMKPiBAQCAtMzQwLDEwICszNDAsMTQgQEAgc3RhdGljIHZvaWQg Z2VuMTFfZHNpX3NldHVwX2RwaHlfdGltaW5ncyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl cikKPiAgIAl9Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgZ2VuMTFfZHNpX2NvbmZpZ3VyZV90 cmFuc2NvZGVyKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ICtzdGF0aWMgdm9pZAo+ ICtnZW4xMV9kc2lfY29uZmlndXJlX3RyYW5zY29kZXIoc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIsCj4gKwkJCSAgICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9j b25maWcpCj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f aTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gICAJc3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNp ID0gZW5jX3RvX2ludGVsX2RzaSgmZW5jb2Rlci0+YmFzZSk7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0 YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMocGlwZV9jb25maWctPmJhc2UuY3J0Yyk7Cj4g KwllbnVtIHBpcGUgcGlwZSA9IGludGVsX2NydGMtPnBpcGU7Cj4gICAJdTMyIHRtcDsKPiAgIAll bnVtIHBvcnQgcG9ydDsKPiAgIAllbnVtIHRyYW5zY29kZXIgZHNpX3RyYW5zOwo+IEBAIC00MjAs OSArNDI0LDYxIEBAIHN0YXRpYyB2b2lkIGdlbjExX2RzaV9jb25maWd1cmVfdHJhbnNjb2Rlcihz dHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgIAo+ICAgCQlJOTE1X1dSSVRFKERTSV9U UkFOU19GVU5DX0NPTkYoZHNpX3RyYW5zKSwgdG1wKTsKPiAgIAl9Cj4gKwo+ICsJLyogZW5hYmxl IHBvcnQgc3luYyBtb2RlIGlmIGR1YWwgbGluayAqLwo+ICsJaWYgKGludGVsX2RzaS0+ZHVhbF9s aW5rKSB7Cj4gKwkJZm9yX2VhY2hfZHNpX3BvcnQocG9ydCwgaW50ZWxfZHNpLT5wb3J0cykgewo+ ICsJCQlkc2lfdHJhbnMgPSBkc2lfcG9ydF90b190cmFuc2NvZGVyKHBvcnQpOwo+ICsJCQl0bXAg PSBJOTE1X1JFQUQoVFJBTlNfRERJX0ZVTkNfQ1RMMihkc2lfdHJhbnMpKTsKPiArCQkJdG1wIHw9 IFBPUlRfU1lOQ19NT0RFX0VOQUJMRTsKPiArCQkJSTkxNV9XUklURShUUkFOU19ERElfRlVOQ19D VEwyKGRzaV90cmFucyksIHRtcCk7Cj4gKwkJfQo+ICsKPiArCQkvL1RPRE86IGNvbmZpZ3VyZSBE U1NfQ1RMMQo+ICsJfQo+ICsKPiArCWZvcl9lYWNoX2RzaV9wb3J0KHBvcnQsIGludGVsX2RzaS0+ cG9ydHMpIHsKPiArCQlkc2lfdHJhbnMgPSBkc2lfcG9ydF90b190cmFuc2NvZGVyKHBvcnQpOwo+ ICsKPiArCQkvKiBzZWxlY3QgZGF0YSBsYW5lIHdpZHRoICovCj4gKwkJdG1wID0gSTkxNV9SRUFE KFRSQU5TX0RESV9GVU5DX0NUTChkc2lfdHJhbnMpKTsKPiArCQl0bXAgJj0gfkRESV9QT1JUX1dJ RFRIX01BU0s7Cj4gKwkJdG1wIHw9IERESV9QT1JUX1dJRFRIKGludGVsX2RzaS0+bGFuZV9jb3Vu dCk7Cj4gKwo+ICsJCS8qIHNlbGVjdCBpbnB1dCBwaXBlICovCj4gKwkJdG1wICY9IH5UUkFOU19E RElfRURQX0lOUFVUX01BU0s7Cj4gKwkJc3dpdGNoIChwaXBlKSB7Cj4gKwkJZGVmYXVsdDoKPiAr CQkJTUlTU0lOR19DQVNFKHBpcGUpOwo+ICsJCQkvKiBmYWxsdGhyb3VnaCAqLwo+ICsJCWNhc2Ug UElQRV9BOgo+ICsJCQl0bXAgfD0gVFJBTlNfRERJX0VEUF9JTlBVVF9BX09OOwo+ICsJCQlicmVh azsKPiArCQljYXNlIFBJUEVfQjoKPiArCQkJdG1wIHw9IFRSQU5TX0RESV9FRFBfSU5QVVRfQl9P Tk9GRjsKPiArCQkJYnJlYWs7Cj4gKwkJY2FzZSBQSVBFX0M6Cj4gKwkJCXRtcCB8PSBUUkFOU19E RElfRURQX0lOUFVUX0NfT05PRkY7Cj4gKwkJCWJyZWFrOwo+ICsJCX0KPiArCj4gKwkJLyogZW5h YmxlIERESSBidWZmZXIgKi8KPiArCQl0bXAgfD0gVFJBTlNfRERJX0ZVTkNfRU5BQkxFOwo+ICsJ CUk5MTVfV1JJVEUoVFJBTlNfRERJX0ZVTkNfQ1RMKGRzaV90cmFucyksIHRtcCk7Cj4gKwl9Cj4g Kwo+ICsJLyogd2FpdCBmb3IgbGluayByZWFkeSAqLwo+ICsJZm9yX2VhY2hfZHNpX3BvcnQocG9y dCwgaW50ZWxfZHNpLT5wb3J0cykgewo+ICsJCWRzaV90cmFucyA9IGRzaV9wb3J0X3RvX3RyYW5z Y29kZXIocG9ydCk7Cj4gKwkJaWYgKHdhaXRfZm9yX3VzKChJOTE1X1JFQUQoRFNJX1RSQU5TX0ZV TkNfQ09ORihkc2lfdHJhbnMpKSAmCj4gKwkJCQlMSU5LX1JFQURZKSwgMjUwMCkpCj4gKwkJCURS TV9FUlJPUigiRFNJIGxpbmsgbm90IHJlYWR5XG4iKTsKPiArCX0KPiAgIH0KPiAgIAo+IC1zdGF0 aWMgdm9pZCBnZW4xMV9kc2lfZW5hYmxlX3BvcnRfYW5kX3BoeShzdHJ1Y3QgaW50ZWxfZW5jb2Rl ciAqZW5jb2RlcikKPiArc3RhdGljIHZvaWQKPiArZ2VuMTFfZHNpX2VuYWJsZV9wb3J0X2FuZF9w aHkoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gKwkJCSAgICAgIGNvbnN0IHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiAgIHsKPiAgIAkvKiBzdGVwIDRhOiBw b3dlciB1cCBhbGwgbGFuZXMgb2YgdGhlIERESSB1c2VkIGJ5IERTSSAqLwo+ICAgCWdlbjExX2Rz aV9wb3dlcl91cF9sYW5lcyhlbmNvZGVyKTsKPiBAQCAtNDQwLDcgKzQ5Niw3IEBAIHN0YXRpYyB2 b2lkIGdlbjExX2RzaV9lbmFibGVfcG9ydF9hbmRfcGh5KHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl bmNvZGVyKQo+ICAgCWdlbjExX2RzaV9zZXR1cF9kcGh5X3RpbWluZ3MoZW5jb2Rlcik7Cj4gICAK PiAgIAkvKiBTdGVwICg0aCwgNGksIDRqLCA0ayk6IENvbmZpZ3VyZSB0cmFuc2NvZGVyICovCj4g LQlnZW4xMV9kc2lfY29uZmlndXJlX3RyYW5zY29kZXIoZW5jb2Rlcik7Cj4gKwlnZW4xMV9kc2lf Y29uZmlndXJlX3RyYW5zY29kZXIoZW5jb2RlciwgcGlwZV9jb25maWcpOwo+ICAgfQo+ICAgCj4g ICBzdGF0aWMgdm9pZCBfX2F0dHJpYnV0ZV9fKCh1bnVzZWQpKQo+IEBAIC00NTUsNSArNTExLDUg QEAgZ2VuMTFfZHNpX3ByZV9lbmFibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4g ICAJZ2VuMTFfZHNpX3Byb2dyYW1fZXNjX2Nsa19kaXYoZW5jb2Rlcik7Cj4gICAKPiAgIAkvKiBz dGVwNDogZW5hYmxlIERTSSBwb3J0IGFuZCBEUEhZICovCj4gLQlnZW4xMV9kc2lfZW5hYmxlX3Bv cnRfYW5kX3BoeShlbmNvZGVyKTsKPiArCWdlbjExX2RzaV9lbmFibGVfcG9ydF9hbmRfcGh5KGVu Y29kZXIsIHBpcGVfY29uZmlnKTsKPiAgIH0KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=