From: "cron2 (Code Review)" Date: Wed, 8 Apr 2026 12:34:28 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <5b608d7a9ba5daaab1fad39f63fdd9282a92a48e-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZtFVAloBeWE="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --ZtFVAloBeWE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1623?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: openvpnserv: Remove redundant bit-wise operation ...................................................................... openvpnserv: Remove redundant bit-wise operation Found by cppcheck. Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623 Message-Id: <20260407205344.31263-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 547.html Signed-off-by: Gert Doering --- M src/openvpnserv/interactive.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/23/1623/2 diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index c96d3f2..4268214 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -3410,7 +3410,7 @@ ea[0].Trustee.TrusteeForm =3D TRUSTEE_IS_SID; ea[0].Trustee.TrusteeType =3D TRUSTEE_IS_UNKNOWN; ea[0].Trustee.ptstrName =3D (LPWSTR)svc_user->User.Sid; - ea[1].grfAccessPermissions =3D READ_CONTROL | SYNCHRONIZE | PROCESS_VM= _READ | SYNCHRONIZE + ea[1].grfAccessPermissions =3D READ_CONTROL | PROCESS_VM_READ | SYNCHR= ONIZE | PROCESS_TERMINATE | PROCESS_QUERY_INFOR= MATION; ea[1].grfAccessMode =3D SET_ACCESS; ea[1].grfInheritance =3D NO_INHERITANCE; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Gerrit-Change-Number: 1623 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --ZtFVAloBeWE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

openvpnserv: Remove redundant bit-w=
ise operation

Found by cppcheck.

Change-Id: I7f983168c263e49d= a7665fc20bd1ecdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@...1665...= 641...>
Acked-by: Gert Doering <gert@...1296...>
Gerrit URL:= https://gerrit.openvpn.net/c/openvpn/+/1623
Message-Id: <20260407205= 344.31263-1-gert@...1296...>
URL: https://www.mail-archive.com/openvp= n-devel@lists.sourceforge.net/msg36547.html
Signed-off-by: Gert Doering = <gert@...1296...>
---
M src/openvpnserv/interactive.c
1 file= changed, 1 insertion(+), 1 deletion(-)

git pull=
 ssh://gerrit.openvpn.net:29418/openvpn refs/changes/23/1623/2
diff=
 --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index c96d3f2..4268214 100644
--- a/src/openvpn= serv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3410,7 +3410,7 @@
ea[0].Trustee.Truste= eForm =3D TRUSTEE_IS_SID;
ea[0].Trustee.TrusteeType = =3D TRUSTEE_IS_UNKNOWN;
ea[0].Trustee.ptstrName =3D (L= PWSTR)svc_user->User.Sid;
- ea[1].grfAccessPermissions =3D READ_CONTROL | SYNCHRONIZE | PROC= ESS_VM_READ | SYNCHRONIZE
+ ea[1].grfAccessPermissions =3D READ_CONTROL | PROCESS_VM_READ | S= YNCHRONIZE
| PROCESS_TERM= INATE | PROCESS_QUERY_INFORMATION;
ea[1].grfAccessMode= =3D SET_ACCESS;
ea[1].grfInheritance =3D NO_INHERITAN= CE;

To view, visit change 1623. To unsubscr= ibe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7f983168c263e49da7665fc20bd= 1ecdd426c21d0
Gerrit-Change-Number: 1623
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --ZtFVAloBeWE=--