From: "cron2 (Code Review)" Date: Wed, 8 Apr 2026 12:34:30 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <5b608d7a9ba5daaab1fad39f63fdd9282a92a48e-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="LY3RvDTwro4="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --LY3RvDTwro4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/16= 23?usp=3Demail ) Change subject: openvpnserv: Remove redundant bit-wise operation ...................................................................... openvpnserv: Remove redundant bit-wise operation Found by cppcheck. Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1623 Message-Id: <20260407205344.31263-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 547.html Signed-off-by: Gert Doering --- M src/openvpnserv/interactive.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index c96d3f2..4268214 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -3410,7 +3410,7 @@ ea[0].Trustee.TrusteeForm =3D TRUSTEE_IS_SID; ea[0].Trustee.TrusteeType =3D TRUSTEE_IS_UNKNOWN; ea[0].Trustee.ptstrName =3D (LPWSTR)svc_user->User.Sid; - ea[1].grfAccessPermissions =3D READ_CONTROL | SYNCHRONIZE | PROCESS_VM= _READ | SYNCHRONIZE + ea[1].grfAccessPermissions =3D READ_CONTROL | PROCESS_VM_READ | SYNCHR= ONIZE | PROCESS_TERMINATE | PROCESS_QUERY_INFOR= MATION; ea[1].grfAccessMode =3D SET_ACCESS; ea[1].grfInheritance =3D NO_INHERITANCE; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Gerrit-Change-Number: 1623 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --LY3RvDTwro4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

openvpnserv: Remove redundant bit-wise operation=


Found by cppcheck.

Change-Id: I7f983168c263e49da7665fc20bd1e= cdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@...2641...>Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: https://gerr= it.openvpn.net/c/openvpn/+/1623
Message-Id: <20260407205344.31263-1-g= ert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1697...= .sourceforge.net/msg36547.html
Signed-off-by: Gert Doering <gert@...1386...= 296...>
---
M src/openvpnserv/interactive.c
1 file changed, 1 i= nsertion(+), 1 deletion(-)

diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive=
.c
index c96d3f2..4268214 100644
--- a/src/= openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive= .c
@@ -3410,7 +3410,7 @@
ea[0].Trustee= .TrusteeForm =3D TRUSTEE_IS_SID;
ea[0].Trustee.Trustee= Type =3D TRUSTEE_IS_UNKNOWN;
ea[0].Trustee.ptstrName = =3D (LPWSTR)svc_user->User.Sid;
- ea[1].grfAccessPermissions =3D READ_CONTROL | SYNCHRONIZE = | PROCESS_VM_READ | SYNCHRONIZE
+ ea[1].grfAccessPermissions =3D READ_CONTROL | PROCESS_VM_RE= AD | SYNCHRONIZE
| PROCES= S_TERMINATE | PROCESS_QUERY_INFORMATION;
ea[1].grfAcce= ssMode =3D SET_ACCESS;
ea[1].grfInheritance =3D NO_INH= ERITANCE;

To view, visit change 1623. To un= subscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7f983168c263e49da7665fc20bd= 1ecdd426c21d0
Gerrit-Change-Number: 1623
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --LY3RvDTwro4=--