From: Stefan Roese Date: Fri, 4 Sep 2020 06:47:06 +0200 Subject: [PATCH] spl: Avoid printing boot device if silent console is enabled In-Reply-To: <20200903172515.185232-1-otavio@ossystems.com.br> References: <20200903172515.185232-1-otavio@ossystems.com.br> Message-ID: <5b8e409b-87e1-da5a-ca8d-e5f6fe2d2812@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03.09.20 19:25, Otavio Salvador wrote: > Signed-off-by: Otavio Salvador > --- > > common/spl/spl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/common/spl/spl.c b/common/spl/spl.c > index 4840d1d367..63c48fbf33 100644 > --- a/common/spl/spl.c > +++ b/common/spl/spl.c > @@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info *spl_image, > struct spl_image_loader *loader; > > loader = spl_ll_find_loader(spl_boot_list[i]); > -#if defined(CONFIG_SPL_SERIAL_SUPPORT) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) > +#if defined(CONFIG_SPL_SERIAL_SUPPORT) \ > + && defined(CONFIG_SPL_LIBCOMMON_SUPPORT) \ > + && !defined(CONFIG_SILENT_CONSOLE) Nitpicking: I think its preferred to put the "&&" (or "||") at the end of the line. Other than that: Reviewed-by: Stefan Roese Thanks, Stefan