Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 612FBC4453A for ; Wed, 22 Jul 2026 10:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Cc:Reply-To:From: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:References:In-Reply-To:To:Date:Sender: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h+A2+F2dRrNcFhTwjUx8MEp4ZvvF+Kgf5UVS0Z3LXMY=; b=ZJzGx/3A6fxXj+U6kwK6W60uUP 6YEOOOHUa8Q7TR1gGBfta9wLhecDibyjP6NxSic7kjN8k6/qjnKSTIIQ7rBo+7u7mK3CCO+vSlJ7J wyP3/3gDp53mRzdJv8I9VZlWuC0e5NY3a64SQ3ZA+5MMfvA5Oz5W5+8247xGo5dRjF1A=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wmUCo-0006z1-OL; Wed, 22 Jul 2026 10:29:36 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wmUCn-0006yu-D4 for openvpn-devel@lists.sourceforge.net; Wed, 22 Jul 2026 10:29:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:Subject:References:In-Reply-To:List-Unsubscribe:List-Id: Cc:To:Date:From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Help:List-Subscribe :List-Post:List-Owner:List-Archive; bh=DMdxC2Dbyf0mX8h/7PrpEWh9LyOpU1mf0ggXrICqIGQ=; b=Fxs7yCQDqFxOw8UeGqT84dPtEH D+qApSElywsoxSHWPK+b5XJwvQ5Pf3ddARSniMBjYoxScK3S0mVCCCeGZfhQbkCrlaaPOb3USCVhB 37qtQuxtFKuTBgWc4708qha9fmTy6RtOGQYGSwGa/+MI9yCtomusGWUq6BpHWesgzy4c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: Subject:References:In-Reply-To:List-Unsubscribe:List-Id:Cc:To:Date:From: Sender:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=DMdxC2Dbyf0mX8h/7PrpEWh9LyOpU1mf0ggXrICqIGQ=; b=X W6XmnZAVQU5WppJLVv/bJs/1t4pvazt1BuaQNn2uLX61tlua6up6ogaUncg9CeH9gmrwHqQXoR0QS aaycmSuB5v1fTGLRo62lDpef+BfeehhYVRwdl0z5fCXUovprV7zrtkQwEmiToJFNUuaF+TzGAFdwi ug4PMifzEoyvrfH0=; Received: from mail-wm1-f48.google.com ([209.85.128.48]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1wmUCh-0007mt-Hx for openvpn-devel@lists.sourceforge.net; Wed, 22 Jul 2026 10:29:34 +0000 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-495437bb891so49795285e9.1 for ; Wed, 22 Jul 2026 03:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1784716160; x=1785320960; darn=lists.sourceforge.net; h=content-type:user-agent:content-disposition :content-transfer-encoding:mime-version:message-id:reply-to:subject :thread-index:references:in-reply-to:list-unsubscribe:list-id :auto-submitted:cc:to:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=DMdxC2Dbyf0mX8h/7PrpEWh9LyOpU1mf0ggXrICqIGQ=; b=AnUgfVKWUMIFpDAfMHwcCP8LUFZOsU4s9IInXaYiGOhLrmpI1WUfaWOiX0jCJvd26x kDoJ2XP8bvtcs25STH0JLmjXWiLC6sbhD4K+tjjtlYFbgBISfikA+Nr8t7KMwk95x1Up jO4THaPnhtv4uIceulw9SydEe9lfyVG5OVVATsKr6uR2+7fj63NLDAOV9FEkPB9y/Sdj CetukLBks6lAjzKLODvhELMMo6t0tEqFfvylL5BUUJ+wPjyr2b4I4rPq0GAEwWuQjXUK eUd2Fwi1LLEiFJJbGg5OBxDfXZFRHCHMlbnoH47JL2iWmocgN1DvPH7aaWJtJNdI7Ue7 LByw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784716160; x=1785320960; h=content-type:user-agent:content-disposition :content-transfer-encoding:mime-version:message-id:reply-to:subject :thread-index:references:in-reply-to:list-unsubscribe:list-id :auto-submitted:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=DMdxC2Dbyf0mX8h/7PrpEWh9LyOpU1mf0ggXrICqIGQ=; b=mSgRyg7SgOKZlgjnM+JU+aRM7fCBV/2kUe1uQzo2Br1vLyNAPI8G4VR8kjjfNZTkyX mj5MuvES3xfzCf1iE80CzScqGU8MDeOSwLW6KeILty2ZKWb/a+iL2WohuToHRtJCWkFA dF/zW5MnkN1eKIidMYweN9XWFrs4x/dFW8o+dhCX8qBLqw/8ACc5Ig/H2oVB7hqUBDms 7BixLIWbY3HrjGlDiCTxWlt09a9jaST39g98bZSHHTwo2MPSCVglhP6jb7U70ugoOpPC lPeGZj/DjVmy7woCFei+NihvLB5Hat3fFfV3dg8n7rgfhu2bGe9C7R1epk62yxIKmB2C KcrA== X-Gm-Message-State: AOJu0Yz3yoOh7ThNcJntsei4jtvqimvjonuB8dUMNn2evrhdfLaigLdl B3ef/RRKIvMn8Ug3k/EOZF802XTo7RrmO3cznkmW27tyv8IHrADReHYPaxEE1nwBDDZo+Vjbu31 a4oA2yFRcwvB7HbZMixp4nTGc1D067jCaIMcRksy4HECZL9YwtsOW2uZjna3Hbxc+8MXn9sVx1Z ycKpLTCQ== X-Gm-Gg: AR+sD10A6ELpq3/FgH7CZbfRspJEys4YjKSlVZZ/wQMcerkFJCzZbWBdreO2pBLkvd2 XMxGOF+lD/scFeEZGK8clUapnKS1xlQZ2mEj8QKvE7McPhOQyV7CukwLDS5m0LUEyEDbj5PRsef b0Gb0qJZ9Yau99cKPdYLwL7JliJa0Q5BD7k4Pkl7cOYFlp+Iv2kQD1cYlSd7eC/Lvry5pZi99wv sBfXSdpSIgdSfucEsfVDEwO6dAQqJ5IyEL/fLLzFeifo7KeZEZHHzrpAvGRs0nTngW2qJDbQg56 ARc1sCUjcgcRpeFbL9kbKAVZM8PW+yLy2PF5dJe9PQT7RK3NHpbQs32DiP3x4jyh4NnJOI+TZep ICDRQq3otfMOt+hKePZYZGFK0rcl8zrrO+6FrJwQaQDpeF0mwI0cxJ7ul+hkNumg9XG/sTZ6+6B qQE/8YXzYcf7h8eB6fiiJmPwkBaxztGVUhKozfGFyZUhVZpQNu5EIA87D086LKcil22Zv1g/OYF WRNZcSFGG5cL+p+R5YhXvpsjKmtyCDjvDKT/gXBb7bzmbc/Zs072O2jAHMC9dJNeZXG X-Received: by 2002:a05:600c:1f8d:b0:493:ecf5:89fd with SMTP id 5b1f17b1804b1-4956a51ba79mr34102485e9.17.1784716159636; Wed, 22 Jul 2026 03:29:19 -0700 (PDT) Received: from ip-10-18-1-162.eu-central-1.compute.internal (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a63e3a8sm66802485e9.12.2026.07.22.03.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 03:29:19 -0700 (PDT) X-Google-Original-From: "plaisthos (Code Review)" Date: Wed, 22 Jul 2026 10:29:13 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset X-Gerrit-PatchSet: 18 X-Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0 X-Gerrit-Change-Number: 31 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 8c05e8eee38d3fd7354a415ca2a7ebd328afc619 In-Reply-To: References: Thread-Index: PGdlcnJpdC4xNjc3MTc1NjYyMDAwLkkwOWFhMjdjYWExYTNhYWIwZDFiZTYxMThiMjZkNTRhMWMxYmY3YWEwQGdlcnJpdC5vcGVudnBuLm5ldD4= Message-ID: <5bebe467e87348fa1d2f879db1fe482b920de286-EmailReplacePatchSet-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.11.5 X-Headers-End: 1wmUCh-0007mt-Hx Subject: [Openvpn-devel] [L] Change in openvpn[master]: Allow to use OpenSSL's SIPHASH implementation when available X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "plaisthos \(Code Review\) via Openvpn-devel" Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: "plaisthos \(Code Review\)" , openvpn-devel Content-Type: multipart/mixed; boundary="===============2668526237532391113==" Errors-To: openvpn-devel-bounces@lists.sourceforge.net --===============2668526237532391113== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="MhbxW9fhPHo="; charset=UTF-8 --MhbxW9fhPHo= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld=2E Hello flichtenheld, = I'd like you to reexamine a change=2E Please visit http://gerrit=2Eo= penvpn=2Enet/c/openvpn/+/31?usp=3Demail to look at the new patch set (#18)= =2E Change subject: Allow to use OpenSSL's SIPHASH implementation when av= ailable =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Allo= w to use OpenSSL's SIPHASH implementation when available OpenSSL library i= s currently slower than the reference implementation (about 1=2E5x to 2x de= pending of the compiler)=2E The OpenSSL API for using the SIPHASH MAC is d= ifferent enough from using normal HMAC or Digest that we already implement = that combining them into one API does not make sense=2E SIPHASH is only av= ailable on OpenSSL 3=2E1 and later=2E We still check for support on 3=2E0 a= nd later as the whole API to allow using the SIPHASH alrady exists in OpenS= SL 3=2E0=2E Some of the later OpenSSL 3=2E0=2Ex might get support for it=2E= Theoretically, a provider can be loaded in OpenSSL 3=2E0 that implements S= IPHASH=2E With OpenSSL's implementation being slower, we currently only us= e it to check that our reference implementation and the OpenSSL implementat= ion yield the same result in unit tests Change-Id: I09aa27caa1a3aab0d1be61= 18b26d54a1c1bf7aa0 Signed-off-by: Arne Schwabe --- M C= MakeLists=2Etxt M src/openvpn/Makefile=2Eam M src/openvpn/siphash=2Eh A src= /openvpn/siphash_openssl=2Ec M src/openvpn/siphash_reference=2Ec M tests/un= it_tests/openvpn/Makefile=2Eam M tests/unit_tests/openvpn/test_crypto=2Ec 7= files changed, 277 insertions(+), 8 deletions(-) git pull ssh://gerrit= =2Eopenvpn=2Enet:29418/openvpn refs/changes/31/31/18 diff --git a/CMakeLis= ts=2Etxt b/CMakeLists=2Etxt index 7473f15=2E=2E25c3ea5 100644 --- a/CMakeLi= sts=2Etxt +++ b/CMakeLists=2Etxt @@ -572,6 +572,9 @@ src/openvpn/shape= r=2Eh src/openvpn/sig=2Ec src/openvpn/sig=2Eh + src/openvpn/si= phash=2Eh + src/openvpn/siphash_openssl=2Ec + src/openvpn/siphash_ref= erence=2Ec src/openvpn/socket=2Ec src/openvpn/socket=2Eh src= /openvpn/socket_util=2Ec @@ -792,8 +795,12 @@ src/openvpn/packet_i= d=2Ec src/openvpn/mtu=2Ec src/openvpn/mss=2Ec + sr= c/openvpn/siphash_reference=2Ec + src/openvpn/siphash_openssl=2Ec = ) + target_compile_definitions(test_crypto PRIVATE PREFER_OPENS= SL_SIPHASH) + target_sources(test_ssl PRIVATE tests/unit_= tests/openvpn/mock_management=2Ec tests/unit_tests/openvpn/moc= k_ssl_dependencies=2Ec diff --git a/src/openvpn/Makefile=2Eam b/src/openvpn= /Makefile=2Eam index ff8cc54=2E=2E08c8250 100644 --- a/src/openvpn/Makefile= =2Eam +++ b/src/openvpn/Makefile=2Eam @@ -128,6 +128,8 @@ session_id=2Ec = session_id=2Eh \ shaper=2Ec shaper=2Eh \ sig=2Ec sig=2Eh \ + siphash_re= ference=2Ec siphash=2Eh \ + siphash_openssl=2Ec \ socket=2Ec socket=2Eh \= socket_util=2Ec socket_util=2Eh \ socks=2Ec socks=2Eh \ diff --git a/s= rc/openvpn/siphash=2Eh b/src/openvpn/siphash=2Eh index ef61110=2E=2E07b087e= 100644 --- a/src/openvpn/siphash=2Eh +++ b/src/openvpn/siphash=2Eh @@ -18,= 12 +18,67 @@ #ifndef SIPHASH_H #define SIPHASH_H -#include +#include +#include +#include = /* siphash always uses 128-bit keys */ #define SIPHASH_KEY_SIZE 16 -int = siphash(const void *in, size_t inlen, const void *k, uint8_t *out, - = size_t outlen); +/* Prototypes for an implementation of SIPHASH in a c= rypto library */ -#endif +/** + * Calculates SIPHASH using the crypto lib= rary function=2E + */ +int +siphash_cryptolib(void *sip_context, const void= *in, size_t inlen, + const void *k, uint8_t *out, size_t = outlen); + +/** + * Calculates SIPHASH using the reference implementation += */ +int +siphash_reference(const void *in, size_t inlen, const void *k, + = uint8_t *out, size_t outlen); + +/** + * + * @param hash_s= ize the size of the output hash size + * @return initialised context for si= phash + */ +void * +siphash_cryptolib_init(size_t hash_size); + +/** + * Fr= ee the siphash context used for the crypto library + * @param sip_context += */ +void +siphash_cryptolib_uninit(void *sip_context); + +/** + * Returns = if the crypto library is available (and should be used) + * + * This return= s if there is a crypto library version of Siphash24 is + * available and sh= ould be used (OpenSSL 3/4 version is quite slow, so + * we prefer the refer= ence implementation) + * + */ +bool +siphash_cryptolib_available(void *sip_= context); + +static inline int +siphash(void *ctx, const void *in, size_t i= nlen, const void *k, + uint8_t *out, size_t outlen) +{ + if (siph= ash_cryptolib_available(ctx)) + { + return siphash_cryptolib(ctx,= in, inlen, k, out, outlen); + } + else + { + return siphas= h_reference(in, inlen, k, out, outlen); + } +} + +#endif /* ifndef SIPHA= SH_H */ \ No newline at end of file diff --git a/src/openvpn/siphash_openss= l=2Ec b/src/openvpn/siphash_openssl=2Ec new file mode 100644 index 0000000= =2E=2E214b3f4 --- /dev/null +++ b/src/openvpn/siphash_openssl=2Ec @@ -0,0 += 1,145 @@ +/* + * OpenVPN -- An application to securely tunnel IP networks = + * over a single TCP/UDP port, with support for SSL/TLS-based = + * session authentication and key exchange, + * pa= cket encryption, packet authentication, and + * packet compress= ion=2E + * + * Copyright (C) 2002-2026 OpenVPN Inc += * Copyright (C) 2026 Arne Schwabe + * + * This prog= ram is free software; you can redistribute it and/or modify + * it under t= he terms of the GNU General Public License version 2 + * as published by t= he Free Software Foundation=2E + * + * This program is distributed in the = hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even th= e implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURP= OSE=2E See the + * GNU General Public License for more details=2E + * + *= You should have received a copy of the GNU General Public License along += * with this program; if not, see =2E += */ + +#ifdef HAVE_CONFIG_H +#include "config=2Eh" +#endif + +#include "sip= hash=2Eh" + +#ifdef ENABLE_CRYPTO_OPENSSL +#include = +#endif + +/* OpenSSL siphash is currently 2-3 times slower than the refere= nce + * implementation, so only enable it when PREFER_OPENSSL_SIPHASH is de= fined + * for now */ +#if defined(ENABLE_CRYPTO_OPENSSL) && OPENSSL_VERSION= _NUMBER >=3D 0x30000000L && defined(PREFER_OPENSSL_SIPHASH) +#include +#include "crypto_openssl=2Eh" +#include "crypto_backend=2Eh" = + +struct siphash_context +{ + EVP_MAC *mac; + EVP_MAC_CTX *ctx; + = size_t size; + OSSL_PARAM params[3]; +}; + +/* + * Computes a SipHash = value + * in: pointer to input data (read-only) + * inlen: input data leng= th in bytes (any size_t value) + * k: pointer to the key data (read-only), = must be 16 bytes + * out: pointer to output data (write-only), outlen bytes= must be allocated + * outlen: length of the output in bytes, must be 8 or= 16 + */ +int +siphash_cryptolib(void *sip_context, const void *in, const s= ize_t inlen, + const void *k, uint8_t *out, const size_t o= utlen) +{ + struct siphash_context *sip =3D sip_context; + + + sip->p= arams[1] =3D OSSL_PARAM_construct_octet_string("key", (void *)k, + = SIPHASH_KEY_SIZE); + if (!= EVP_MAC_init(sip->ctx, NULL, 0, sip->params)) + { + crypto_msg(M_= FATAL, "EVP_MAC_init failed"); + } + EVP_MAC_update(sip->ctx, in, inl= en); + + size_t outl =3D 0; + EVP_MAC_final(sip->ctx, out, &outl, out= len); + return 0; +} + +void * +siphash_cryptolib_init(size_t hash_size)= +{ + struct siphash_context *sip; + ALLOC_OBJ(sip, struct siphash_co= ntext); + + sip->mac =3D EVP_MAC_fetch(NULL, "SIPHASH", NULL); + if (= !sip->mac) + { + /* Our OpenSSL library does not support SIPHASH = */ + return sip; + } + sip->ctx =3D EVP_MAC_CTX_new(sip->mac);= + + /* OpenSSL will truly hold a pointer to an int in that parameter */= + sip->size =3D hash_size; + sip->params[0] =3D OSSL_PARAM_construct= _size_t("size", &sip->size); + /* params[1] will hold the key that chang= es which each invocation */ + sip->params[2] =3D OSSL_PARAM_construct_en= d(); + return sip; +} + +bool +siphash_cryptolib_available(void *sip_con= text) +{ + struct siphash_context *sip =3D sip_context; + + return (b= ool)(sip->mac); +} + +void +siphash_cryptolib_uninit(void *sip_context) +{ = + struct siphash_context *sip =3D sip_context; + EVP_MAC_CTX_free(sip= ->ctx); + EVP_MAC_free(sip->mac); + free(sip_context); +} + +#else +/= * for now, we only have one implementation of SIPHASH in a libray, so put t= he + * dummy functions also here */ +int +siphash_cryptolib(void *sip_conte= xt, const void *in, const size_t inlen, + const void *k, u= int8_t *out, const size_t outlen) +{ + return -1; +} + +bool +siphash_cr= yptolib_available(void *sip_context) +{ + return false; +} + +void * +si= phash_cryptolib_init(size_t hash_size) +{ + return NULL; +} + +void +sip= hash_cryptolib_uninit(void *sip_context) +{ +} + + +#endif /* if defined(EN= ABLE_CRYPTO_OPENSSL) && OPENSSL_VERSION_NUMBER >=3D 0x30000000L */ diff --g= it a/src/openvpn/siphash_reference=2Ec b/src/openvpn/siphash_reference=2Ec = index b21a86e=2E=2Ea06599f 100644 --- a/src/openvpn/siphash_reference=2Ec += ++ b/src/openvpn/siphash_reference=2Ec @@ -100,8 +100,8 @@ * outlen: len= gth of the output in bytes, must be 8 or 16 */ int -siphash(const void *= in, const size_t inlen, const void *k, uint8_t *out, - const size_t = outlen) +siphash_reference(const void *in, const size_t inlen, const void *= k, + uint8_t *out, const size_t outlen) { const unsi= gned char *ni =3D (const unsigned char *)in; const unsigned char *kk = =3D (const unsigned char *)k; diff --git a/tests/unit_tests/openvpn/Makefil= e=2Eam b/tests/unit_tests/openvpn/Makefile=2Eam index d861ef9=2E=2E9e1e216 = 100644 --- a/tests/unit_tests/openvpn/Makefile=2Eam +++ b/tests/unit_tests/= openvpn/Makefile=2Eam @@ -84,7 +84,9 @@ $(top_srcdir)/src/openvpn/platfor= m=2Ec \ $(top_srcdir)/src/openvpn/mtu=2Ec \ $(top_srcdir)/src/openvpn/w= in32-util=2Ec \ - $(top_srcdir)/src/openvpn/mss=2Ec + $(top_srcdir)/src/ope= nvpn/mss=2Ec \ + $(top_srcdir)/src/openvpn/siphash_openssl=2Ec \ + $(top_sr= cdir)/src/openvpn/siphash_reference=2Ec dhcp_testdriver_CFLAGS =3D -I$(= top_srcdir)/src/openvpn -I$(top_srcdir)/src/compat @TEST_CFLAGS@ -DDHCP_UNI= T_TEST dhcp_testdriver_LDFLAGS =3D @TEST_LDFLAGS@ -L$(top_srcdir)/src/open= vpn @@ -97,6 +99,7 @@ ssl_testdriver_CFLAGS =3D \ -I$(top_srcdir)/inc= lude -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \ + -DPREFER_OP= ENSSL_SIPHASH \ @TEST_CFLAGS@ ssl_testdriver_LDFLAGS =3D @TEST_LDFLAGS@ = $(OPTIONAL_CRYPTO_LIBS) ssl_testdriver_SOURCES =3D test_ssl=2Ec \ diff --= git a/tests/unit_tests/openvpn/test_crypto=2Ec b/tests/unit_tests/openvpn/t= est_crypto=2Ec index cb4eaa2=2E=2Eaad17f7 100644 --- a/tests/unit_tests/ope= nvpn/test_crypto=2Ec +++ b/tests/unit_tests/openvpn/test_crypto=2Ec @@ -31,= 12 +31,14 @@ #include #include #include +#include #include #include "crypto= =2Eh" #include "crypto_epoch=2Eh" #include "options=2Eh" #include "ssl_b= ackend=2Eh" +#include "siphash=2Eh" #include "mss=2Eh" #include "test_c= ommon=2Eh" @@ -923,6 +925,59 @@ assert_memory_equal(key_parameters=2Eh= mac, exp_impl_iv, sizeof(exp_impl_iv)); } +/* Use a define here since so= me c compilers don't like array initialisation + * with an integer */ +#def= ine UT_SIPHASH_HASH_SIZE 16 + +static void +test_siphash(void **state) +{ += const char *message =3D "Look behind you, a Three-Headed Monkey!"; + + = uint8_t out[UT_SIPHASH_HASH_SIZE] =3D { 0 }; + const uint8_t key[SIPH= ASH_KEY_SIZE] =3D { 0x11, 0x22, 0x33, 0x44, 0x55, 0x66 }; + + siphash_re= ference(message, strlen(message), key, out, UT_SIPHASH_HASH_SIZE); + + c= onst uint8_t expected_out[UT_SIPHASH_HASH_SIZE] =3D { 0x3e, 0xea, 0x95, 0xb= 2, 0x6d, 0x5c, 0x4e, 0xfa, + = 0x20, 0x47, 0x65, 0x7e, 0xdd, 0xcd, 0x62, 0x51 }; + assert_mem= ory_equal(out, expected_out, UT_SIPHASH_HASH_SIZE); +} + +static void +test= _siphash_openssl(void **state) +{ + void *sipctx =3D siphash_cryptolib_i= nit(UT_SIPHASH_HASH_SIZE); + + if (!siphash_cryptolib_available(sipctx))= + { + siphash_cryptolib_uninit(sipctx); + skip(); + } = + + const char *message =3D "Look behind you, a Three-Headed Monkey!"; += + uint8_t out[UT_SIPHASH_HASH_SIZE] =3D { 0 }; + const uint8_t key[S= IPHASH_KEY_SIZE] =3D { 0x11, 0x22, 0x33, 0x44, 0x55, 0x66 }; + + + const= uint8_t expected_out[UT_SIPHASH_HASH_SIZE] =3D { 0x3e, 0xea, 0x95, 0xb2, 0= x6d, 0x5c, 0x4e, 0xfa, + = 0x20, 0x47, 0x65, 0x7e, 0xdd, 0xcd, 0x62, 0x51 }; + + + siphash_cr= yptolib(sipctx, message, strlen(message), key, out, + = UT_SIPHASH_HASH_SIZE); + assert_memory_equal(out, expected_out, UT_SIPHA= SH_HASH_SIZE); + + /* check that calling the function twice is safe */ += siphash_cryptolib(sipctx, message, strlen(message), key, out, + = UT_SIPHASH_HASH_SIZE); + assert_memory_equal(out, expected= _out, UT_SIPHASH_HASH_SIZE); + + siphash_cryptolib_uninit(sipctx); +} + = + int main(void) { @@ -960,7 +1015,9 @@ cmocka_unit_test_presta= te_setup_teardown(crypto_test_epoch_edge, = crypto_test_epoch_setup, = crypto_test_epoch_teardown, &prestate_num13), - cmo= cka_unit_test(epoch_test_derive_data_key) + cmocka_unit_test(epoch_t= est_derive_data_key), + cmocka_unit_test(test_siphash), + cmo= cka_unit_test(test_siphash_openssl) }; return cmocka_run_group_= tests_name("crypto tests", tests, NULL, NULL); -- To view, visit http://g= errit=2Eopenvpn=2Enet/c/openvpn/+/31?usp=3Demail To unsubscribe, or for hel= p writing mail filters, visit http://gerrit=2Eopenvpn=2Enet/settings?usp=3D= email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branc= h: master Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0 Gerri= t-Change-Number: 31 Gerrit-PatchSet: 18 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld G= errit-CC: openvpn-devel Gerrit-At= tention: flichtenheld --MhbxW9fhPHo= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld=2E

plaisthos uploaded pa= tch set #18 to this change=2E

View Change

All=
ow to use OpenSSL's SIPHASH implementation when available

OpenSS= L library is currently slower than the reference implementation
(about 1= =2E5x to 2x depending of the compiler)=2E

The OpenSSL API for using = the SIPHASH MAC is different enough from using
normal HMAC or Digest tha= t we already implement that combining them into
one API does not make se= nse=2E

SIPHASH is only available on OpenSSL 3=2E1 and later=2E We st= ill check for
support on 3=2E0 and later as the whole API to allow using= the SIPHASH alrady
exists in OpenSSL 3=2E0=2E Some of the later OpenSSL= 3=2E0=2Ex might get support
for it=2E Theoretically, a provider can be = loaded in OpenSSL 3=2E0 that
implements SIPHASH=2E

With OpenSSL&#= 39;s implementation being slower, we currently only use it to
check that= our reference implementation and the OpenSSL implementation
yield the s= ame result in unit tests

Change-Id: I09aa27caa1a3aab0d1be6118b26d54a= 1c1bf7aa0
Signed-off-by: Arne Schwabe <arne@rfc2549=2Eorg>
---<= br>M CMakeLists=2Etxt
M src/openvpn/Makefile=2Eam
M src/openvpn/sipha= sh=2Eh
A src/openvpn/siphash_openssl=2Ec
M src/openvpn/siphash_refere= nce=2Ec
M tests/unit_tests/openvpn/Makefile=2Eam
M tests/unit_tests/o= penvpn/test_crypto=2Ec
7 files changed, 277 insertions(+), 8 deletions(-= )

git pull ssh://gerrit=2Eopenvpn=2Enet:29418/op=
envpn refs/changes/31/31/18
diff --git a/CMakeLists=2Etxt b/CMakeLi=
sts=2Etxt
index 7473f15=2E=2E25c3ea5 100644
--- a/CMakeLists=2Etxt
+++ b/CMakeLists=2Etxt
@@ -572,6 +572,9 @@
src/openvpn/shaper=2Eh<= br> src/openvpn/sig=2Ec
src/openvpn/sig=2Eh<= /span>
+ src/openvpn/siph= ash=2Eh
+ src/open= vpn/siphash_openssl=2Ec
+ src/openvpn/siphash_reference=2Ec
src/openvpn/= socket=2Ec
src/openvpn/socket=2Eh
= src/openvpn/socket_util=2Ec
@@ -792,8 +795,12 @@ src/openvpn/packet_id=2Ec
src/open= vpn/mtu=2Ec
src/openvpn/mss=2Ec
+ src/openvpn/siphash_reference= =2Ec
+ src/ope= nvpn/siphash_openssl=2Ec
)

+ target_compile_defini= tions(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH)
+
target_sources(test_ssl= PRIVATE
tests/unit_tests/openvpn/mock_managem= ent=2Ec
tests/unit_tests/openvpn/mock_ssl_depe= ndencies=2Ec
diff --git a/src/openvpn/Makefile=2Eam b/src/o= penvpn/Makefile=2Eam
index ff8cc54=2E=2E08c8250 100644
--- a/src/openvpn/Makefile=2Eam
+++ b/src/openv= pn/Makefile=2Eam
@@ -128,6 +128,8 @@
sess= ion_id=2Ec session_id=2Eh \
shaper=2Ec shaper=2Eh \
sig=2Ec sig=2Eh \
+ siphash_reference=2Ec siphash=2Eh \
+ siphash_openssl=2Ec \
socket= =2Ec socket=2Eh \
socket_util=2Ec socket_util=2Eh \
socks=2Ec socks=2Eh \
diff --git a/src/openvpn= /siphash=2Eh b/src/openvpn/siphash=2Eh
index ef61110=2E=2E0= 7b087e 100644
--- a/src/openvpn/siphash=2Eh
+++ b/src/openvpn/siphash=2Eh

@@ -18,12 +18,67 @@ #ifndef SIPHASH_H
#define SIPHASH_H

-#include <intt= ypes=2Eh>
+#includ= e <stdint=2Eh>
= +#include <stdio=2Eh>
+#include <stdbool=2Eh>

/* = siphash always uses 128-bit keys */
#define SIPHASH_KEY_SI= ZE 16

-int siphash(const void *in, size_t inlen, const void *k, uint8_t *out,
- size_t outle= n);
+/* Prototypes fo= r an implementation of SIPHASH in a crypto library */

-#endif
+/**
+ * Calculates SIPHASH using the crypto library functio= n=2E
+ */
<= span style=3D"color: hsl(120, 100%, 40%);">+int

+siphash_cryptolib(void *sip_context, const void= *in, size_t inlen,
+= const void *k, uint8_t *out, size_t outlen);
+

+/**
+ * Calculates SIPHASH using the reference implementation
= + */
+int
+siphash_reference(const void *in, size_t inlen, const void *k,=
+ u= int8_t *out, size_t outlen);
+
+/**=
+ *
+ * @param hash_size the size of the outpu= t hash size
+ * @retu= rn initialised context for siphash
+ */
+v= oid *
+siphash_crypto= lib_init(size_t hash_size);
+
+/**<= br>+ * Free the siphash context= used for the crypto library
+ * @param sip_context
+ */
+void<= /span>
+siphash_cryptolib_un= init(void *sip_context);
+
+/**
= + * Returns if the crypto libra= ry is available (and should be used)
+ *
+= * This returns if there is a crypto library version of Siphash24 is=
+ * available and should be= used (OpenSSL 3/4 version is quite slow, so
+ * we prefer the reference implementation)<= br>+ *
+ */
+bool
+= siphash_cryptolib_available(void *sip_context);
+
+static inline int
+siphash(void *ctx, const void *in, size_t inlen, const void *k,
+ uint8_t *out, si= ze_t outlen)
+{
+ if (siphash_cryptolib= _available(ctx))
+ = {
+ return si= phash_cryptolib(ctx, in, inlen, k, out, outlen);
+ }
+ else
+ {
+ re= turn siphash_reference(in, inlen, k, out, outlen);
+ }
+}
+<= /span>
+#endif /* ifndef SIP= HASH_H */
\ No newline at end of file
diff = --git a/src/openvpn/siphash_openssl=2Ec b/src/openvpn/siphash_openssl=2Ec
new file mode 100644
index 0000000=2E=2E214b= 3f4
--- /dev/null
+++ b/src/openvpn/siphash= _openssl=2Ec
@@ -0,0 +1,145 @@
+/*
+ * OpenVPN -- An application to securely tunnel IP networks
+ * over a si= ngle TCP/UDP port, with support for SSL/TLS-based
+ * session authentication and key= exchange,
+ * = packet encryption, packet authentication, and
+ * packet compression=2E
+ *
+ * Copyright (C) 2002-2026 OpenVPN Inc &= lt;sales@openvpn=2Enet>
+ * Copyright (C) 2026 Arne Schwabe <arne@rfc2549=2Eorg>
+ *
+ * This program is free software; you ca= n redistribute it and/or modify
+ * it under the terms of the GNU General Public License versio= n 2
+ * as published= by the Free Software Foundation=2E
+ *
+ = * This program is distributed in the hope that it will be useful,+ * but WITHOUT ANY WARRANTY= ; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE= =2E See the
+ * GNU= General Public License for more details=2E
+ *
+ * You should have received a copy of the GNU General Public Licens= e along
+ * with thi= s program; if not, see <https://www=2Egnu=2Eorg/licenses/>=2E<= br>+ */
+
+#ifdef HAVE_CONFIG_H
+#include "config=2Eh"
+#endif
+
+#inc= lude "siphash=2Eh"
+
+#ifdef ENA= BLE_CRYPTO_OPENSSL
+#= include <openssl/opensslv=2Eh>
+#endif
+
+/* OpenSSL siph= ash is currently 2-3 times slower than the reference
+ * implementation, so only enable it when= PREFER_OPENSSL_SIPHASH is defined
+ * for now */
+#if defined(ENABLE_CRYPTO_OPENSSL) && OPENSSL_VERSION_NUMB= ER >=3D 0x30000000L && defined(PREFER_OPENSSL_SIPHASH)+#include <openssl/evp=2Eh&= gt;
+#include "c= rypto_openssl=2Eh"
+#include "crypto_backend=2Eh"
+
+struct siphash_context
+{
+ EVP_MA= C *mac;
+ EVP_MAC_= CTX *ctx;
+ size_t= size;
+ OSSL_PARA= M params[3];
+};
+
+/*
+ * Computes a SipHash value
+ * in: pointer to input data (read-only)+ * inlen: input data length= in bytes (any size_t value)
+ * k: pointer to the key data (read-only), must be 16 bytes=
+ * out: pointer to output = data (write-only), outlen bytes must be allocated
+ * outlen: length of the output in bytes, mu= st be 8 or 16
+ */
+int
+siphash_cryptolib(void *sip_context, c= onst void *in, const size_t inlen,
+ const void *k, uint8_t *out, const size_t = outlen)
+{
= + struct siphash_context *si= p =3D sip_context;
+<= /span>
+
+ sip->params[1] =3D OSSL_PARAM_co= nstruct_octet_string("key", (void *)k,
+ = SIPHASH_KEY_SIZE);
+ if (!EVP_MAC_init(sip->ctx, NULL, 0, sip->params))=
+ {
+ crypto_msg(M_FATAL, "EVP_MA= C_init failed");
+ }
+ EVP_MAC_= update(sip->ctx, in, inlen);
+
+ siz= e_t outl =3D 0;
+ = EVP_MAC_final(sip->ctx, out, &outl, outlen);
+ return 0;
+}
+
+void *
+siphash_cryptolib_init= (size_t hash_size)
+{=
+ struct siphash_= context *sip;
+ AL= LOC_OBJ(sip, struct siphash_context);
+
+ = sip->mac =3D EVP_MAC_fetch(NULL, "SIPHASH", NULL);+ if (!sip->mac)=
+ {
+ /* Our OpenSSL library does not = support SIPHASH */
+ = return sip;
+ = }
+ sip->ctx= =3D EVP_MAC_CTX_new(sip->mac);
+
+ = /* OpenSSL will truly hold a pointer to an int in that parameter */<= br>+ sip->size =3D hash_s= ize;
+ sip->par= ams[0] =3D OSSL_PARAM_construct_size_t("size", &sip->size)= ;
+ /* params[1] w= ill hold the key that changes which each invocation */
+ sip->params[2] =3D OSSL_PARAM_con= struct_end();
+ re= turn sip;
+}+
+bool
+siphash_cryptolib_available(void *sip_context)
+{

+ struct siphash_context *sip =3D sip_context;
+
+ return (bool)(sip->mac);+}
+
+void
+siphas= h_cryptolib_uninit(void *sip_context)
+{
+= struct siphash_context *sip =3D sip_context;
+ EVP_MAC_CTX_free(sip->ctx);
<= span style=3D"color: hsl(120, 100%, 40%);">+ EVP_MAC_free(sip->mac);<= /span>
+ free(sip_context= );
+}
+

+#else
+/* for now, we only have one implementation of SIPHASH in a libray, = so put the
+ * dummy = functions also here */
+siphash_crypt= olib(void *sip_context, const void *in, const size_t inlen,
+ const void *k, ui= nt8_t *out, const size_t outlen)

+{
+ r= eturn -1;
+}+
+bool
+siphash_cryptolib_available(void *sip_context)
+{

+ return false;
+}
+
+void *
= +siphash_cryptolib_init(size_t = hash_size)
+{<= br>+ return NULL;
= +}
+
+void
+siphash= _cryptolib_uninit(void *sip_context)
+{
+}=
+
+
+#endif /* if defined(ENABLE_CRYPTO_OPENSSL) && OP= ENSSL_VERSION_NUMBER >=3D 0x30000000L */
diff --git a/sr= c/openvpn/siphash_reference=2Ec b/src/openvpn/siphash_reference=2Ec<= br>index b21a86e=2E=2Ea06599f 100644
--- a/src/openvp= n/siphash_reference=2Ec
+++ b/src/openvpn/siphash_reference= =2Ec
@@ -100,8 +100,8 @@
* outlen: lengt= h of the output in bytes, must be 8 or 16
*/
int

-siphash(const= void *in, const size_t inlen, const void *k, uint8_t *out,
- const size_t outlen)
+siphash_reference(const void= *in, const size_t inlen, const void *k,
+ uint8_t *out, const size_t outlen)
{
const unsigned char *ni =3D (const u= nsigned char *)in;
const unsigned char *kk =3D (const = unsigned char *)k;
diff --git a/tests/unit_tests/openvpn/Ma= kefile=2Eam b/tests/unit_tests/openvpn/Makefile=2Eam
index = d861ef9=2E=2E9e1e216 100644
--- a/tests/unit_tests/openvpn/= Makefile=2Eam
+++ b/tests/unit_tests/openvpn/Makefile=2Eam<= /span>
@@ -84,7 +84,9 @@
$(top_srcdir)/src/openv= pn/platform=2Ec \
$(top_srcdir)/src/openvpn/mtu=2Ec \
$(top_srcdir)/src/openvpn/win32-util=2Ec \
- $(top_srcdir)/src/openvpn/mss=2Ec
+ $(top_srcdir)/src/openv= pn/mss=2Ec \
+ $(top_= srcdir)/src/openvpn/siphash_openssl=2Ec \
+ $(top_srcdir)/src/openvpn/siphash_reference=2Ec

dhcp_testdriver_CFLAGS =3D -I$(top_srcdir)/= src/openvpn -I$(top_srcdir)/src/compat @TEST_CFLAGS@ -DDHCP_UNIT_TEST
dhcp_testdriver_LDFLAGS =3D @TEST_LDFLAGS@ -L$(top_srcdir)/src/= openvpn
@@ -97,6 +99,7 @@

ssl_testdriver_CFLAGS =3D \

-I$(top_srcdir)/include -I= $(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \
+ -DPREFER_OPENSSL_SIPHASH \
@TEST_CFLAGS@

ssl_testdriver_LDFLAGS =3D @TEST_LDFLA= GS@ $(OPTIONAL_CRYPTO_LIBS)
ssl_testdriver_SOURCES =3D te= st_ssl=2Ec \
diff --git a/tests/unit_tests/openvpn/test_cry= pto=2Ec b/tests/unit_tests/openvpn/test_crypto=2Ec
index cb= 4eaa2=2E=2Eaad17f7 100644
--- a/tests/unit_tests/openvpn/te= st_crypto=2Ec
+++ b/tests/unit_tests/openvpn/test_crypto=2E= c
@@ -31,12 +31,14 @@
#include <stdarg= =2Eh>
#include <string=2Eh>
#inc= lude <setjmp=2Eh>
+#include <inttypes=2Eh>
#include <cmocka=2Eh&= gt;

#include "crypto=2Eh"
#include "crypto_epoch=2Eh"
#includ= e "options=2Eh"
#include "ssl_backend=2Eh&q= uot;
+#include "= siphash=2Eh"

#include "mss=2Eh= "
#include "test_common=2Eh"
@@ -923,6 +925,59 @@

assert_memory_equal(key_paramet= ers=2Ehmac, exp_impl_iv, sizeof(exp_impl_iv));
}
+/* Use a de= fine here since some c compilers don't like array initialisation=
+ * with an integer */
+#define UT_SIPHASH_HASH_= SIZE 16
+
<= span style=3D"color: hsl(120, 100%, 40%);">+static void

+test_siphash(void **state)
+{

+ const char *message =3D "Look behind you,= a Three-Headed Monkey!";
+
+ uint= 8_t out[UT_SIPHASH_HASH_SIZE] =3D { 0 };
+ const uint8_t key[SIPHASH_KEY_SIZE] =3D { 0x11, 0x= 22, 0x33, 0x44, 0x55, 0x66 };
+
+ sipha= sh_reference(message, strlen(message), key, out, UT_SIPHASH_HASH_SIZE);
+
+ const uint8_t expected_out[UT_SIPHASH= _HASH_SIZE] =3D { 0x3e, 0xea, 0x95, 0xb2, 0x6d, 0x5c, 0x4e, 0xfa,+ = 0x20, 0x47, 0x65, 0x7e, 0xdd, 0xcd, 0x62, 0x51 = };
+ assert_memory= _equal(out, expected_out, UT_SIPHASH_HASH_SIZE);
+}
+
+static v= oid
+test_siphash_ope= nssl(void **state)
+{=
+ void *sipctx = =3D siphash_cryptolib_init(UT_SIPHASH_HASH_SIZE);
+
+ if (!siphash_cryptolib_available(sipctx))
+ {
+ siphash_cryptolib_uninit(sipctx);
= + skip();
+ }

+
+ const char *message =3D "Look behind you, a Three-Headed M= onkey!";
+
+ uint8_t out[UT_SIPHAS= H_HASH_SIZE] =3D { 0 };
+ const uint8_t key[SIPHASH_KEY_SIZE] =3D { 0x11, 0x22, 0x33, 0x44, 0= x55, 0x66 };
+=
+
+ const uint8_t expected_out[UT_SIPHASH_HAS= H_SIZE] =3D { 0x3e, 0xea, 0x95, 0xb2, 0x6d, 0x5c, 0x4e, 0xfa,
+ = 0x20, 0x47, 0x65, 0x7e, 0xdd, 0xcd, 0x62, 0x51 };
+
+
+ siphash_cryptolib(sipctx, message, strlen(message), key= , out,
+ = UT_SIPHASH_HASH_SIZE);
+ assert_memory_equal(out, expected_out, UT_SIPHASH_HASH_SIZE= );
+
+ /* check that calling the functi= on twice is safe */
+= siphash_cryptolib(sipctx, message, strlen(message), key, out,+ UT_SIPH= ASH_HASH_SIZE);
+ = assert_memory_equal(out, expected_out, UT_SIPHASH_HASH_SIZE);
+

+ siphash_cryptolib_uninit(sipctx);
+}

+
+
int
main(void)
{
@@ -960,7 +1015,9 @@
cmocka_unit_tes= t_prestate_setup_teardown(crypto_test_epoch_edge,
= crypto_test_epoch_setup, crypto_test_epoch_= teardown, &prestate_num13),
- cmocka_unit_test(epoch_test_derive_data_key)
+ cmocka_unit_test(epoch_t= est_derive_data_key),

+ cmocka_unit_test(test_siphash),
+ cmocka_unit_test(test_siphash_openssl)=
};

return cmocka_run_= group_tests_name("crypto tests", tests, NULL, NULL);

To view, visit change 31=2E To unsubscribe, or for = help writing mail filters, visit settings=2E

Gerrit-Messa= geType: newpatchset
Gerrit-Project: ope= nvpn
Gerrit-Branch: master
Gerrit-Change-Id: I09aa27caa1a3aab0d1be6118b26d54a1= c1bf7aa0
Gerrit-Change-Number: 31
Gerrit-PatchSet: 18
Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg>
Gerrit-Reviewer: flichtenheld <frank@lic= htenheld=2Ecom>
Gerrit-CC: openvpn-d= evel <openvpn-devel@lists=2Esourceforge=2Enet>
Gerrit-Attention: flichtenheld <frank@lichtenheld=2Ecom>= ;
--MhbxW9fhPHo=-- --===============2668526237532391113== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============2668526237532391113== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============2668526237532391113==--