From: Heiner Kallweit Subject: Re: [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup") Date: Tue, 1 Jan 2019 15:38:44 +0100 Message-ID: <5bf4cb4e-5e87-7892-bd84-0509ff435e03@gmail.com> References: <20190101111334.3115-1-firasuke@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Stephen Hemminger To: firasuke@gmail.com Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:33585 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726389AbfAAOiw (ORCPT ); Tue, 1 Jan 2019 09:38:52 -0500 Received: by mail-wr1-f68.google.com with SMTP id c14so28354984wrr.0 for ; Tue, 01 Jan 2019 06:38:51 -0800 (PST) In-Reply-To: <20190101111334.3115-1-firasuke@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 01.01.2019 12:13, firasuke@gmail.com wrote: > From: Firas Khalil Khana > > Fixes: 377a09902a57 ("configure: Minor code cleanup") > I think the patch should be annotated iproute2 to make clear it's not about the kernel. And it's missing a description which issue was fixed. > Signed-off-by: Firas Khalil Khana > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index b85eb58b..45fcffb6 100755 > --- a/configure > +++ b/configure > @@ -115,7 +115,7 @@ EOF > check_xt_old_internal_h() > { > # bail if previous XT checks has already succeeded. > - grep -q if grep -q TC_CONFIG_XT $CONFIG && return > + grep -q TC_CONFIG_XT $CONFIG && return > > #check if we need our own internal.h > cat >$TMPDIR/ipttest.c <