From: "plaisthos (Code Review)" Date: Wed, 28 Jan 2026 10:58:22 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <5c2cf92578a68ffa999fc3ba987a1591d2333029-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="oo9xWj/hLhc="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: tunnel_server(): close correct inotify fd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openvpn-devel --oo9xWj/hLhc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2. plaisthos has posted comments on this change by cron2. ( http://gerrit.open= vpn.net/c/openvpn/+/1497?usp=3Demail ) Change subject: tunnel_server(): close correct inotify fd ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1497/comment/079de3b1_4b96fdc7?usp=3D= email : PS1, Line 4237: multi.top.c2.inotify_fd =3D inotify_init(); We set inotify_fd here in (multi->top, which is also CM_TOP_CLONE) instead = of top which is CM_TOP. We should probably rename top in this function to something like root_top o= r something else to avoid the confusion between multi->top and the local to= p variable. http://gerrit.openvpn.net/c/openvpn/+/1497/comment/de71ce2b_74df9b13?usp=3D= email : PS1, Line 4247: close(top->c2.inotify_fd); and then we close top of the other context. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1497?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iabc117848ad7b67d240c392f1a6aa2d7531fd5bb Gerrit-Change-Number: 1497 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Comment-Date: Wed, 28 Jan 2026 10:58:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --oo9xWj/hLhc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: cron2.

Patch set 1:Code-Review +2=

V= iew Change

2 comments:

  • File src/openvpn/multi.c:

    <= ul style=3D"list-style: none; padding: 0;">
  • Patch Set = #1, Line 4237: mult= i.top.c2.inotify_fd =3D inotify_init();

    We set inotify_fd here i= n (multi->top, which is also CM_TOP_CLONE) instead of top which is CM_TO= P.

    We should probably rename top in this function to something like ro= ot_top or something else to avoid the confusion between multi->top and t= he local top variable.

  • Patch Set #1, Line 424= 7: close(top->c2= .inotify_fd);

    and then we close top of the other context.

To view, visit change 1497. To unsubscribe, or for help wri= ting mail filters, visit settings.

=
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iabc117848ad7b67d240c392f1a6= aa2d7531fd5bb
Gerrit-Change-Number: 1497
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Comment-Date: Wed, 28 Jan 2026 10:58:22= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --oo9xWj/hLhc=--