From: Pierre-Louis Bossart Subject: Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID Date: Tue, 7 May 2019 15:26:45 -0500 Message-ID: <5c42b741-5e5c-ce00-8321-59df1df115f1@linux.intel.com> References: <20190506225321.74100-1-evgreen@chromium.org> <20190506225321.74100-2-evgreen@chromium.org> <74e8cfcd-b99f-7f66-48ce-44d60eb2bbca@linux.intel.com> <64FD1F8348A3A14CA3CB4D4C9EB1D15F30A7C756@BGSMSX107.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <64FD1F8348A3A14CA3CB4D4C9EB1D15F30A7C756@BGSMSX107.gar.corp.intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "M R, Sathya Prakash" , Evan Green , Liam Girdwood , Mark Brown Cc: Rajat Jain , "alsa-devel@alsa-project.org" , Liam Girdwood , Takashi Iwai , "linux-kernel@vger.kernel.org" , Ben Zhang , "M, Naveen" List-Id: alsa-devel@alsa-project.org > On 5/6/19 5:53 PM, Evan Green wrote: >>> Add support for Intel Comet Lake platforms by adding a new Kconfig for >>> CometLake and the appropriate PCI ID. > >> This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To the best of my knowledge SOF probes fine on CML and the known issues can be found on the SOF github [1]. > > The PCI ID change is seen on later production Si versions. The PCI ID is 02c8. As I suspected, we are talking about different skews and generations of the chipset and a board-level change, not silicon change. The CNL PCH-LP PCI ID is 0x9DC8, the CNL PCH-H PCI ID is 0xA348 (used for CoffeeLake). Both are supported by SOF. What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML PCH-H (0x06C8). Can we respin this patchset to add support for those last two instead of just the -LP case? I'll send a patch to add those IDs for the HDaudio legacy driver for consistency. Thanks! -Pierre