From: "its_Giaan (Code Review)"
Date: Wed, 19 Jun 2024 11:59:35 +0000
In-Reply-To:
References:
Reply-To: gianmarco@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
gert@...1296...
Message-ID: <5d0f49040eb22edcfdb301789984328d48d1d760-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="W+gxwDWOLqQ="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug
preventing proxy credentials caching
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: cron2 , flichtenheld , plaisthos , openvpn-devel
--W+gxwDWOLqQ=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos.
its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/523?usp=3Demail )
Change subject: Http-proxy: fix bug preventing proxy credentials caching
......................................................................
Patch Set 9:
(2 comments)
File src/openvpn/ssl.h:
http://gerrit.openvpn.net/c/openvpn/+/523/comment/7670fb94_a3d3d05d :
PS8, Line 402: bool ssl_get_auth_nocache();
> this needs to have a `(void)` there.
Done
File src/openvpn/ssl.c:
http://gerrit.openvpn.net/c/openvpn/+/523/comment/31872d63_557ff8df :
PS8, Line 341: ssl_get_auth_nocache()
> this needs to have a `(void)` there.
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 9
Gerrit-Owner: its_Giaan
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 19 Jun 2024 11:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--W+gxwDWOLqQ=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos. <=
/p>
View C=
hange
2 comments:
=
File src/openvpn/ssl.h:
=
Done
File src/openvpn/ssl.c:
<=
ul style=3D"list-style: none; padding: 0;">Patch Set #8, Line 341:=
ssl_get_auth_nocache()=
this needs to have a `(void)` there.
Done
=
ul>To view, visit change 523. To unsubscribe, or for help writing m=
ail filters, visit settings<=
/a>.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279=
fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 9
Gerrit-Owner: its_Giaan <gianmarco@...2786...=
..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Wed, 19 Jun 2024 11:59:35=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...=
>
Gerrit-MessageType: comment
--W+gxwDWOLqQ=--