From: "flichtenheld (Code Review)"
Date: Tue, 15 Jul 2025 11:11:01 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, gert@...1296...
Message-ID: <5d24c8861e68645a0102d8cb3005d259d9522374-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="e9LNcDNLfNs="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Cleanup/simplify
mbed TLS related define from autoconf
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--e9LNcDNLfNs=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/1081?usp=3Demail )
Change subject: Cleanup/simplify mbed TLS related define from autoconf
......................................................................
Patch Set 8: Code-Review-2
(1 comment)
File configure.ac:
http://gerrit.openvpn.net/c/openvpn/+/1081/comment/136d3b26_e9bdddae :
PS7, Line 1041: AC_CHECK_HEADER(psa/crypto.h)
> *sigh* I hate autconf. [=E2=80=A6]
Sorry, this is still not correct. Now it defines HAVE_PSA_CRYPTO_H, not HAV=
E_MBEDTLS_PSA_CRYPTO_H %)
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1081?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Comment-Date: Tue, 15 Jul 2025 11:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--e9LNcDNLfNs=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, plaisthos.
Patch set 8:Code-Review -2=
V=
iew Change
1 comment:
Sorry, this is =
still not correct. Now it defines HAVE_PSA_CRYPTO_H, not HAVE_MBEDTLS_PSA_C=
RYPTO_H %)
To view, visit change 1081. To unsubscribe=
, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c=
5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Comment-Date: Tue, 15 Jul 2025 11:11:01=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--e9LNcDNLfNs=--