Message-ID: <5d2fbba0-63f3-444a-adfc-b0773bf20774@linux.intel.com>
Date: Tue, 2 Sep 2025 15:26:13 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] usb: xhci: improve TR Dequeue Pointer mask
To: =?UTF-8?Q?Micha=C5=82_Pecio?= <michal.pecio@gmail.com>
Cc: mathias.nyman@linux.intel.com, linux-usb@vger.kernel.org
References: <20250826130656.277633-1-niklas.neronin@linux.intel.com>
 <20250828101207.49aea3b5.michal.pecio@gmail.com>
Content-Language: en-US
From: "Neronin, Niklas" <niklas.neronin@linux.intel.com>
In-Reply-To: <20250828101207.49aea3b5.michal.pecio@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 28/08/2025 11.12, Michał Pecio wrote:
> On Tue, 26 Aug 2025 15:06:56 +0200, Niklas Neronin wrote:
>> Address the naming and usage of the TR Dequeue Pointer mask in the xhci
>> driver. The Endpoint Context Field at offset 0x08 is defined as follows:
>>  Bit 0		Dequeue Cycle State (DCS)
>>  Bits 3:1	RsvdZ (Reserved and Zero)
>>  Bits 63:4	TR Dequeue Pointer
>>
>> When extracting the TR Dequeue Pointer for an Endpoint without Streams,
>> in xhci_handle_cmd_set_deq(), the inverted Dequeue Cycle State mask
>> (~EP_CTX_CYCLE_MASK) is used, inadvertently including the Reserved bits.
>> Although bits 3:1 are typically zero, using the incorrect mask could cause
>> issues.
>>
>> The existing mask, named "SCTX_DEQ_MASK," is misleading because "SCTX"
>> implies exclusivity to Stream Contexts, whereas the TR Dequeue Pointer is
>> applicable to both Stream and non-Stream Contexts.
>>
>> Rename the mask to "TR_DEQ_PTR_MASK", utilize GENMASK_ULL() macro and use
>> the mask when handling the TR Dequeue Pointer field.
>>
>> Function xhci_get_hw_deq() returns the Endpoint Context Field 0x08, either
>> directly from the Endpoint context or a Stream.
>>
>> Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
>> ---
...
> 
>> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
>> index a20f4e7cd43a..59ff84ba2d4a 100644
>> --- a/drivers/usb/host/xhci.h
>> +++ b/drivers/usb/host/xhci.h
>> @@ -500,7 +500,8 @@ struct xhci_ep_ctx {
>>  
>>  /* deq bitmasks */
>>  #define EP_CTX_CYCLE_MASK		(1 << 0)
>> -#define SCTX_DEQ_MASK			(~0xfL)
>> +/* bits 63:4 - TR Dequeue Pointer */
>> +#define TR_DEQ_PTR_MASK			GENMASK_ULL(63, 4)
> 
> I don't care much about this rename, but I can't help but notice that
> naming is not consistent with the related EP_CTX_CYCLE_MASK above and
> that it too applies to both types of contexts.
> 
> If I wanted to fix this, I would just drop the 'EP_' and 'S' prefixes.

I have an Endpoint Context patch series in progress that will address all
Endpoint Context macro naming, comments, and related issues.

Because, this patch set is quite old, v1 sent in February this year, all
my current patches are built and tested on top of it, so this is why I
am sending it first.

Best Regards,
Niklas