From: Stephen Boyd Subject: Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver Date: Fri, 30 Aug 2019 08:55:37 -0700 Message-ID: <5d6946fa.1c69fb81.44ab7.8d72@mx.google.com> References: <66ac3d3707d6296ef85bf1fa321f7f1ee0c02131.1566907161.git.amit.kucheria@linaro.org> <5d65cbe9.1c69fb81.1ceb.2374@mx.google.com> <5d67e6cf.1c69fb81.5aec9.3b71@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Amit Kucheria Cc: Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui , Andy Gross , Bjorn Andersson , Eduardo Valentin , linux-arm-msm , Linux Kernel Mailing List , Marc Gonzalez , Brian Masney , Linux PM list , DTML List-Id: devicetree@vger.kernel.org Quoting Amit Kucheria (2019-08-30 04:32:54) > On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria = wrote: > > > > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrot= e: > > > > > > Can we get a known quantity of interrupts for a particular compatible > > > string instead? Let's be as specific as possible. The index matters t= oo, > > > so please list them in the order that is desired. > > > > I *think* we can predict what platforms have uplow and critical > > interrupts based on IP version currently[1]. For newer interrupt > > types, we might need more fine-grained platform compatibles. > > > > [1] Caveat: this is based only on the list of platforms I've currently > > looked at, there might be something internally that breaks these > > rules. >=20 > What do you think if we changed the wording to something like the followi= ng, >=20 > - interrupt-names: Must be one of the following depending on IP version: > For compatibles qcom,msm8916-tsens, qcom,msm8974-tsens, > qcom,qcs404-tsens, qcom,tsens-v1, use > interrupt-names =3D "uplow"; > For compatibles qcom,msm8996-tsens, qcom,msm8998-tsens, > qcom,sdm845-tsens, qcom,tsens-v2, use > interrupt-names =3D "uplow", "critical"; Ok. I would still prefer YAML/JSON schema for this binding so that it's much more explicit about numbers and the order of interrupts, etc.