Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9406C4360C for ; Fri, 4 Oct 2019 06:17:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88A452133F for ; Fri, 4 Oct 2019 06:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="d6k5iUUy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388281AbfJDGRs (ORCPT ); Fri, 4 Oct 2019 02:17:48 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35700 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388278AbfJDGRs (ORCPT ); Fri, 4 Oct 2019 02:17:48 -0400 Received: by mail-pg1-f194.google.com with SMTP id p30so1076543pgl.2 for ; Thu, 03 Oct 2019 23:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:from:to:cc:subject:user-agent:date; bh=4cnCC9H4fJLav9+hSDYX1cOtIjCBJIUM/F01nX4r0sE=; b=d6k5iUUyoTZwDdDHyzh3q/Szqethp1TagqWXHky6Zf18X5nX0CXh2pFqlAlFZlyL2b OyprEF0PQClat2JdeCQHleY78pYfu5VZL9b3KLWh7r8HpUMJxT8cMICodgcT7SAeZz1M HoKmCu1c/7hzS1phdIJLGj7N1zx2PijzHxa7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:from:to:cc:subject :user-agent:date; bh=4cnCC9H4fJLav9+hSDYX1cOtIjCBJIUM/F01nX4r0sE=; b=AYf7Ts1PWd1+jJyy69slgZburvmpvWVffpXp8CmwwGO4IyV+6AyKZtiTAjLAqbGNeY /VG9ODKWlhowAxXxSw3dAFInO9mmYVgcj4kOJUh+pi/gmrrs1p7UOLWei6iKRNoCUG/s B2WunHxpw1QJ1d6MaEE5gfGPwKrey9TRGcseRQ6TLqUy9w3AfFOsS7dML8gh31YoGfhE Num05B54WS6IHmn9C63LuKTNFev87TQrLwxQjUvn9AWSfofneq285Dt13pfGrmJG1PJd Autlra30XuSf3wNtafO6xoXSHfpgBfjQD0W3ukO+7+8si7tO+aP9TbDiWlLt6J2EetQb pngQ== X-Gm-Message-State: APjAAAXKM2MGwYd1KaSPPVdSXPzWE5s6rJet7v4u24MEHuZAqCCfQevl VbgAR37k6Qt5s4wqsS5JoOGPEPFgDs8= X-Google-Smtp-Source: APXvYqyzLy03yLDhJOmpLNtDcL9DndWAkQMUpUVjgIvPtyVWjZ8BjTdnBnsSrxFiBU6W61jBDclvig== X-Received: by 2002:a62:8286:: with SMTP id w128mr15190685pfd.240.1570169867058; Thu, 03 Oct 2019 23:17:47 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id c7sm4439410pfr.75.2019.10.03.23.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 23:17:46 -0700 (PDT) Message-ID: <5d96e40a.1c69fb81.5a60f.fd3a@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20191004055057.GH63675@minitux> References: <1570146710-13503-1-git-send-email-mnalajal@codeaurora.org> <5d96daca.1c69fb81.fe5e4.e623@mx.google.com> <20191004055057.GH63675@minitux> From: Stephen Boyd To: Bjorn Andersson Cc: Murali Nalajala , gregkh@linuxfoundation.org, rafael@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] base: soc: Handle custom soc information sysfs entries User-Agent: alot/0.8.1 Date: Thu, 03 Oct 2019 23:17:45 -0700 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Bjorn Andersson (2019-10-03 22:50:57) > On Thu 03 Oct 22:38 PDT 2019, Stephen Boyd wrote: >=20 > > Quoting Murali Nalajala (2019-10-03 16:51:50) > > > @@ -151,14 +156,16 @@ struct soc_device *soc_device_register(struct s= oc_device_attribute *soc_dev_attr > > > =20 > > > ret =3D device_register(&soc_dev->dev); > > > if (ret) > > > - goto out3; > > > + goto out4; > > > =20 > > > return soc_dev; > > > =20 > > > -out3: > > > +out4: > > > ida_simple_remove(&soc_ida, soc_dev->soc_dev_num); > > > put_device(&soc_dev->dev); > > > soc_dev =3D NULL; > > > +out3: > > > + kfree(soc_attr_groups); > >=20 > > This code is tricky. put_device(&soc_dev->dev) will call soc_release() > > so we set soc_dev to NULL before calling kfree() on the error path. This > > way we don't doubly free a pointer that the release function will take > > care of. I wonder if the release function could free the ida as well, > > and then we could just make the device_register() failure path call > > put_device() and return ERR_PTR(ret) directly. Then the error path is > > simpler because we can avoid changing two pointers to NULL to avoid the > > double free twice. Or just inline the ida remove and put_device() call > > in the if and then goto out1 to consolidate the error pointer > > conversion. > >=20 >=20 > But if we instead allocates the ida before the soc_dev, wouldn't the > error path be something like?: >=20 > foo: > put_device(&soc_dev->dev); > bar: > ida_simple_remove(&soc_ida, soc_num); > return err; >=20 >=20 > I think we still need two exit paths from soc_device_register() > regardless of moving the ida_simple_remove() into the release, but we > could drop it from the unregister(). So not sure if this is cleaner... >=20 It doesn't seem "safe" to let the number be reused before the device is destroyed by put_device(). It would be clearer to do all the cleanup from the release function so that the soc_device_unregister() path isn't racy with another device being registered and reusing the same ID. Of course this probably doesn't matter because the race I'm talking about is extremely unlikely given there's only ever one soc device. Reordering the put and remove would be fine too.