Content-Type: multipart/mixed; boundary="===============2172872946834672809==" MIME-Version: 1.0 From: Stephen Boyd To: kbuild-all@lists.01.org Subject: Re: [daniel.lezcano:thermal/linux-next 11/16] drivers/thermal/qcom/tsens.c:123:1-7: ERROR: missing put_device; call of_find_device_by_node on line 103, but without a corresponding object release within this function. (fwd) Date: Fri, 18 Oct 2019 07:38:00 -0700 Message-ID: <5da9ce49.1c69fb81.c0de4.fd43@mx.google.com> In-Reply-To: List-Id: --===============2172872946834672809== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Quoting Amit Kucheria (2019-10-18 05:24:03) > On Thu, Oct 17, 2019 at 3:54 PM Julia Lawall wro= te: > > > > Hello, > > > > Perhaps pdev should be released or save somewhere before leaving the > > function. > > > > If this is a false positive, I can update the rule. > > > > julia > = > Thanks for the report, Julia. > = > I believe the following patch fixes this issue. Can you confirm? > = > Daniel, would you like me to respin the series with this fix squashed > or will you take this patch on top of thermal-next? > = You shouldn't even need the assignment to 0 for ret because it is implicitly equal to 0 at the point in the code. --===============2172872946834672809==--