From: Stephen Boyd Subject: Re: [PATCH v1 1/2] drm/panel: add support for rm69299 visionox panel driver Date: Thu, 14 Nov 2019 09:15:24 -0800 Message-ID: <5dcd8bad.1c69fb81.7569b.3b13@mx.google.com> References: <1573726588-18897-1-git-send-email-harigovi@codeaurora.org> <1573726588-18897-2-git-send-email-harigovi@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1573726588-18897-2-git-send-email-harigovi@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Cc: Harigovindan P , linux-kernel@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, hoegsberg@chromium.org, abhinavk@codeaurora.org, jsanka@codeaurora.org, chandanu@codeaurora.org, nganji@codeaurora.org List-Id: dri-devel@lists.freedesktop.org Quoting Harigovindan P (2019-11-14 02:16:27) > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu= /drm/panel/panel-visionox-rm69299.c > new file mode 100644 > index 0000000..faf6d05 > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > @@ -0,0 +1,478 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include This is included twice. It's really a panel! > +#include > + > +#include Is this include used? > +#include > +#include > +#include Is this include used? > +#include Is this include used? > +#include > +#include > +#include > +#include > + > +#include